[libvirt] [PATCH 0/6] use VIR_AUTO* all around qemu_driver.c

Daniel Henrique Barboza posted 6 patches 4 years, 6 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190918145658.29895-1-danielhb413@gmail.com
There is a newer version of this series
src/qemu/qemu_driver.c | 519 ++++++++++++++---------------------------
1 file changed, 170 insertions(+), 349 deletions(-)
[libvirt] [PATCH 0/6] use VIR_AUTO* all around qemu_driver.c
Posted by Daniel Henrique Barboza 4 years, 6 months ago
I am messing a lot with qemu_driver.c and other QEMU files due
to a multifunction PCI feature I'm working on, ending up
sometimes moving code here and there, sometimes copy and
pasting parts of it, and spreading all these 'vices', namely
using char* and VIR_FREE() and virQEMUDriverConfigPtr with
virObjectUnref(), knowing that there is a better way of doing
it.

Instead of changing just the code I was working on, I took
a leap and ended up changing the whole qemu_driver.c file.
So here it is.

The changes were split to make it reviewing a bit saner. The
commiter can squash these in fewer patches if desirable.


This was done on top of master commit bc1e4389f5.

Daniel Henrique Barboza (6):
  qemu_driver: use VIR_AUTOUNREF() with virQEMUDriverConfigPtr 1/3
  qemu_driver: use VIR_AUTOUNREF() with virQEMUDriverConfigPtr 2/3
  qemu_driver: use VIR_AUTOUNREF() with virQEMUDriverConfigPtr 3/3
  qemu_driver: use VIR_AUTOFREE() with strings 1/3
  qemu_driver: use VIR_AUTOFREE() with strings 2/3
  qemu_driver: use VIR_AUTOFREE() with strings 3/3

 src/qemu/qemu_driver.c | 519 ++++++++++++++---------------------------
 1 file changed, 170 insertions(+), 349 deletions(-)

-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list