From nobody Sat Feb 7 15:26:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1568235953; cv=none; d=zoho.com; s=zohoarc; b=a+j3RZZbILsxmj0BHJaVBZqYFuHW8bbl2Ait22/ESdt6FULXWN0Awy5oczk3BHUk5aQzN9add8Bv0gWnN631fij6+GWympgIvJhI+kJdeu3/vxkL21aKqquVGTbNhfTdthRgGj8A5qTGJRxTWmJcPEqAhflqWmZk+Ow+2rykI/g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568235953; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=aEQ8Ddw3nWUTsULWhkS/g4gASRs5m4ltswOMU+s0+UA=; b=brboaRCPSdNfOgJy9QEFvz2edoUQPSYv/kNs1v0BhjY1enhTYnWxQrppOhXjJtOqw/9SVqHus+fc8pwuP2nP6MzihnSW5fOWF1t7TsOktrjA2km81eEDT+vnzAbmu/ke4k84IB8eeS8M45RQWUBevzeiLrtpZwJf8eVrTO3ZpUM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1568235953851629.0321255859233; Wed, 11 Sep 2019 14:05:53 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 780901DAD; Wed, 11 Sep 2019 21:05:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5CCF60920; Wed, 11 Sep 2019 21:05:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F218D1802220; Wed, 11 Sep 2019 21:05:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8BL5kWJ027161 for ; Wed, 11 Sep 2019 17:05:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id F346D5D6D0; Wed, 11 Sep 2019 21:05:45 +0000 (UTC) Received: from mx1.redhat.com (ext-mx12.extmail.prod.ext.phx2.redhat.com [10.5.110.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC9765D6A9 for ; Wed, 11 Sep 2019 21:05:45 +0000 (UTC) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EB4663091755 for ; Wed, 11 Sep 2019 21:05:44 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id z67so22231370qkb.12 for ; Wed, 11 Sep 2019 14:05:44 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:2859:7136:a26f:ae4f:69fe]) by smtp.gmail.com with ESMTPSA id r55sm13927141qtj.86.2019.09.11.14.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2019 14:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NOy1YEklA9MnB/7pQVJVFAYA2hWNkZw/AmvLkfGoq4Q=; b=WzNdlvhkdLBWJNTes69m6TKYLLnvyEW6tzAOKbQPRpQdvSAA8NXlybIWpJcs3bwxYT 7T2US39N+Oj8bFiDxteV5Lpt+qu7takUVmXQif+Ej5nbMzZJwUSXAqutQlSUzauZBSEB EzAfjANdi9fjk2Vk82KDogSIjTaUdK8ur6DXbOqvZy3CiZnMhWSih9S3HdxcNsCVmYUg c5fza5DHirTI4UkNnNJw03B7nkUpc3wVpEbNrC2VVPRuxJEUALAL+hBVFR5LDt8EVTTh Gm87bzrbfHNpsNinTTnn/kzM9FoNOfAoF7dbubO44wZ/hF8f8CwOYYrJeqaks/TUSsXw R2vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NOy1YEklA9MnB/7pQVJVFAYA2hWNkZw/AmvLkfGoq4Q=; b=Ygj27TzLmEpj5Ss9fNHPwiYBqC5D7XSzt8OeLVTuJokzQDVGB0YdDvWGy7hrs7Rr15 RrHRa7WOV29DMLlhoVhCL2ewxGgGjscEb/864c/PwSbusb3ixzzm7b05HjGk+GhyaMHS gIWT2mkhK/YA58O0IlG9dmCtCXQion2QIdHSGIR6XQ5xApMf8o1tn1zJeQJindpQLvkh YD0UW6MtY9Q4nteiqsISMarioiMtNK0TrSGSDDHCveQZ/ZOyjwttx5hS7x8YFNGxN88X eKw2ttLGqYo652UAVqKoJd6kEueDTnHkme8o+E5C56ZaYJGTsvDrEiSSLRM9W4uvQzdr uY7w== X-Gm-Message-State: APjAAAXzYABAf4KkbRzWM4eur44nPIlzqvQ1KKO+C0ADtqtliHKZBA6O Hp/hs8AKIIB6AvYsfMQOIFCSuU38i/U= X-Google-Smtp-Source: APXvYqyqzVVv4snA0J/CWpoAZWEOJ62ZCJtg9DMweY1ScVceSOSgNbNzyp5SMjAYDy9g9TcPJjI1zw== X-Received: by 2002:a37:804:: with SMTP id 4mr6779954qki.97.1568235944169; Wed, 11 Sep 2019 14:05:44 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Date: Wed, 11 Sep 2019 18:05:29 -0300 Message-Id: <20190911210529.11766-4-danielhb413@gmail.com> In-Reply-To: <20190911210529.11766-1-danielhb413@gmail.com> References: <20190911210529.11766-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 11 Sep 2019 21:05:45 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 11 Sep 2019 21:05:45 +0000 (UTC) for IP:'209.85.222.173' DOMAIN:'mail-qk1-f173.google.com' HELO:'mail-qk1-f173.google.com' FROM:'danielhb413@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.15 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS) 209.85.222.173 mail-qk1-f173.google.com 209.85.222.173 mail-qk1-f173.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.41 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza Subject: [libvirt] [PATCH v2 3/3] qemu_hotplug: make setvcpus timeout error message user-friendlier X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.71]); Wed, 11 Sep 2019 21:05:52 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The current 'setvcpus' timeout message requires a deeper understanding of QEMU/Libvirt internals to proper react to it. One who knows how setvcpus unplug work (it is an asynchronous operation between QEMU and guest that Libvirt can't know for sure if it failed, unless an explicit error happened during the timeout period) will read the message and not assume a failed operation. But the regular user, most often than not, will read it and believe that the unplug operation failed. This leads to situations where the user isn't exactly relieved when accessing the guest and seeing that the unplug operation worked. Instead, the user feel mislead by the timeout message setvcpus threw. Changing the timeout message to let the user know that the unplug status is not known, and manual inspection in the guest is required, is not a silver bullet. But it gives a more realistic expectation of what happened, as best as we can tell from Libvirt side anyways. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index d3a3e25f08..53051807d7 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -6105,8 +6105,9 @@ qemuDomainHotplugDelVcpu(virQEMUDriverPtr driver, =20 if ((rc =3D qemuDomainWaitForDeviceRemoval(driver, vm)) <=3D 0) { if (rc =3D=3D 0) - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("vcpu unplug request timed out")); + virReportError(VIR_ERR_OPERATION_TIMEOUT, "%s", + _("vcpu unplug request timed out. Unplug result= " + "must be manually inspected in the domain")); =20 goto cleanup; } --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list