From nobody Sat Feb 7 15:26:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1568235967; cv=none; d=zoho.com; s=zohoarc; b=d1ZTF6S7dmC+H5riRMoZucYyVmmVxSkPyAsup4hl8tGR4IqeRffSax9apMBCsV4O4cSudri+4nasIjd2grpRjZgD1X7BQvhBX58LXCH6koNbALoJiuQqEYnew9domj1ganBeItjaT8qassEi9cC3hPdrfmeCmC2j9x/5UwASuy0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568235967; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=VoJFdL1uWhdvEsYtoQs2PqQ8zpUflUZdrgfa2GRELsE=; b=jSZrtKtanllEVyGFpxmfINljTZq2mCO1BFiE9iFFPUYp323uymAM+VCaHsIKxeDIzHj61WVLBOICFv1CheRvksE0jQDh5BCEUkY2Y66UQjmIGlu67PcnNDfQIFjXLyDaM0VC4JXR/jErjuIqc7qJA2wllUAfGhz//Exvii7lGv4= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1568235967837913.7669676284762; Wed, 11 Sep 2019 14:06:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BCFB43DE31; Wed, 11 Sep 2019 21:06:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 927065C258; Wed, 11 Sep 2019 21:06:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4BCB8E205; Wed, 11 Sep 2019 21:06:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8BL5mYR027179 for ; Wed, 11 Sep 2019 17:05:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5C2CE5DD78; Wed, 11 Sep 2019 21:05:48 +0000 (UTC) Received: from mx1.redhat.com (ext-mx27.extmail.prod.ext.phx2.redhat.com [10.5.110.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 548A35DA5B for ; Wed, 11 Sep 2019 21:05:44 +0000 (UTC) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B0063A37187 for ; Wed, 11 Sep 2019 21:05:43 +0000 (UTC) Received: by mail-qk1-f176.google.com with SMTP id i78so22263177qke.11 for ; Wed, 11 Sep 2019 14:05:43 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:2859:7136:a26f:ae4f:69fe]) by smtp.gmail.com with ESMTPSA id r55sm13927141qtj.86.2019.09.11.14.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2019 14:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9kXZ4nYLhGHyAKVr4fxQRi/pS8nMoM/RTlV1Kz8ttIk=; b=fG/xKmeM5zxPqljbRu7TUKV0eXLiMOdL4xGLZ4XsiCboa5PsRCz019rqIzkLmuzLiH b3/3/dZesrUDPJ3ycEz+JNtMt6xHDwmvZE3y9cePjk+zymMc03e0dMi/rEFenyaFCZbw aRKx8V2Q4Xwha5m1rd5FKgQ0DEkG/USoK9J7E3DNdUEnjopKK/CAGn7cfnv8jkhPwwNB PlrjOSP33cgeexCiza1iiG4Ga51Br7BavZoK6FzOeKXp0s4H2Ezt7MVyPMA4aDqaUi1i namj+CljzDGKf0iqSK3DJjGYnNHz14T4qRjvQ+/RsWazuJG2qlkL14n3hSwx0wgbbWIj Vv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9kXZ4nYLhGHyAKVr4fxQRi/pS8nMoM/RTlV1Kz8ttIk=; b=sdxzs2aEKGEJHNr2WhwRE3WWVoYXEA53aHutACSKnSVH0w4f2wh3v7nDRX3GEGwoib FN7ztQamGswNSJdwOUwl+YTOtho1/1039gKWcNoMjtVZpvLttcX9GfNZtKinz4d43ZjZ oTiCvyN1wjYvlwnlgL2tLYq61D6b2wiZilYGRuchP7XaAn7kxgMxu3x4aFENSnV0XIBE DnVnoxhTSsIx3LAFvciRiY6raRksyIJEdPMHPvROX/9y7gCaaWG2wW87uTQSCe1UBsJ0 49P52ydg2DwmLgb0d3CNKbQGO2mBUgBpw/txHkBO+5AOsKSalJ0+zi0/O+sQzd6BIxam 9GEQ== X-Gm-Message-State: APjAAAWWxKX6geEMIBl8JrPZysQemLaMvsgFD/DYG5mjFeYegm76/jXx 0ZNo8zKXIYaf1VUAutY0iihAA/75+c4= X-Google-Smtp-Source: APXvYqyhcTmSrDt15i3KVmMj22Hl3m35lMhWX78SYFtEiixOUKqkw+cf1/OBWQ1YzwLSLbHwQWocVg== X-Received: by 2002:a05:620a:12a3:: with SMTP id x3mr19989349qki.379.1568235942875; Wed, 11 Sep 2019 14:05:42 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Date: Wed, 11 Sep 2019 18:05:28 -0300 Message-Id: <20190911210529.11766-3-danielhb413@gmail.com> In-Reply-To: <20190911210529.11766-1-danielhb413@gmail.com> References: <20190911210529.11766-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Wed, 11 Sep 2019 21:05:43 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Wed, 11 Sep 2019 21:05:43 +0000 (UTC) for IP:'209.85.222.176' DOMAIN:'mail-qk1-f176.google.com' HELO:'mail-qk1-f176.google.com' FROM:'danielhb413@gmail.com' RCPT:'' X-RedHat-Spam-Score: 0.15 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS) 209.85.222.176 mail-qk1-f176.google.com 209.85.222.176 mail-qk1-f176.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.68 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza Subject: [libvirt] [PATCH v2 2/3] qemu: Remove qemu_hotplugpriv.h and qemuDomainRemoveDeviceWaitTime X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 11 Sep 2019 21:06:06 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" qemu_hotplugpriv.h is a header file created to share a global variable called 'qemuDomainRemoveDeviceWaitTime', declared in qemu_hotplug.c, to other files that would want to change the timeout value (currently, only tests/qemuhotplugtest.c). Previous patch deprecated the variable, using qemu_driver->unplugTimeout to set the timeout instead. This means that the header file is now unused, and can be safely discarded. Signed-off-by: Daniel Henrique Barboza --- src/qemu/Makefile.inc.am | 1 - src/qemu/qemu_hotplug.c | 5 ----- src/qemu/qemu_hotplugpriv.h | 32 -------------------------------- tests/qemuhotplugtest.c | 1 - 4 files changed, 39 deletions(-) delete mode 100644 src/qemu/qemu_hotplugpriv.h diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 48fd0332ec..5f2198f6a5 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -29,7 +29,6 @@ QEMU_DRIVER_SOURCES =3D \ qemu/qemu_hostdev.h \ qemu/qemu_hotplug.c \ qemu/qemu_hotplug.h \ - qemu/qemu_hotplugpriv.h \ qemu/qemu_conf.c \ qemu/qemu_conf.h \ qemu/qemu_process.c \ diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4088cc5e8e..d3a3e25f08 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -23,8 +23,6 @@ #include =20 #include "qemu_hotplug.h" -#define LIBVIRT_QEMU_HOTPLUGPRIV_H_ALLOW -#include "qemu_hotplugpriv.h" #include "qemu_alias.h" #include "qemu_capabilities.h" #include "qemu_domain.h" @@ -63,9 +61,6 @@ VIR_LOG_INIT("qemu.qemu_hotplug"); =20 #define CHANGE_MEDIA_TIMEOUT 5000 =20 -/* Wait up to 5 seconds for device removal to finish. */ -unsigned long long qemuDomainRemoveDeviceWaitTime =3D 1000ull * 5; - =20 static void qemuDomainResetDeviceRemoval(virDomainObjPtr vm); diff --git a/src/qemu/qemu_hotplugpriv.h b/src/qemu/qemu_hotplugpriv.h deleted file mode 100644 index a5c443ba85..0000000000 --- a/src/qemu/qemu_hotplugpriv.h +++ /dev/null @@ -1,32 +0,0 @@ -/* - * qemu_hotplugpriv.h: private declarations for QEMU device hotplug manage= ment - * - * Copyright (C) 2013 Red Hat, Inc. - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library. If not, see - * . - * - */ - -#ifndef LIBVIRT_QEMU_HOTPLUGPRIV_H_ALLOW -# error "qemu_hotplugpriv.h may only be included by qemu_hotplug.c or test= suites" -#endif /* LIBVIRT_QEMU_HOTPLUGPRIV_H_ALLOW */ - -#pragma once - -/* - * This header file should never be used outside unit tests. - */ - -extern unsigned long long qemuDomainRemoveDeviceWaitTime; diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index da6258991d..03ff32e37e 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -23,7 +23,6 @@ #include "qemu/qemu_conf.h" #include "qemu/qemu_hotplug.h" #define LIBVIRT_QEMU_HOTPLUGPRIV_H_ALLOW -#include "qemu/qemu_hotplugpriv.h" #include "qemumonitortestutils.h" #include "testutils.h" #include "testutilsqemu.h" --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list