From nobody Thu Apr 25 20:08:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568029634; cv=none; d=zoho.com; s=zohoarc; b=RV8Ws23w2AM9UgAkIq+/pNt5VV+SxTYhk+JV9I053eSdjTeMPHBWy21NjdmKi47rqezHSx5zcanexjTNh6KpzYebywnPk+2zxCjSZd6dbAA5s3foqrdFs2Pihud552Gv+ppTkjJT4/TMvTSS6SP2kUtople7XPTyPuPDn1TRKHY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568029634; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=jTFeUHkrRI7zarMXUjNJ21WXgl3gnl8DnRoiPcyIqX0=; b=GE3ZcpyeVriKgrR+08gaMyneYNKS9RYiO4cSFIlF+LsHBgQQ+pVKF+pwujNORE2qDuneQx33l3l+GuThoPeymPJz7Qzv1SRGfCpCNmGqwf0j2kxCpCbZp1hzBhHtomk+QAsgvbA/E+EvjxEwyZh0H1DifSdFZm4Qmc+7aUU2ZtI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1568029634958391.7952949695325; Mon, 9 Sep 2019 04:47:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C9D1B36961; Mon, 9 Sep 2019 11:47:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 767911001948; Mon, 9 Sep 2019 11:47:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AAEC94A486; Mon, 9 Sep 2019 11:47:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x89Bl9Yg014490 for ; Mon, 9 Sep 2019 07:47:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id C0D6560A9D; Mon, 9 Sep 2019 11:47:09 +0000 (UTC) Received: from laerte.brq.redhat.com (unknown [10.43.2.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0A5760A35; Mon, 9 Sep 2019 11:47:04 +0000 (UTC) From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Mon, 9 Sep 2019 13:47:03 +0200 Message-Id: <20190909114703.18891-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= , abologna@redhat.com Subject: [libvirt] [jenkins-ci PATCH] lcitool: Generate the en_US.UTF-8 locale for deb containers X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 09 Sep 2019 11:47:13 +0000 (UTC) osinfo-db tests require "en_US.UTF-8" locate to be set. Since commit 3b682c416b0d the locales are installed but we have to actually generate it for the containers. The reason we don't have to do that for the virtual machines is because the preseed file used for installed them already forces it: ``` # Environment configuration # # Locale, keyboard and timezone. All these will be configured again # later with Ansible, but they're required information so we must # provide them d-i debian-installer/locale string en_US.UTF-8 ``` Signed-off-by: Fabiano Fid=C3=AAncio --- guests/lcitool | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index 5cf8efe..5b5b622 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -675,7 +675,9 @@ class Application: {package_manager} dist-upgrade -y && \\ {package_manager} install --no-install-recommends -y {= pkgs} && \\ {package_manager} autoremove -y && \\ - {package_manager} autoclean -y + {package_manager} autoclean -y && \\ + sed -Ei 's,^# (en_US\.UTF-8 .*)$,\\1,' /etc/locale.gen= && \\ + dpkg-reconfigure locales """).format(**varmap)) if args.cross_arch: # Intentionally a separate RUN command from the above --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list