From nobody Thu Apr 25 16:33:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567779355; cv=none; d=zoho.com; s=zohoarc; b=PrP01ZwyisanvOOVtE9+KQ/FjyGKjwIzrhqIKv7svzAlINDRGj8tHBOIvEEokZ7LsgP8UOHi/qSGpdBIJzUy2jmSqK432SE8zDgd+f9l52f6QxxOLq4WEdlRFpy6kLf3RH+6xKWoLQl/qmc71A9jFB6pvXGld81HpwD2ZrbDGn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567779355; h=Content-Type:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=SOmyqQ/RyVsZofSBTbQfsZm1qt+77z1OJ7UVGQPuFHU=; b=aBWZKmEhF7cyzkAj2wfDsKxfBkoydJNMQT1B6rKu7AadVMsf7Fu3H/fmF0sssvvRdFG6HWIgeLxz6R6vq3ynLe4DYUODrgp9u3eVZGBBj2S7eHUJrXjjOtbADPVbHyyRbDDLy69En1L+wFLXtItxTtI8GAaQqejr7n6856GzT4A= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567779355493419.1443880740104; Fri, 6 Sep 2019 07:15:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A820A10F23F8; Fri, 6 Sep 2019 14:15:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01470453F; Fri, 6 Sep 2019 14:15:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B604C1802217; Fri, 6 Sep 2019 14:15:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x86ED7pY017271 for ; Fri, 6 Sep 2019 10:13:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9FD525DAAC; Fri, 6 Sep 2019 14:13:07 +0000 (UTC) Received: from mx1.redhat.com (ext-mx18.extmail.prod.ext.phx2.redhat.com [10.5.110.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9A0E65DA8C for ; Fri, 6 Sep 2019 14:13:03 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E7AB930821A3 for ; Fri, 6 Sep 2019 14:13:01 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 047FC4E6 for ; Fri, 6 Sep 2019 10:13:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 06 Sep 2019 10:13:01 -0400 Received: from mail-itl (unknown [83.97.23.29]) by mail.messagingengine.com (Postfix) with ESMTPA id ED7ADD60069 for ; Fri, 6 Sep 2019 10:12:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=3ggNCRpz4SJeX60xrhHezGh/4MZlo mrFIKeUXQ6PM64=; b=QrGNuSoJIXGahK4cuxVwXQAQQL123D6dI3R/cPmDI9aYJ 2/upAC6XVpdVMlBI3kEWdzWeA1NYjiUfYwL6C9PuBD+9pyfqtckA0yJYVPG37w/K 3Vow86pQz0ocYf576y39EizMPxdcDVh1kkW0kNHt5SmQvk1nA+8j20EiTJOcl8Zn 0uqXwy+8c+IGd3o5WmL7Ktyk5kndfVBx+Z8YZcHjFp4ZKbk8o6bS+gcyUArQ1A6w YXG6DYN/l/Mrqm3v6KgqFaKVsMAtXgVoPsR7RxPDw0S748YfDsRafRee9xCe82ps UiBrlLCmwgrsc57gCfiSnTvbGAJq3aMyjEEh+gs6Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejledgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesghdtreertd dtjeenucfhrhhomhepofgrrhgvkhcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhi uceomhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqne cukfhppeekfedrleejrddvfedrvdelnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghr mhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Date: Fri, 6 Sep 2019 16:12:55 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: libvir-list@redhat.com Message-ID: <20190906141255.GA21192@mail-itl> MIME-Version: 1.0 X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 238 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 06 Sep 2019 14:13:02 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 06 Sep 2019 14:13:02 +0000 (UTC) for IP:'64.147.123.24' DOMAIN:'wout1-smtp.messagingengine.com' HELO:'wout1-smtp.messagingengine.com' FROM:'marmarek@invisiblethingslab.com' RCPT:'' X-RedHat-Spam-Score: -0.7 (DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_NONE) 64.147.123.24 wout1-smtp.messagingengine.com 64.147.123.24 wout1-smtp.messagingengine.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.47 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] libxl: Fix libxlDomainPMSuspendForDuration domain active check X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2971080170220567395==" Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Fri, 06 Sep 2019 14:15:54 +0000 (UTC) X-Zoho-Virus-Status: 1 --===============2971080170220567395== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: [PATCH] libxl: Fix libxlDomainPMSuspendForDuration domain active check virDomainObjCheckActive() returns -1 if domain is not active, not 0. Fixes cb50436c6f "libxl: implement virDomainPM* functions" Signed-off-by: Marek Marczykowski-G=C3=B3recki --- src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index d0396e4781..215471fa0d 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1459,7 +1459,7 @@ libxlDomainPMSuspendForDuration(virDomainPtr dom, if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) goto cleanup; =20 - if (!virDomainObjCheckActive(vm)) + if (virDomainObjCheckActive(vm) < 0) goto endjob; =20 /* Unlock virDomainObjPtr to not deadlock with even handler, which wil= l try --=20 2.21.0 --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl1yaWcACgkQ24/THMrX 1yyLKgf+Nkk8X89IADWZh0g9qNEELvzwYpxkS7ECYq9CEmJ07KaNNDC/ZN14q5aV NCDh8cYFvFGBQRTnZ3jU9KJl042cO5gMCJ4R31BXKXx2TsF2LO8bSDfE9nsl1ZIH cEJZAQ214MOca6I8nUl4SY0SxeLYxvjPmUWgYIhKyiAUvNfnM+pxZPPi+uLtxE7e XjVgH3WbS1p653DRk5wdpZG8K5QD5Ox9MRsOgpnBMQBP/uZzmY55Uw0bQPIFnze9 D0hSC2Y7kSkXphLjgdrOC0Rj9xrMMchIu39/ExWmAuRuCQpLgDiS4rvSH57sjQIZ 2vRiBbswpSdjxhVJUE+d7vzO4swDgA== =bhFG -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s-- --===============2971080170220567395== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list --===============2971080170220567395==--