From nobody Thu May 2 15:29:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567182408; cv=none; d=zoho.com; s=zohoarc; b=RVScs7il4orQq/rEtBJ9xhPmMwwxyLbobrKT3EqFJXeS8FiijE3TWlpy/29QqVxlCwcvxi62Ztv5QeTKJb4Rwer2Z/axUJMrNlTsm/rYIWvJF0BI+dsYP4499QmnVeCI5MoADCmKbG1mUdVb3Cxv6m+6gfR/5Vn/edqqr24H/5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567182408; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=EoYxN+oKgh+RKbgEe0gjXACBkWYgBPk1/d8rEYr6qpk=; b=ECcCkcWjVmpAnDbsjtejIGgWzxrL3EvE+3lCjDONa46SqovER2minT2Kh2ojRTYcI3By4luwWr4CSxqmVafN8jriLtJQh4cCkHgBDGAaUPL1qSdoyiNzqqg/8rtyD2h8VzASdyWjT5ZFgc0nfArXkUU2Q7RQwF8oshvFW/OhCq8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567182408010236.9573764688531; Fri, 30 Aug 2019 09:26:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9384317528A; Fri, 30 Aug 2019 16:26:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 73EBE6012C; Fri, 30 Aug 2019 16:26:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B19FA1806B01; Fri, 30 Aug 2019 16:26:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7UGQfOR028195 for ; Fri, 30 Aug 2019 12:26:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id EE6594516; Fri, 30 Aug 2019 16:26:41 +0000 (UTC) Received: from himantopus.redhat.com (ovpn-116-130.phx2.redhat.com [10.3.116.130]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD3B74513 for ; Fri, 30 Aug 2019 16:26:39 +0000 (UTC) From: Jonathon Jongsma To: libvir-list@redhat.com Date: Fri, 30 Aug 2019 11:09:09 -0500 Message-Id: <20190830160909.6419-1-jjongsma@redhat.com> In-Reply-To: <80b41a42-93e2-7aa9-82f8-292070c71dd8@redhat.com> References: <80b41a42-93e2-7aa9-82f8-292070c71dd8@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: Validate arg in qemuAgentErrorComandUnsupported() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 30 Aug 2019 16:26:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Coverity noted that 'reply' can be NULL after calling qemuAgentCommand(). Avoid dereferencing reply in qemuAgentErrorComandUnsupported() in that case. Signed-off-by: Jonathon Jongsma Reviewed-by: John Ferlan --- src/qemu/qemu_agent.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index fddedf5cb6..34e1a85d64 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1005,7 +1005,12 @@ static bool qemuAgentErrorCommandUnsupported(virJSONValuePtr reply) { const char *klass; - virJSONValuePtr error =3D virJSONValueObjectGet(reply, "error"); + virJSONValuePtr error; + + if (!reply) + return false; + + error =3D virJSONValueObjectGet(reply, "error"); =20 if (!error) return false; --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list