From nobody Tue May 7 00:43:38 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567087001; cv=none; d=zoho.com; s=zohoarc; b=RgNvrO2q5ZI5NfZn4XUEaKvYVis1y/Hp+Fu5Z3M46iKFRg75yC5EOIvrF6ZrpoHq32LonaAQFJZrl3xHGT96kQnktUkGyX/izsGZe4Fa9Jfs1hpWwbth3dtAitUHl0g/ciAgbygTz7dg/cKQyjkDXgPiT27cILkywRjPA8opwR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567087001; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=SLVKi+UC+5WHfpzy1oKwFyfdQ0HmYwztZUWkReaUM10=; b=SFcPZY8jGhZReSrHF6HG2mP4iac79WLGrlsg9IypQB77YxEypcrLsbJzlXBlO9PtESnKNCOJJ2PJB7L8KLPbzmeNjX3gVu12xEpXnKXz9/2VYx2DOBwEKtYucKHpeiVhIbfBSzCsXWEk2EnOGe2lYbT090l0Z9Iehc4oIqXRGM4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567087001241453.5670513213594; Thu, 29 Aug 2019 06:56:41 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 03211308FBA0; Thu, 29 Aug 2019 13:56:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E90019D7A; Thu, 29 Aug 2019 13:56:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 941D02551C; Thu, 29 Aug 2019 13:56:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7TDuavf012002 for ; Thu, 29 Aug 2019 09:56:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6F9705D721; Thu, 29 Aug 2019 13:56:36 +0000 (UTC) Received: from himantopus.redhat.com (ovpn-116-135.phx2.redhat.com [10.3.116.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DF8F54527; Thu, 29 Aug 2019 13:56:33 +0000 (UTC) From: Jonathon Jongsma To: libvir-list@redhat.com Date: Thu, 29 Aug 2019 08:56:29 -0500 Message-Id: <20190829135629.3886-1-jjongsma@redhat.com> In-Reply-To: <20190829065009.GA27413@ridgehead> References: <20190829065009.GA27413@ridgehead> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: eskultet@redhat.com Subject: [libvirt] [PATCH v2] qemu: agent: fix potential leak in qemuAgentGetFSInfo() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 29 Aug 2019 13:56:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" On error paths, info_ret could potentially leak. Make sure it's freed. Signed-off-by: Jonathon Jongsma Reviewed-by: Erik Skultety --- src/qemu/qemu_agent.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index c63db968c6..a4113460bd 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2208,6 +2208,7 @@ qemuAgentGetFSInfo(qemuAgentPtr mon, virDomainFSInfoFree(info_ret[i]); } VIR_FREE(agentinfo); + VIR_FREE(info_ret); return ret; } =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list