From nobody Sat May 4 07:23:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1567018106; cv=none; d=zoho.com; s=zohoarc; b=ft/oFRNYOYSppMnW2Zhza8+K5L1pF2YYm9BjJUDJGIuSz4IPHt9bhcKv3hZW3BB4QNo5C39taPvp4Ph9kUoGvb3X6h1x7/Ua17zB9e95UsBlq6/JjcpuBewOM7dvBUv8vjg/fbhfAK2xRVjoeo0MT+Xa0weoAHz1PwAd890CUE4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1567018106; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=eh7xn1/ngeWeUn1ZjTBkbaxq1eApiZNpnhyIJFi68IA=; b=Yy5x49sXjkJUEnDrnboT1kW/CIKOfXPqpXeewq5RWFjFHNVhfUeWyRvGpbPEN4LdGxW+BZgnZowgciWyqw3AjVEAhyHl2TT09NsHrkmWiZ2214jb2zZ1HLIB2yT0NBV/99V8qdBvLjqbk+1s0SkAWhoaAbnpZDOAtxTrsOOAl4s= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1567018106052603.971356322939; Wed, 28 Aug 2019 11:48:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 34A108B5FF0; Wed, 28 Aug 2019 18:48:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C0FD60F82; Wed, 28 Aug 2019 18:48:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4F77924F68; Wed, 28 Aug 2019 18:48:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7SImJ5M013272 for ; Wed, 28 Aug 2019 14:48:19 -0400 Received: by smtp.corp.redhat.com (Postfix) id C3F585DC18; Wed, 28 Aug 2019 18:48:19 +0000 (UTC) Received: from himantopus.redhat.com (ovpn-116-135.phx2.redhat.com [10.3.116.135]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 921F15DD6C for ; Wed, 28 Aug 2019 18:48:17 +0000 (UTC) From: Jonathon Jongsma To: libvir-list@redhat.com Date: Wed, 28 Aug 2019 13:48:14 -0500 Message-Id: <20190828184814.14464-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: agent: fix potential leak in qemuAgentGetFSInfo() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Wed, 28 Aug 2019 18:48:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" On error paths, info_ret could potentially leak. Make sure it's freed. Reviewed-by: Erik Skultety --- Thanks to John Ferlan for the catch. Apparently this got missed before the patch was merged src/qemu/qemu_agent.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index c63db968c6..a4113460bd 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -2208,6 +2208,7 @@ qemuAgentGetFSInfo(qemuAgentPtr mon, virDomainFSInfoFree(info_ret[i]); } VIR_FREE(agentinfo); + VIR_FREE(info_ret); return ret; } =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list