From nobody Tue Apr 30 21:02:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566373510; cv=none; d=zoho.com; s=zohoarc; b=di2bSS9A9bajj7dGWNmnuw/3UehFKYeOmPwBrmzpCHhrgLgsn8NTA1QAnSuD3KqiVCgWwN6/ArseZ9uIBy6MQQOpZ6zLnkLB4ydzH9bYl6eU/VKfOWlNSJ0U2NaqC5/IDfNoyjn+NhKx6N+JaT4S1iajYVW13vWmYBsPWDcXn5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566373510; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=njTy9mN/FkX2qssXOyzuRr2PyeHypLld80d6fYxSFtY=; b=ZK/g9f3iBnfOdlBxTwf6E/AmC/IyB31CsmDbmMLUAM0wrxfq6Y6B6Mk4KUcGRp5sAG5lQb+jFLFz+3g5dRk49PllllTodKAAEXVH5DhfMT1ixtA7IcAiPv5/P8dqJZMsddUekf2zGeEuJfgKpNq1zscAh7O9XquQS36kLdy0Cuo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566373510008762.7977590843319; Wed, 21 Aug 2019 00:45:10 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9535C3083362; Wed, 21 Aug 2019 07:45:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 473492B9CD; Wed, 21 Aug 2019 07:45:07 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5FBD1806B00; Wed, 21 Aug 2019 07:45:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7L7j5xr028063 for ; Wed, 21 Aug 2019 03:45:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id A844F5C231; Wed, 21 Aug 2019 07:45:05 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 07CB25C541; Wed, 21 Aug 2019 07:45:02 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Wed, 21 Aug 2019 09:45:01 +0200 Message-Id: <20190821074501.27990-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virt-aa-helper: Drop unnecessary AppArmor rule X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 21 Aug 2019 07:45:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Apparently /proc/self is automatically converted to /proc/@{pid} before checking rules, which makes spelling it out explicitly redundant. Suggested-by: Jamie Strandboge Signed-off-by: Andrea Bolognani Reviewed-by: Martin Kletzander --- src/security/apparmor/usr.lib.libvirt.virt-aa-helper | 1 - 1 file changed, 1 deletion(-) diff --git a/src/security/apparmor/usr.lib.libvirt.virt-aa-helper b/src/sec= urity/apparmor/usr.lib.libvirt.virt-aa-helper index 64772f0756..11e9c039ca 100644 --- a/src/security/apparmor/usr.lib.libvirt.virt-aa-helper +++ b/src/security/apparmor/usr.lib.libvirt.virt-aa-helper @@ -18,7 +18,6 @@ profile virt-aa-helper /usr/{lib,lib64}/libvirt/virt-aa-h= elper { @{PROC}/filesystems r, =20 # Used when internally running another command (namely apparmor_parser) - @{PROC}/self/fd/ r, @{PROC}/@{pid}/fd/ r, =20 /etc/libnl-3/classid r, --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list