From nobody Thu Apr 25 16:48:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566222472; cv=none; d=zoho.com; s=zohoarc; b=NU8nw4VW/VWzSdRoG1rjj/pjR6uKRJBP5lkZKB0jPriGkTb7fGse8U/rlMlTuuy68swmPhKd9ANFVHip3cQfVr64vZyVC5J8qhvIgyoTsbBw0D12JwpIi5hvIayh7aoA4tJdjVeSjUeZbvMPIyFgdax0kn3x5AqZTxS8QiFTzHU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566222472; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=vQ68KafvVY9VdjT8jrb6SmjnwZawAKvNcVl+h1C4AKc=; b=fD8+ifjT5wN9elrEwvpP76ZZNwG865jjPawDPnmzT8RLUQBMBjgpDogPhn9PjgXbNJYIBjQmJ44RPEIhURJcXq1r23NtpzkdXo5AxZy/CsM50hTvko8COyrTyFO1JxRucA4NM3j7lzY+XBMmWqE7KRsGUNsLvPqTjnGt7YCwyFU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566222472787535.3273512915748; Mon, 19 Aug 2019 06:47:52 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 800F03082B5A; Mon, 19 Aug 2019 13:47:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5392EB32BE; Mon, 19 Aug 2019 13:47:51 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0C30024F33; Mon, 19 Aug 2019 13:47:51 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7JDldJX011528 for ; Mon, 19 Aug 2019 09:47:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0A2C080696; Mon, 19 Aug 2019 13:47:39 +0000 (UTC) Received: from localhost.localdomain (dhcp-94.gsslab.fab.redhat.com [10.33.9.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64E24859BA; Mon, 19 Aug 2019 13:47:38 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Mon, 19 Aug 2019 14:47:33 +0100 Message-Id: <20190819134734.102779-2-berrange@redhat.com> In-Reply-To: <20190819134734.102779-1-berrange@redhat.com> References: <20190819134734.102779-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [glib PATCH 1/2] gobject: remove use of G_PARAM_PRIVATE X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Mon, 19 Aug 2019 13:47:52 +0000 (UTC) This enum field is a deprecated synonym for G_PARAM_STATIC_NAME which is already set by G_PARAM_STATIC_STRINGS. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- libvirt-gobject/libvirt-gobject-network-dhcp-lease.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c b/libvirt= -gobject/libvirt-gobject-network-dhcp-lease.c index 9c40288..1824138 100644 --- a/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c +++ b/libvirt-gobject/libvirt-gobject-network-dhcp-lease.c @@ -121,7 +121,6 @@ static void gvir_network_dhcp_lease_class_init(GVirNetw= orkDHCPLeaseClass *klass) "The lease handle= ", G_PARAM_READWRITE= | G_PARAM_CONSTRUCT= _ONLY | - G_PARAM_PRIVATE | G_PARAM_STATIC_ST= RINGS)); } =20 --=20 2.23.0.rc2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 16:48:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1566222477; cv=none; d=zoho.com; s=zohoarc; b=DXbki9J1i9BGZSBNww20xDLlHGBwelBsz+QLChSJulQIYz66Ag71FtpI/WARrmaAhixa1y3sI4e5K334Tp7gHiPePagbL+jY1jIPqgciNSwxmxL2nESPvQdT/PN135FmocdAQPf/hu8htR3EJ3iq6x18k+F6DCb/sxxY5O4ey4o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566222477; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wGuRN+9nbEEAk0s69GRl1osxGMpnSHYo1hIiAVNajjE=; b=VyUvNDV50wuIX0hOPRYJxsTHmOwoIplHWJKl6c2SB2gCTGiIrxPhIE2+XVgzyIuotBsiSOn4koyqzbc6bjgqyMXdUEPuiJZb6h4mSry5+IstyXCEnu38mTfRJj2txVb82mQs3Ct9plFGuHAbV3SKJ5JRzMDAaxg/vMNNrXidEHM= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566222477157422.5739515390262; Mon, 19 Aug 2019 06:47:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB18169097; Mon, 19 Aug 2019 13:47:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9715F1FC; Mon, 19 Aug 2019 13:47:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 31AC124F35; Mon, 19 Aug 2019 13:47:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7JDldu4011538 for ; Mon, 19 Aug 2019 09:47:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id F0C68859BA; Mon, 19 Aug 2019 13:47:39 +0000 (UTC) Received: from localhost.localdomain (dhcp-94.gsslab.fab.redhat.com [10.33.9.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5678C80696; Mon, 19 Aug 2019 13:47:39 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Mon, 19 Aug 2019 14:47:34 +0100 Message-Id: <20190819134734.102779-3-berrange@redhat.com> In-Reply-To: <20190819134734.102779-1-berrange@redhat.com> References: <20190819134734.102779-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [glib PATCH 2/2] Set desired glib min/max API versions X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 19 Aug 2019 13:47:56 +0000 (UTC) Setting GLIB_VERSION_MAX_ALLOWED ensures we get warnings if we use APIs that are newer than our declared minimum glib version. Setting GLIB_VERSION_MIN_REQUIRED ensures that we get warnings if we use APIs deprecated in versions preceeding this. If the latter is omitted then we get warnings for all deprecations in glib, which is undesirable if we want to keep compat with older versions. This avoids a build error with latest glib ./../libvirt-gconfig/libvirt-gconfig-capabilities-cpu-model.c: In functio= n 'gvir_config_capabilities_cpu_model_init': ../../libvirt-gconfig/libvirt-gconfig-capabilities-cpu-model.c:44:13: err= or: G_ADD_PRIVATE [-Werror] 44 | model->priv =3D GVIR_CONFIG_CAPABILITIES_CPU_MODEL_GET_PRIVAT= E(model); | ^~~~~~~~~~~~~~~ Caused by G_TYPE_INSTANCE_GET_PRIVATE being deprecated. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- configure.ac | 2 ++ libvirt-gconfig/Makefile.am | 2 ++ libvirt-glib/Makefile.am | 2 ++ libvirt-gobject/Makefile.am | 2 ++ 4 files changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 6b66f5d..bf4d39c 100644 --- a/configure.ac +++ b/configure.ac @@ -13,6 +13,8 @@ LIBVIRT_REQUIRED=3D1.2.5 AC_SUBST([LIBVIRT_REQUIRED]) dnl used in the .spec file GLIB2_REQUIRED=3D2.38.0 AC_SUBST([GLIB2_REQUIRED]) dnl used in the .spec file +GLIB2_VERSION_SYMBOL=3D"GLIB_VERSION_2_38" +AC_SUBST([GLIB2_VERSION_SYMBOL]) dnl sets glib deprecations GOBJECT_INTROSPECTION_REQUIRED=3D1.36.0 LIBXML2_REQUIRED=3D2.0.0 =20 diff --git a/libvirt-gconfig/Makefile.am b/libvirt-gconfig/Makefile.am index 089b42a..daa4239 100644 --- a/libvirt-gconfig/Makefile.am +++ b/libvirt-gconfig/Makefile.am @@ -209,6 +209,8 @@ libvirt_gconfig_1_0_la_CFLAGS =3D \ -DG_LOG_DOMAIN=3D"\"Libvirt.GConfig\"" \ -DDATADIR=3D"\"$(datadir)\"" \ -DLIBVIRT_GCONFIG_BUILD \ + -DGLIB_VERSION_MIN_REQUIRED=3D$(GLIB2_VERSION_SYMBOL) \ + -DGLIB_VERSION_MAX_ALLOWED=3D$(GLIB2_VERSION_SYMBOL) \ $(COVERAGE_CFLAGS) \ -I$(top_srcdir) \ -I$(top_builddir) \ diff --git a/libvirt-glib/Makefile.am b/libvirt-glib/Makefile.am index fa52352..1cc145a 100644 --- a/libvirt-glib/Makefile.am +++ b/libvirt-glib/Makefile.am @@ -16,6 +16,8 @@ libvirt_glib_1_0_la_SOURCES =3D \ libvirt-glib-main.c libvirt_glib_1_0_la_CFLAGS =3D \ -DLIBVIRT_GLIB_BUILD \ + -DGLIB_VERSION_MIN_REQUIRED=3D$(GLIB2_VERSION_SYMBOL) \ + -DGLIB_VERSION_MAX_ALLOWED=3D$(GLIB2_VERSION_SYMBOL) \ -DGETTEXT_PACKAGE=3D"\"libvirt-glib\"" \ -DG_LOG_DOMAIN=3D"\"Libvirt.GLib\"" \ -DLOCALEDIR=3D"\"$(datadir)/locale\"" \ diff --git a/libvirt-gobject/Makefile.am b/libvirt-gobject/Makefile.am index 210c753..b03d8f5 100644 --- a/libvirt-gobject/Makefile.am +++ b/libvirt-gobject/Makefile.am @@ -70,6 +70,8 @@ libvirt_gobject_1_0_la_CFLAGS =3D \ -DG_LOG_DOMAIN=3D"\"Libvirt.GObject\"" \ -DDATADIR=3D"\"$(datadir)\"" \ -DLIBVIRT_GOBJECT_BUILD \ + -DGLIB_VERSION_MIN_REQUIRED=3D$(GLIB2_VERSION_SYMBOL) \ + -DGLIB_VERSION_MAX_ALLOWED=3D$(GLIB2_VERSION_SYMBOL) \ $(COVERAGE_CFLAGS) \ -I$(top_srcdir) \ -I$(top_builddir) \ --=20 2.23.0.rc2 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list