From nobody Sat Apr 27 01:50:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1565376815; cv=none; d=zoho.com; s=zohoarc; b=n9nptQRyMMkCwOG5/RpsN3ZPONs40dSwU1YY8nTIrO3knsUFC4FF9YfiSjrv0SOP+U9eah4URP2NFCZlSoRDeYXwnpcUZqMJ/xzmMlqRR7TlPipQS9KYYCil4hi1Op3J4IO/Z7iso0p2QN/l+F0l9yWxV/EYo+GP8w2lnWkpdO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565376815; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=zZmmPi7+V49qaRozEswArnoFkdkHYSxQuFEdJmAxm1Q=; b=h8Plb84BzH8mPp3uQvDNe+bdykW7xd98eTMCId5iqgCbLxMPHgWm0Zj5wi0EUZZ318j7wALerTzqSpQNcRA4ePZcIGPmkNfiCYmB2jzrBTab0+izKLglaHSqbcVlfzLdfW86zqR1zNHxF4z1YndXo80gELAqNbvN+13Cbu4KZPU= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156537681549661.56073346972619; Fri, 9 Aug 2019 11:53:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1D30514AFA7; Fri, 9 Aug 2019 18:53:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B26BA608A7; Fri, 9 Aug 2019 18:53:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 661E3180B536; Fri, 9 Aug 2019 18:53:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x79IrWYL021177 for ; Fri, 9 Aug 2019 14:53:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id ACCFF608C2; Fri, 9 Aug 2019 18:53:32 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E61C608A7; Fri, 9 Aug 2019 18:53:30 +0000 (UTC) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D2A0B970E2; Fri, 9 Aug 2019 18:53:28 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id u25so6456830wmc.4; Fri, 09 Aug 2019 11:53:28 -0700 (PDT) Received: from archlap.localdomain ([185.32.231.210]) by smtp.gmail.com with ESMTPSA id l8sm197804533wrg.40.2019.08.09.11.53.26 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 11:53:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kohEZjR2smAOTk+wcyPrkaT8Q3gG5ANjWxiBCzhO8u4=; b=tY6oRCQmYRi5mK8+bJS1A7breWtKaua7VrAi0cZDb0nvIt1d4BhZMUjyYU1OR79Xti ozIx+y5lpsF+RCzJ2XPiHNLBNFXVRyo5m+kfTGQc3IHpbQOdXxVQsZ6gTg2ovcIcwWM5 Lh4nA7bqlyQY/lohhWzO6my4xruRufS6koDsKuRzD7PW1K85LdspE/qF3VbqjVnxamGB yNRApSLjjFI8C8oEhx/yKMwUKcgB9QZb2mb2e79236epnNEADgwdhzW4Q4mLVGRhY5qU C7wDYe9dil8TVZMYB1l45ys06n/yIVKtmFzQaBw62FodNLk5IylDKtc7tR7SiA1/h0OA bNAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kohEZjR2smAOTk+wcyPrkaT8Q3gG5ANjWxiBCzhO8u4=; b=n0nCb8CZoGyPrXx6TeAykIhI4wIlZofGihxTWMA0ITTVFvk4WNU6Cedqv+ukm2B6TE rVbIUQurD5bcTZvzBRP3oX06xq2M6mhtp0jtavY1+Xipqy3M6pOXVX0Gn0ZjaoBEz7yy niwqqgJncpa0kqYODPuuXBWTRncrBiYZm9GLTXNGeXZ97v/iH1l3IvScOnJMs+pWeSYu 8AI1XcOv/yMCNvZfP5swFmwg0YnyffhCwgUbXLkLpJRfNB6H5lzeO/7dAfsf2hYH9Wqi f6F46i9rNKvFnJwGBSTbao3suyeM9EOPOz9aWzs5DZLXjz1dd+qIK5udxxiziOfI8Mpt 9tDw== X-Gm-Message-State: APjAAAWoKrn1/fhFzBEa3/zY/1fg/1CLSe/dUb+GHMLgRF5D3Rpu/OSB 9pzT78pIf/xc1iJjDBlAWpSst+Z54ZQ= X-Google-Smtp-Source: APXvYqwl7/MdIYdW1/EACDweT+xYxb9Ajh0gI7IwUMJFBLQITB2MbNQOL746+ODleQDpEXOgUaqOuA== X-Received: by 2002:a1c:dd82:: with SMTP id u124mr804872wmg.89.1565376807219; Fri, 09 Aug 2019 11:53:27 -0700 (PDT) From: Ilias Stamatis To: libvir-list@redhat.com Date: Fri, 9 Aug 2019 21:52:59 +0300 Message-Id: <20190809185300.10479-2-stamatis.iliass@gmail.com> In-Reply-To: <20190809185300.10479-1-stamatis.iliass@gmail.com> References: <20190809185300.10479-1-stamatis.iliass@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 09 Aug 2019 18:53:29 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 09 Aug 2019 18:53:29 +0000 (UTC) for IP:'209.85.128.65' DOMAIN:'mail-wm1-f65.google.com' HELO:'mail-wm1-f65.google.com' FROM:'stamatis.iliass@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.099 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS) 209.85.128.65 mail-wm1-f65.google.com 209.85.128.65 mail-wm1-f65.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Erik Skultety Subject: [libvirt] [PATCH v2 1/2] test_driver: implement testDomainGetBlockIoTune X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 09 Aug 2019 18:53:34 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 102 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2b5376ec28..14b7d683e1 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3611,6 +3611,107 @@ testDomainGetInterfaceParameters(virDomainPtr dom, virDomainObjEndAPI(&vm); return ret; } + + +static int +testDomainGetBlockIoTune(virDomainPtr dom, + const char *path, + virTypedParameterPtr params, + int *nparams, + unsigned int flags) +{ + virDomainObjPtr vm =3D NULL; + virDomainDefPtr def =3D NULL; + virDomainDiskDefPtr disk; + virDomainBlockIoTuneInfo reply =3D {0}; + int ret =3D -1; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | + VIR_DOMAIN_AFFECT_CONFIG | + VIR_TYPED_PARAM_STRING_OKAY, -1); + + flags &=3D ~VIR_TYPED_PARAM_STRING_OKAY; + + if (*nparams =3D=3D 0) { + *nparams =3D 20; + return 0; + } + + if (!(vm =3D testDomObjFromDomain(dom))) + return -1; + + if (!(def =3D virDomainObjGetOneDef(vm, flags))) + goto cleanup; + + if (!(disk =3D virDomainDiskByName(def, path, true))) { + virReportError(VIR_ERR_INVALID_ARG, + _("disk '%s' was not found in the domain config"), + path); + goto cleanup; + } + + reply =3D disk->blkdeviotune; + if (VIR_STRDUP(reply.group_name, disk->blkdeviotune.group_name) < 0) + goto cleanup; + + TEST_SET_PARAM(0, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC, + VIR_TYPED_PARAM_ULLONG, reply.total_bytes_sec); + TEST_SET_PARAM(1, VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC, + VIR_TYPED_PARAM_ULLONG, reply.read_bytes_sec); + TEST_SET_PARAM(2, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC, + VIR_TYPED_PARAM_ULLONG, reply.write_bytes_sec); + + TEST_SET_PARAM(3, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, reply.total_iops_sec); + TEST_SET_PARAM(4, VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, reply.read_iops_sec); + TEST_SET_PARAM(5, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, reply.write_iops_sec); + + TEST_SET_PARAM(6, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, reply.total_bytes_sec_max); + TEST_SET_PARAM(7, VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, reply.read_bytes_sec_max); + TEST_SET_PARAM(8, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, reply.write_bytes_sec_max); + + TEST_SET_PARAM(9, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, reply.total_iops_sec_max); + TEST_SET_PARAM(10, VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, reply.read_iops_sec_max); + TEST_SET_PARAM(11, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, reply.write_iops_sec_max); + + TEST_SET_PARAM(12, VIR_DOMAIN_BLOCK_IOTUNE_SIZE_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, reply.size_iops_sec); + + TEST_SET_PARAM(13, VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME, + VIR_TYPED_PARAM_STRING, reply.group_name); + reply.group_name =3D NULL; + + TEST_SET_PARAM(14, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGTH, + VIR_TYPED_PARAM_ULLONG, reply.total_bytes_sec_max_lengt= h); + TEST_SET_PARAM(15, VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH, + VIR_TYPED_PARAM_ULLONG, reply.read_bytes_sec_max_length= ); + TEST_SET_PARAM(16, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGTH, + VIR_TYPED_PARAM_ULLONG, reply.write_bytes_sec_max_lengt= h); + + TEST_SET_PARAM(17, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH, + VIR_TYPED_PARAM_ULLONG, reply.total_iops_sec_max_length= ); + TEST_SET_PARAM(18, VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH, + VIR_TYPED_PARAM_ULLONG, reply.read_iops_sec_max_length); + TEST_SET_PARAM(19, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH, + VIR_TYPED_PARAM_ULLONG, reply.write_iops_sec_max_length= ); + + if (*nparams > 20) + *nparams =3D 20; + + ret =3D 0; + cleanup: + VIR_FREE(reply.group_name); + virDomainObjEndAPI(&vm); + return ret; +} #undef TEST_SET_PARAM @@ -9019,6 +9120,7 @@ static virHypervisorDriver testHypervisorDriver =3D { .domainGetNumaParameters =3D testDomainGetNumaParameters, /* 5.6.0 */ .domainSetInterfaceParameters =3D testDomainSetInterfaceParameters, /*= 5.6.0 */ .domainGetInterfaceParameters =3D testDomainGetInterfaceParameters, /*= 5.6.0 */ + .domainGetBlockIoTune =3D testDomainGetBlockIoTune, /* 5.7.0 */ .connectListDefinedDomains =3D testConnectListDefinedDomains, /* 0.1.1= 1 */ .connectNumOfDefinedDomains =3D testConnectNumOfDefinedDomains, /* 0.1= .11 */ .domainCreate =3D testDomainCreate, /* 0.1.11 */ -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 01:50:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1565376826; cv=none; d=zoho.com; s=zohoarc; b=F2UEEFwm8HWhVWl+hFt6Yci+/Qg0fTC3MF/ZoBRvTxc0o8/NV/kiiaLNd+w+2dQBW+RefEuf+AAWjDGfOdazl0ZpabCFKIt9vM4YY1GD7DSRxL864+ZOIwFw0bsnLncTcHlDqRHZC3CaAxbVknaEqYvodCwK3d5HnYUAIE4ZsOQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565376826; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=gTnXDNhtSbOT8sMmf2ZnEAozX9ZD7Orrryxr6lj0Ye0=; b=VlxBB4UyrtdhRVNdF+21lC8AADNwtaOC2or7GFU333Dw4OULlzdR1WcKZBuMqg8OkP9EmwwkjvPXYjKM+DDrp26c+Hoy1JV7yuDKkJNMQ9+vZH+8a8T3kdLozNV7xDUXuCbSG/G2tFeFJYY2Uqm/gjVDj+eNNIGISkS6XuCszpM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1565376826301916.8567545409803; Fri, 9 Aug 2019 11:53:46 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 080F6C08E2BB; Fri, 9 Aug 2019 18:53:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D7E54608C2; Fri, 9 Aug 2019 18:53:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9B23E180B536; Fri, 9 Aug 2019 18:53:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x79IrhFu021195 for ; Fri, 9 Aug 2019 14:53:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 81AFA5D721; Fri, 9 Aug 2019 18:53:43 +0000 (UTC) Received: from mx1.redhat.com (ext-mx19.extmail.prod.ext.phx2.redhat.com [10.5.110.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BA5E5D6A0 for ; Fri, 9 Aug 2019 18:53:40 +0000 (UTC) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58DDC3022DB3 for ; Fri, 9 Aug 2019 18:53:39 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id 31so99171502wrm.1 for ; Fri, 09 Aug 2019 11:53:39 -0700 (PDT) Received: from archlap.localdomain ([185.32.231.210]) by smtp.gmail.com with ESMTPSA id l8sm197804533wrg.40.2019.08.09.11.53.36 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 09 Aug 2019 11:53:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=GJWhY5Nyh3CsyQlA5Y6HgOzTAA+K+T/Z7ysZ1LiyD/Q=; b=LpMRE7iIM40rZajX5Q4OijtuzY1/uSJzEsEQf98yPkrIVe98tstVsJnZqgz4aqgmV7 YcSMJB+7f4bSc4sttJqyLE3ndZNYH2vxmd60fsC1TK4a1zQqR7FgWhkz8AYIkwoKI2QY K9gWPCT3/9fqV/je5Fa99qK1C/qodcbhDw+01LWOEGuJNUpGxvWeFK5FeBwiT/NGIYaa u1hSu5xZOTM+CxM2tbfd6jt+sOYauCKY+l0Fl5z+WR36F8idxa31YcjEN7SMUd+fyDtx mh003lPsxsxcxil8J+1iJ+18DJOs71hUuAv+uRUjyACEcD4CG1BvCqOEwbRGt9V6Hj7H iLNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GJWhY5Nyh3CsyQlA5Y6HgOzTAA+K+T/Z7ysZ1LiyD/Q=; b=bc2jLmnwRqkrGRr/ZYdaz6raQDIji0NM62XS02Vj5YZM6Hf4IKNLJHoqW+W4ucnFfe sY1XIQMHeVJBAE+FF5yMN0g8+ixQIVjgrKnSl1O7fzaW08qaagaIRLikjEG6Xuwav9XP FrdDlA9YRSNdEx+Qe+tIWmz7gk2yH4QZOtQefFhl5ZNERl3QBkwmijPI7DJCT4F+leeU dBRSp5to0y6j+frNwXm9CLylTOm6nMYVoOq9e5aui/Ba20N6h9Y/k6+gFyq8pCtdccpL L/8LSzpWqXpIeDZmaTrY8jKsqxzBzq9J0YNMV4JuJX7+YkpxoUrtDmPrqse7B0mSUP4w eHXA== X-Gm-Message-State: APjAAAVhikuGksm7D1RRw+JWOX8J+p2tO79PvF1tyn6v7UIyRTx/y6Ft hURRIqcOaJIt102Zuc35lHFJHiEIvd0= X-Google-Smtp-Source: APXvYqyOHqj06Y49d8xpmZIh6x4T6v/kfhj6DK8YyTyFSNUsuc23rUq6BpmxTf/lsqsPnEgFyYbHXw== X-Received: by 2002:adf:93a4:: with SMTP id 33mr21780142wrp.187.1565376817697; Fri, 09 Aug 2019 11:53:37 -0700 (PDT) From: Ilias Stamatis To: libvir-list@redhat.com Date: Fri, 9 Aug 2019 21:53:00 +0300 Message-Id: <20190809185300.10479-3-stamatis.iliass@gmail.com> In-Reply-To: <20190809185300.10479-1-stamatis.iliass@gmail.com> References: <20190809185300.10479-1-stamatis.iliass@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 09 Aug 2019 18:53:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Fri, 09 Aug 2019 18:53:39 +0000 (UTC) for IP:'209.85.221.66' DOMAIN:'mail-wr1-f66.google.com' HELO:'mail-wr1-f66.google.com' FROM:'stamatis.iliass@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.1 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS) 209.85.221.66 mail-wr1-f66.google.com 209.85.221.66 mail-wr1-f66.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.48 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 2/2] test_driver: implement virDomainSetBlockIoTune X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 09 Aug 2019 18:53:45 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 259 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 259 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 14b7d683e1..009bc18a73 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -3613,6 +3613,264 @@ testDomainGetInterfaceParameters(virDomainPtr dom, } +#define TEST_BLOCK_IOTUNE_MAX 1000000000000000LL + +static int +testDomainSetBlockIoTune(virDomainPtr dom, + const char *path, + virTypedParameterPtr params, + int nparams, + unsigned int flags) +{ + virDomainObjPtr vm =3D NULL; + virDomainDefPtr def =3D NULL; + virDomainBlockIoTuneInfo info =3D {0}; + virDomainDiskDefPtr conf_disk =3D NULL; + virTypedParameterPtr eventParams =3D NULL; + int eventNparams =3D 0; + int eventMaxparams =3D 0; + size_t i; + int ret =3D -1; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | + VIR_DOMAIN_AFFECT_CONFIG, -1); + + if (virTypedParamsValidate(params, nparams, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_SIZE_IOPS_SEC, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME, + VIR_TYPED_PARAM_STRING, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX= _LENGTH, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX_= LENGTH, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX= _LENGTH, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_= LENGTH, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX_L= ENGTH, + VIR_TYPED_PARAM_ULLONG, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_= LENGTH, + VIR_TYPED_PARAM_ULLONG, + NULL) < 0) + return -1; + + if (!(vm =3D testDomObjFromDomain(dom))) + return -1; + + if (!(def =3D virDomainObjGetOneDef(vm, flags))) + goto cleanup; + + if (!(conf_disk =3D virDomainDiskByName(def, path, true))) { + virReportError(VIR_ERR_INVALID_ARG, + _("missing persistent configuration for disk '%s'"), + path); + goto cleanup; + } + + info =3D conf_disk->blkdeviotune; + if (VIR_STRDUP(info.group_name, conf_disk->blkdeviotune.group_name) < = 0) + goto cleanup; + + if (virTypedParamsAddString(&eventParams, &eventNparams, &eventMaxpara= ms, + VIR_DOMAIN_TUNABLE_BLKDEV_DISK, path) < 0) + goto cleanup; + +#define SET_IOTUNE_FIELD(FIELD, STR, TUNABLE_STR) \ + if (STREQ(param->field, STR)) { \ + info.FIELD =3D param->value.ul; \ + if (virTypedParamsAddULLong(&eventParams, &eventNparams, \ + &eventMaxparams, \ + TUNABLE_STR, \ + param->value.ul) < 0) \ + goto cleanup; \ + continue; \ + } + + for (i =3D 0; i < nparams; i++) { + virTypedParameterPtr param =3D ¶ms[i]; + + if (param->value.ul > TEST_BLOCK_IOTUNE_MAX) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, + _("block I/O throttle limit value must" + " be no more than %llu"), TEST_BLOCK_IOTUNE_M= AX); + goto cleanup; + } + + SET_IOTUNE_FIELD(total_bytes_sec, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BY= TES_SEC, + VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC); + SET_IOTUNE_FIELD(read_bytes_sec, VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTE= S_SEC, + VIR_DOMAIN_TUNABLE_BLKDEV_READ_BYTES_SEC); + SET_IOTUNE_FIELD(write_bytes_sec, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BY= TES_SEC, + VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_BYTES_SEC); + SET_IOTUNE_FIELD(total_iops_sec, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOP= S_SEC, + VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC); + SET_IOTUNE_FIELD(read_iops_sec, VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_= SEC, + VIR_DOMAIN_TUNABLE_BLKDEV_READ_IOPS_SEC); + SET_IOTUNE_FIELD(write_iops_sec, VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOP= S_SEC, + VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_IOPS_SEC); + + SET_IOTUNE_FIELD(total_bytes_sec_max, VIR_DOMAIN_BLOCK_IOTUNE_TOTA= L_BYTES_SEC_MAX, + VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX); + SET_IOTUNE_FIELD(read_bytes_sec_max, VIR_DOMAIN_BLOCK_IOTUNE_READ_= BYTES_SEC_MAX, + VIR_DOMAIN_TUNABLE_BLKDEV_READ_BYTES_SEC_MAX); + SET_IOTUNE_FIELD(write_bytes_sec_max, VIR_DOMAIN_BLOCK_IOTUNE_WRIT= E_BYTES_SEC_MAX, + VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX); + SET_IOTUNE_FIELD(total_iops_sec_max, VIR_DOMAIN_BLOCK_IOTUNE_TOTAL= _IOPS_SEC_MAX, + VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX); + SET_IOTUNE_FIELD(read_iops_sec_max, VIR_DOMAIN_BLOCK_IOTUNE_READ_I= OPS_SEC_MAX, + VIR_DOMAIN_TUNABLE_BLKDEV_READ_IOPS_SEC_MAX); + SET_IOTUNE_FIELD(write_iops_sec_max, VIR_DOMAIN_BLOCK_IOTUNE_WRITE= _IOPS_SEC_MAX, + VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX); + SET_IOTUNE_FIELD(size_iops_sec, VIR_DOMAIN_BLOCK_IOTUNE_SIZE_IOPS_= SEC, + VIR_DOMAIN_TUNABLE_BLKDEV_SIZE_IOPS_SEC); + + if (STREQ(param->field, VIR_DOMAIN_BLOCK_IOTUNE_GROUP_NAME)) { + VIR_FREE(info.group_name); + if (VIR_STRDUP(info.group_name, param->value.s) < 0) + goto cleanup; + if (virTypedParamsAddString(&eventParams, + &eventNparams, + &eventMaxparams, + VIR_DOMAIN_TUNABLE_BLKDEV_GROUP_NA= ME, + param->value.s) < 0) + goto cleanup; + continue; + } + + SET_IOTUNE_FIELD(total_bytes_sec_max_length, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_BYTES_SEC_MAX_LENGT= H, + VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_BYTES_SEC_MAX_LEN= GTH); + SET_IOTUNE_FIELD(read_bytes_sec_max_length, + VIR_DOMAIN_BLOCK_IOTUNE_READ_BYTES_SEC_MAX_LENGTH, + VIR_DOMAIN_TUNABLE_BLKDEV_READ_BYTES_SEC_MAX_LENG= TH); + SET_IOTUNE_FIELD(write_bytes_sec_max_length, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_BYTES_SEC_MAX_LENGT= H, + VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_BYTES_SEC_MAX_LEN= GTH); + SET_IOTUNE_FIELD(total_iops_sec_max_length, + VIR_DOMAIN_BLOCK_IOTUNE_TOTAL_IOPS_SEC_MAX_LENGTH, + VIR_DOMAIN_TUNABLE_BLKDEV_TOTAL_IOPS_SEC_MAX_LENG= TH); + SET_IOTUNE_FIELD(read_iops_sec_max_length, + VIR_DOMAIN_BLOCK_IOTUNE_READ_IOPS_SEC_MAX_LENGTH, + VIR_DOMAIN_TUNABLE_BLKDEV_READ_IOPS_SEC_MAX_LENGT= H); + SET_IOTUNE_FIELD(write_iops_sec_max_length, + VIR_DOMAIN_BLOCK_IOTUNE_WRITE_IOPS_SEC_MAX_LENGTH, + VIR_DOMAIN_TUNABLE_BLKDEV_WRITE_IOPS_SEC_MAX_LENG= TH); + } +#undef SET_IOTUNE_FIELD + + if ((info.total_bytes_sec && info.read_bytes_sec) || + (info.total_bytes_sec && info.write_bytes_sec)) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("total and read/write of bytes_sec " + "cannot be set at the same time")); + goto cleanup; + } + + if ((info.total_iops_sec && info.read_iops_sec) || + (info.total_iops_sec && info.write_iops_sec)) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("total and read/write of iops_sec " + "cannot be set at the same time")); + goto cleanup; + } + + if ((info.total_bytes_sec_max && info.read_bytes_sec_max) || + (info.total_bytes_sec_max && info.write_bytes_sec_max)) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("total and read/write of bytes_sec_max " + "cannot be set at the same time")); + goto cleanup; + } + + if ((info.total_iops_sec_max && info.read_iops_sec_max) || + (info.total_iops_sec_max && info.write_iops_sec_max)) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("total and read/write of iops_sec_max " + "cannot be set at the same time")); + goto cleanup; + } + + if (info.total_bytes_sec > info.total_bytes_sec_max) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("total_bytes_sec " + "cannot be set higher than its corresponding max = value")); + goto cleanup; + } + + if (info.read_bytes_sec > info.read_bytes_sec_max) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("read_bytes_sec " + "cannot be set higher than its corresponding max = value")); + goto cleanup; + } + + if (info.write_bytes_sec > info.write_bytes_sec_max) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("write_bytes_sec " + "cannot be set higher than its corresponding max = value")); + goto cleanup; + } + + if (info.total_iops_sec > info.total_iops_sec_max) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("total_iops_sec " + "cannot be set higher than its corresponding max = value")); + goto cleanup; + } + + if (info.read_iops_sec > info.read_iops_sec_max) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("read_iops_sec " + "cannot be set higher than its corresponding max = value")); + goto cleanup; + } + + if (info.write_iops_sec > info.write_iops_sec_max) { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("write_iops_sec " + "cannot be set higher than its corresponding max = value")); + goto cleanup; + } + + if (virDomainDiskSetBlockIOTune(conf_disk, &info) < 0) + goto cleanup; + info.group_name =3D NULL; + + ret =3D 0; + cleanup: + VIR_FREE(info.group_name); + virDomainObjEndAPI(&vm); + if (eventNparams) + virTypedParamsFree(eventParams, eventNparams); + return ret; +} + + static int testDomainGetBlockIoTune(virDomainPtr dom, const char *path, @@ -9120,6 +9378,7 @@ static virHypervisorDriver testHypervisorDriver =3D { .domainGetNumaParameters =3D testDomainGetNumaParameters, /* 5.6.0 */ .domainSetInterfaceParameters =3D testDomainSetInterfaceParameters, /*= 5.6.0 */ .domainGetInterfaceParameters =3D testDomainGetInterfaceParameters, /*= 5.6.0 */ + .domainSetBlockIoTune =3D testDomainSetBlockIoTune, /* 5.7.0 */ .domainGetBlockIoTune =3D testDomainGetBlockIoTune, /* 5.7.0 */ .connectListDefinedDomains =3D testConnectListDefinedDomains, /* 0.1.1= 1 */ .connectNumOfDefinedDomains =3D testConnectNumOfDefinedDomains, /* 0.1= .11 */ -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list