From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481644; cv=none; d=zoho.com; s=zohoarc; b=KYU7txSdSYckeS6HYLpFSCcJ+XJQEBSd/RGxtud6mMIKhIDQspVs+IvplvXWDEdkAO717R9JeVgwpED4nwVLQBrH1c/6VxGhKAwjqBIkix1+bTynxhGfXyghAD0dQ0M7WsOI1YF2v+Mulq2fJA8afQ7Q3Iafqn1PDIxxMCdc4DI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481644; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=L8G0RHZR1P1AhmXXi6M4N6jI9AW3KLSWQrX39GqlShU=; b=CJK3O3800OGd/1kuES9toIacXCJ5OoG49kg1WE+HpoNjI0qfeahfDLNmG8hZ5eQCPpcNmH9Fwwd41Mf/PhU0uyLDlQYukVHapNFfUl2azEObYQB6/881l9Hx9lXF2WfJmpJriPeDwOZIIJmakCyk3b0FstYHNWr5hJ0WcU9+Q+4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564481644918199.54930497689475; Tue, 30 Jul 2019 03:14:04 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C2286308FBAF; Tue, 30 Jul 2019 10:14:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 854E55D978; Tue, 30 Jul 2019 10:14:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1DEDE18005A0; Tue, 30 Jul 2019 10:14:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UADvP1002098 for ; Tue, 30 Jul 2019 06:13:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id F110719C70; Tue, 30 Jul 2019 10:13:56 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB9D319C6A for ; Tue, 30 Jul 2019 10:13:54 +0000 (UTC) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 785AD80F98 for ; Tue, 30 Jul 2019 10:13:54 +0000 (UTC) Received: by mail-wm1-f69.google.com with SMTP id n13so12104981wmi.4 for ; Tue, 30 Jul 2019 03:13:54 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.13.51 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:13:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kqBcOokiI9q5TEccR9nGCYbraiODPugixCLk0x7ol5g=; b=qhHeEDPC5zDx0NlcTGPl5ZRodp1ESbkQtNv1iTgK0EdnugmLIzabQR7HRYQ+UpGm88 9eHugKc8u3jKg9xfAIXnBm/0lxVUJFKCXUUrx42AdtdWnjsPA4ud/3QAKfD753cu/VfJ KY+e4ofNlgvluvEzsN2tlz7hRXot6xeWmQW6tvEloHQfQYOc9IsC4lc2C4UXTt+k6kKp TVYOSuNUF11wLFsN9M1Qmt1KDqbioY5keAkVMoaCMq90BOJyHgNm1IiV6IYIrslHinfQ GO5StKl2XFesuK9N/wj2jHCPVbmv1L8AjsgriHdSfG2d9gvpZBHTBazHdeILutL1kFSo xWOw== X-Gm-Message-State: APjAAAXfeCM1guTzlbwhAI+saRbzRhso2YnIV57MQ26DfW1nUyipiGnv PBKerDNxOeGxDtpd14+9gFa97LjkVudUO1G0bBEOI6aGRCMLx7UAnnxsZ4jKzgILjSd0+raPJRA p2cI7Fz2Ixr+juMQSjH4= X-Received: by 2002:adf:f60a:: with SMTP id t10mr90252562wrp.258.1564481633005; Tue, 30 Jul 2019 03:13:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqHB6/2HLuZj0X8SjBV87qUA8+8HICpohCkgLxm0DKJUFXITy9BZSZtxdTMlh1sTWw1f5Xuw== X-Received: by 2002:adf:f60a:: with SMTP id t10mr90252538wrp.258.1564481632797; Tue, 30 Jul 2019 03:13:52 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:41 +0200 Message-Id: <20190730101348.4055-2-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 1/8] docs: formatdomain: add stimer flag to the example xml X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 30 Jul 2019 10:14:03 +0000 (UTC) The example XML we have contains all other Hyper-V Enlightenments but 'stimer' is missing. Signed-off-by: Vitaly Kuznetsov Reviewed-by: J=C3=A1n Tomko --- docs/formatdomain.html.in | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 1938bd875c..0894d9cbfb 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2033,6 +2033,7 @@ <vpindex state=3D'on'/> <runtime state=3D'on'/> <synic state=3D'on'/> + <stimer state=3D'on'/> <reset state=3D'on'/> <vendor_id state=3D'on' value=3D'KVM Hv'/> <frequencies state=3D'on'/> --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481643; cv=none; d=zoho.com; s=zohoarc; b=Yjv6YMmfCAjrkPz4qMWPNaBzfZnsPD0vbrT+rl959sepak7IBGFhdanxDXPNyoSpFdvCOripjtAI8q7RCCEtGg7M3+2DJG/yO+8vBrSJJoH99ypSlLXOdNzMlmhRM1j7Flau2QcLljYGOJEgBzkWTGw7uwr5OSuCKpGVDez2kYk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481643; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=opaLT39azIKF3vo1VmsRkQru1oyzPmyJnNvsh9TTwp8=; b=OTrbduOS33RySTJM31VhwrmSwMQzVctq+iVEcodGOq7e2r5CkLfqZaOmKC5Tet4hgnsDHix6mOX2Bfavh5dY1lY81HujSVoBMFeasSCtb30H65HzntCKDm5QQMu780BSsO/9lfOb04cxN0ME9X1imnzoBAd5EP6Q3BjHgAq68Y8= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564481643193776.7098082861764; Tue, 30 Jul 2019 03:14:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B94F63082E24; Tue, 30 Jul 2019 10:14:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 854F019C67; Tue, 30 Jul 2019 10:14:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 416F01800203; Tue, 30 Jul 2019 10:14:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UADweT002110 for ; Tue, 30 Jul 2019 06:13:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 74C7560BF7; Tue, 30 Jul 2019 10:13:58 +0000 (UTC) Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6EDE560BFC for ; Tue, 30 Jul 2019 10:13:56 +0000 (UTC) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8F3DC04D293 for ; Tue, 30 Jul 2019 10:13:55 +0000 (UTC) Received: by mail-wm1-f72.google.com with SMTP id y127so14556398wmd.0 for ; Tue, 30 Jul 2019 03:13:55 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.13.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:13:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bOhog5woiyAsj9l3Rm9GAE4HZFcwehlSYp+BB7VRaFg=; b=iESyOjeqIks7i94FAbz0fOVcdMllEwomYCwjiJ4Z6PnxjG4/G9Pikfozk+iDbUNuAB y7s0dVd86ggL5tUWBuxYzZv/dAcv7kOvbgqu+Xh0NMs1g21zxNYwKbHXOPe5jqXVeh6V bcXJpR5h3P3hv6st3KhV6Hk/JjSu5dxFigDLVZwHDKIcNv+scn3kC7MVmwbqj9uKPqy+ prOP6zHpAmRxa/rdam5jgjupqq12zaf8eZO3+wSb61R3TyCCXc6T6dqKbQmS5XSoc8Fy 4HcCti+HPxM1AQQnvIh43khut7x8mBYmduJragAFtdumBOHltLtL3dz2hCgPyGcBee7V O7qg== X-Gm-Message-State: APjAAAX3MI2nVR+0S8VZk+H4NOo7iic+mc0i3s8m7R6jSBgixfMHAyOJ CgOir43Xl4OrXILbFX5zyFo1ly3j/ozyClgyGM49JtyRy75ptAESLKg8BIFMIY6CdpGUjhXxcLB GpSWXo6CtMG7fMnC85wY= X-Received: by 2002:a5d:4950:: with SMTP id r16mr24103685wrs.136.1564481634257; Tue, 30 Jul 2019 03:13:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqxoozpm1DWESDAD4YX37W4ytneM5JEXynuAayCVo5OVV7zKwEXJvAdvzkoavDkjkRZOQluFOg== X-Received: by 2002:a5d:4950:: with SMTP id r16mr24103669wrs.136.1564481634066; Tue, 30 Jul 2019 03:13:54 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:42 +0200 Message-Id: <20190730101348.4055-3-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 2/8] docs: formatdomain: fix 'SynIC' spelling X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 30 Jul 2019 10:14:02 +0000 (UTC) SynIC stands for 'Synthetic Interrupt Controller', it is not a NIC. Fix the spelling in accordance with Hypervisor Top Level Functional Specification. Signed-off-by: Vitaly Kuznetsov Reviewed-by: J=C3=A1n Tomko --- docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0894d9cbfb..44b1ae7597 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2142,13 +2142,13 @@ synic - Enable Synthetic Interrupt Controller (SyNIC) + Enable Synthetic Interrupt Controller (SynIC) on, off 1.3.3 (QEMU 2.6) stimer - Enable SyNIC timers + Enable SynIC timers on, off 1.3.3 (QEMU 2.6) --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481647; cv=none; d=zoho.com; s=zohoarc; b=i6m7+tDzHp+40MrkISdaF8tsbJQ+yU2SyVjOj2Kv/9kPlXcbrQScuD1Zboc6n8Bvbg+y9rjZTc+T037JHwtltn2lYOVkTjOZjBKDn7qmGS282VTlyheGLDVHxki4JLuJOUAOC4f6Z2pFEGJVwdb8ZkVHBlX4gNqNgRLsp0QnCw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481647; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=4bGambXPsVka7y30GtLH0bPZL/kfFv5wIqFRzA44GwI=; b=UmAOX6XEBtr3SXr8QdAr/6v40WhmtddGpc34MUm/Ts2Jc6XXdByz8dsj0t3edyYWw+evSV201VD2NOJ9eXIELGsdN22jMJoaSnFZ3jqrxabeuSMajezqO91caK8WiDyELOt8OrJQ2a90SF3M7rmbofGpSTfog1zoNTs0dkav1cA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156448164793139.66969828201093; Tue, 30 Jul 2019 03:14:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB94B30024DB; Tue, 30 Jul 2019 10:14:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8451160BFC; Tue, 30 Jul 2019 10:14:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 444953FA9A; Tue, 30 Jul 2019 10:14:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UAE0pg002128 for ; Tue, 30 Jul 2019 06:14:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0E03660925; Tue, 30 Jul 2019 10:14:00 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0447C60A98 for ; Tue, 30 Jul 2019 10:13:57 +0000 (UTC) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7AE337FDE9 for ; Tue, 30 Jul 2019 10:13:57 +0000 (UTC) Received: by mail-wr1-f69.google.com with SMTP id e6so31478617wrv.20 for ; Tue, 30 Jul 2019 03:13:57 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.13.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:13:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QsxyIG8g19Kq8fEGYZP9nrOb0C71zlaBQWMGwZl/mrM=; b=t7M44qjn7dDPClYjC15ed6OD42qfrtGRtN+gvp9hxXai2q+8W/lF7gvBgp3/KrJe87 Rb6uc9uzaZs3hflt1oEbxi6jN3cO9HYBAXJ5E1GAWrZDD3YVkW5pbldjq/lp+3yQ1qS0 DLaTQ36RQ0vCAmIEqeuggQOEnZBvVp+9FtdLidKeAy8oPXVu87dNNFR/00ezceNTSQlB zRljxoSA8vUfJ7rFcVI3eXZcpbH+MS103LvOczk5xm1cZbSiss8t6pVMcztCaCBP77RO S0lSn0KUHm7usnhIQHBKKG6YAlcw8r8TLYO3+8Pmg5/yV+oYe12zG+LXYP9cJNyQAIkN jiew== X-Gm-Message-State: APjAAAX1YHomE2qsq2kcaiglRLjbucijMABXlKtoeO9CiPbk/RLjZalc hs681PZBlSUpd5kJ4ffNZHEhbrtvXLhKMPH9dK53xxn7rhO0qo5vxeaPCAzhrFPnyvEAwFBiyf8 25LGj3LrawgrGhHUdeKk= X-Received: by 2002:adf:f046:: with SMTP id t6mr10015879wro.307.1564481635832; Tue, 30 Jul 2019 03:13:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqx29RqQosvg3BTUhh62pbPPSCo6QeLcG0j97b7xayrcTVhkHDX+Ih342URurOwdDomR+WixuQ== X-Received: by 2002:adf:f046:: with SMTP id t6mr10015857wro.307.1564481635617; Tue, 30 Jul 2019 03:13:55 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:43 +0200 Message-Id: <20190730101348.4055-4-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 3/8] docs: formatdomain: move 'msrs' out of Hyper-V Enlightenments X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 30 Jul 2019 10:14:07 +0000 (UTC) Introduced by: commit e9528f41c612fff334e958d5e5df197aa8e83792 'msrs' is a feature unrelated to Hyper-V Enlightenments, the commit message which added it and the test have it right: ... ... Signed-off-by: Vitaly Kuznetsov Reviewed-by: J=C3=A1n Tomko --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 44b1ae7597..f5c882141a 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2041,7 +2041,6 @@ <tlbflush state=3D'on'/> <ipi state=3D'on'/> <evmcs state=3D'on'/> - <msrs unknown=3D'ignore'/> </hyperv> <kvm> <hidden state=3D'on'/> @@ -2057,6 +2056,7 @@ <tseg unit=3D'MiB'>48</tseg> </smm> <htm state=3D'on'/> + <msrs unknown=3D'ignore'/> </features> ... =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481644; cv=none; d=zoho.com; s=zohoarc; b=T+6jFbtGEcgGiT4P2qQHiP822s0+w2nhu1rchTito/KDq7KcPsS0I9faJtx4ViJn6nq7T1BkkxrDMpKgUWEv5rCv4DdT2j0IThuPqgNt6tWVderprAGXkCXwKD2IdzkrD08O9JEMM7cE8wrw6pzx8QhHqvFfeCTzz/YHgE9TSyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481644; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=je+QvyFK3sUaxX0F1YL6WjXnS/B1g9sj3PUILnyU/hI=; b=Ll2sP+YD8RbqqIhmVoKv6y4iFLu7C/k2QOEyq4inHsrfgo4Gyy7N4FqYs2o/rOiGHU8HwJuMtmrEU8naC1LvG1oCx1A6WyCQWdwLI30CQtIEG9UqpJRXsIO1mIBbIk9AN1mQgSv6aF0QOFICs1CkDZPBt5/dMG1V0b/66+3Gf0c= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564481644903188.23372212116192; Tue, 30 Jul 2019 03:14:04 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B820B88317; Tue, 30 Jul 2019 10:14:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78D2F10016F3; Tue, 30 Jul 2019 10:14:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 176DB1800239; Tue, 30 Jul 2019 10:14:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UADxLP002120 for ; Tue, 30 Jul 2019 06:13:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id F015319C6A; Tue, 30 Jul 2019 10:13:58 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7F3919C67 for ; Tue, 30 Jul 2019 10:13:58 +0000 (UTC) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 95D867FDF5 for ; Tue, 30 Jul 2019 10:13:58 +0000 (UTC) Received: by mail-wr1-f71.google.com with SMTP id j10so28593630wre.18 for ; Tue, 30 Jul 2019 03:13:58 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.13.55 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xKcZuwTyYWJi9QHqLlaE7LmumWjRuJhxI2OnZIbQLOM=; b=YKuaaKsxCUI08RU7cYusg4VY04zIJO6MC3XZYMxtW3rTd88QyWFm7OW73HFr9Zjabb qREYOdwm22vXwAqX8q3U1DNluY0nASy2HUTPe4Jp1fZnExGZ2DtZBPiCmiG/Dq0g61CF rW0HzCQ0KwQv0c1VPr6Tb4OO3tKCA4TfmfeEXjxbSMw+1QYx9Q5fN5n2t9UWPbjD+qAH 4qs8Qy2z+Re7bQYIzHHwdJa4rfgx7C6nDNjKUPRnubHzVkn39NaAMV8MhhraZV3tHg3g l3uKQGyicg9RvsAEkfs9cRoqAj02owl2sJycQJyW+QQe9eAIPhI3Sdoikz+L+WzuJ1FK uLrQ== X-Gm-Message-State: APjAAAVfvzOg7atwVcF6J15Q25Q6AFlW973npOmfKSezXKglQ8wVLtKK KwFbYm28ajSOlPPxdxQS2rpheX5bo9BIeGCMtqEkhB91o4e6nVTflsbET+gu+NPkvFvvLTrGttz XEp2y9+VGpTwomUlltD8= X-Received: by 2002:a05:6000:100f:: with SMTP id a15mr5269671wrx.325.1564481637014; Tue, 30 Jul 2019 03:13:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqzL9bX+to3MTXTNQep161qmcutb+HWRaHADxSpVJ1EGNdiBvElgtWh64wsH/+kqjlS20hU3Sw== X-Received: by 2002:a05:6000:100f:: with SMTP id a15mr5269643wrx.325.1564481636789; Tue, 30 Jul 2019 03:13:56 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:44 +0200 Message-Id: <20190730101348.4055-5-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 4/8] cpu_x86: add Edx to KVM_FEATURE_DEF() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 30 Jul 2019 10:14:04 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Some Hyper-V features (like the upcoming Direct Synthetic timers) are announced by feature bits in Edx but KVM_FEATURE_DEF() supports only Eax. Signed-off-by: Vitaly Kuznetsov --- src/cpu/cpu_x86.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 387c365512..8575915597 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -59,9 +59,9 @@ struct _virCPUx86Feature { { .type =3D VIR_CPU_X86_DATA_CPUID, \ .data =3D { .cpuid =3D {__VA_ARGS__} } } =20 -#define KVM_FEATURE_DEF(Name, Eax_in, Eax) \ +#define KVM_FEATURE_DEF(Name, Eax_in, Eax, Edx) \ static virCPUx86DataItem Name ## _data[] =3D { \ - CPUID(.eax_in =3D Eax_in, .eax =3D Eax), \ + CPUID(.eax_in =3D Eax_in, .eax =3D Eax, .edx =3D Edx), \ } =20 #define KVM_FEATURE(Name) \ @@ -74,34 +74,34 @@ struct _virCPUx86Feature { } =20 KVM_FEATURE_DEF(VIR_CPU_x86_KVM_PV_UNHALT, - 0x40000001, 0x00000080); + 0x40000001, 0x00000080, 0x0); =20 KVM_FEATURE_DEF(VIR_CPU_x86_HV_RUNTIME, - 0x40000003, 0x00000001); + 0x40000003, 0x00000001, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_SYNIC, - 0x40000003, 0x00000004); + 0x40000003, 0x00000004, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_STIMER, - 0x40000003, 0x00000008); + 0x40000003, 0x00000008, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_RELAXED, - 0x40000003, 0x00000020); + 0x40000003, 0x00000020, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_SPINLOCKS, - 0x40000003, 0x00000022); + 0x40000003, 0x00000022, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_VAPIC, - 0x40000003, 0x00000030); + 0x40000003, 0x00000030, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_VPINDEX, - 0x40000003, 0x00000040); + 0x40000003, 0x00000040, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_RESET, - 0x40000003, 0x00000080); + 0x40000003, 0x00000080, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_FREQUENCIES, - 0x40000003, 0x00000800); + 0x40000003, 0x00000800, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_REENLIGHTENMENT, - 0x40000003, 0x00002000); + 0x40000003, 0x00002000, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_TLBFLUSH, - 0x40000004, 0x00000004); + 0x40000004, 0x00000004, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_IPI, - 0x40000004, 0x00000400); + 0x40000004, 0x00000400, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_EVMCS, - 0x40000004, 0x00004000); + 0x40000004, 0x00004000, 0x0); =20 static virCPUx86Feature x86_kvm_features[] =3D { --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481648; cv=none; d=zoho.com; s=zohoarc; b=YtQioVoo3Bv5BdEN64BFjgNIQiM2RZrwDSNGjoUyYtQR2OlgXIDzHyqM7m30UhR+EOPMEBCEoZUagnej25GDgOdKNIYtzfpLzJ9QFi/jW+yu96+MUJ2jN9Y2KPOBaDW+lqfsbaXVN3xjEfiKfqoqAu3zZSHWnHGrjg32mga98Tk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481648; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=57mSGH85jAJrBALzXGtBKXXFGqcYdh7trmp/Y10AVCk=; b=L7VpKXDPSbOrwHig6p1YmoqbPV126ozT9YSOfoKh7dQ+qiW5DgAJXKxa0vaUdQqT2bb/RfR28B311vKaLBibO1Hja5afhxUDj/bYMz7hxBnfIVp0fF0XADUIq6jlialCbCVFgqweePKp1GqQA2RkVCVrzA4mTPgyiu+NbRa5nq0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156448164852436.218007689586784; Tue, 30 Jul 2019 03:14:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9F86430BD1C4; Tue, 30 Jul 2019 10:14:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A1EA5D6C8; Tue, 30 Jul 2019 10:14:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 383463CBB; Tue, 30 Jul 2019 10:14:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UAE0Q8002133 for ; Tue, 30 Jul 2019 06:14:00 -0400 Received: by smtp.corp.redhat.com (Postfix) id 446CE5C205; Tue, 30 Jul 2019 10:14:00 +0000 (UTC) Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FED75C1B4 for ; Tue, 30 Jul 2019 10:14:00 +0000 (UTC) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 117F885550 for ; Tue, 30 Jul 2019 10:14:00 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id l24so31625312wrb.0 for ; Tue, 30 Jul 2019 03:14:00 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.13.57 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:13:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1ht49gbAUDR5YasG7a4ChubpsbcV0QQby03Ixarun90=; b=n0TC4kHg0l+5jzez2abguC4vcG0GCWzZGxDlZWnZ0QWmDFx/zzbFaaTzLevcUUaO1x DKjXop5odPW86shhqrnCRWcig92mfXefxr7dIWMBE2LAVluRl9w3kT5/HmLIau4gos5Z 5opUQlP+AFmtExuBp+Kn9k/5azfPvmwl5eQw7lrftNsPq9qfGGUde8xO2AcfVe+UIGwm +WvfwLxcfL5hFrubNjJ2O3Xe68mimMnVRN3rlsFz8sg8ye6gIzm56PKZY9h0SsCuJ8hq wdLvCVyM0f6Msc0KiwsRrKWyNA4mZ/lxDA9qCxhbaoDavEn8WxIZijtSbNN9+mnsYD9D IyHg== X-Gm-Message-State: APjAAAXykFcQuBP5nJgWedqCNuwezuJFZrjM1PvywGPfKCpnHXrMPBcF pmdNYtw0WUIXE9Ak/o3tKElgSrevk5+pAQFvhqFT/P+mussHhVOakhtFDS9GoyMPO/EnTxNk1uc lqyL/YuZ4bJleUmo2EpE= X-Received: by 2002:adf:cf0d:: with SMTP id o13mr81968467wrj.291.1564481638596; Tue, 30 Jul 2019 03:13:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqwx4VhoUXIbcy07tTG6IE+6jIWvOVTQ6FExeIpaxiDyenVezIkgN9N01CVKAjPETSYdY1Kyow== X-Received: by 2002:adf:cf0d:: with SMTP id o13mr81968446wrj.291.1564481638372; Tue, 30 Jul 2019 03:13:58 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:45 +0200 Message-Id: <20190730101348.4055-6-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 5/8] conf: change the way how Hyper-V features are printed out X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 30 Jul 2019 10:14:07 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Current code doesn't allow us to add sub-features as we always print the closing '/>'. As a preparatory change to implementing 'direct' sub-feature for 'stimer' feature switch to printing closing tag individually. No functional change. Signed-off-by: Vitaly Kuznetsov --- src/conf/domain_conf.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 441eb1a5a2..0871f21494 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -28073,19 +28073,24 @@ virDomainDefFormatFeatures(virBufferPtr buf, case VIR_DOMAIN_HYPERV_TLBFLUSH: case VIR_DOMAIN_HYPERV_IPI: case VIR_DOMAIN_HYPERV_EVMCS: + virBufferAddLit(&childBuf, "/>\n"); break; =20 case VIR_DOMAIN_HYPERV_SPINLOCKS: - if (def->hyperv_features[j] !=3D VIR_TRISTATE_SWITCH_O= N) + if (def->hyperv_features[j] !=3D VIR_TRISTATE_SWITCH_O= N) { + virBufferAddLit(&childBuf, "/>\n"); break; - virBufferAsprintf(&childBuf, " retries=3D'%d'", + } + virBufferAsprintf(&childBuf, " retries=3D'%d'/>\n", def->hyperv_spinlocks); break; =20 case VIR_DOMAIN_HYPERV_VENDOR_ID: - if (def->hyperv_features[j] !=3D VIR_TRISTATE_SWITCH_O= N) + if (def->hyperv_features[j] !=3D VIR_TRISTATE_SWITCH_O= N) { + virBufferAddLit(&childBuf, "/>\n"); break; - virBufferEscapeString(&childBuf, " value=3D'%s'", + } + virBufferEscapeString(&childBuf, " value=3D'%s'/>\n", def->hyperv_vendor_id); break; =20 @@ -28093,8 +28098,6 @@ virDomainDefFormatFeatures(virBufferPtr buf, case VIR_DOMAIN_HYPERV_LAST: break; } - - virBufferAddLit(&childBuf, "/>\n"); } virBufferAdjustIndent(&childBuf, -2); virBufferAddLit(&childBuf, "\n"); --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481652; cv=none; d=zoho.com; s=zohoarc; b=m9okgpji1V5RZ442gC5p8ACuqmuTEahkMt9e+jPd+YYzrDrA4rb58M5SNNOv33wrOdv3OgHImWb+UiRaS5xHQHJOW0qESCO08e/czMyVJ+xxk2NPlA68kB+qMbdKJfEswC/Ww116x4W/eZ1rD9jFThbU0AwmFW8hgg57FD8mJIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481652; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=dgOUxejIomGllZQSGQFi3wVSzjsk2x0T0bMCA2n12Qs=; b=VTs2wq/EcHL7dXULCULntX4TMggnc6pxOLRKDYHk3r7ywYf5hMKx23vK9AXS+TyIXeeCH4F0LBC4HMG47xU1Mee88EXNoQhlLJFOoovD6yH5mvR3R6eh+zJ1N3twZSsFj+rzNWlwJPK6WEEOxnYTc8rhK7OaThR/seUm7OnL0y4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564481652556730.1615385284788; Tue, 30 Jul 2019 03:14:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0603EB2DC7; Tue, 30 Jul 2019 10:14:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF76B5D6B2; Tue, 30 Jul 2019 10:14:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 94281180BA9C; Tue, 30 Jul 2019 10:14:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UAE7oL002211 for ; Tue, 30 Jul 2019 06:14:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4D4AF6013A; Tue, 30 Jul 2019 10:14:07 +0000 (UTC) Received: from mx1.redhat.com (ext-mx03.extmail.prod.ext.phx2.redhat.com [10.5.110.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 451BC601A1 for ; Tue, 30 Jul 2019 10:14:01 +0000 (UTC) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76A387FDE9 for ; Tue, 30 Jul 2019 10:14:01 +0000 (UTC) Received: by mail-wr1-f71.google.com with SMTP id w11so31552679wrl.7 for ; Tue, 30 Jul 2019 03:14:01 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.13.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:13:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YNfO2F+fYA9nvyJFxnLoCrmfnDVLsZnKwukzH1pLXoI=; b=jlBue6tDHiWup6g4oRN2NpoLNsnJEj0zq0sqla5SBR//wcnAbZXOznx6/VnXajePY6 x9IYHQoF6i80wzEfs7hZVIQdVm1SRCqLU88ToVSF3k+cPa2cqLG6d5fLSsCTPlS1Zixx 9TDpZSPb3O1rqjI2lIAowZCFoU+4GP7TxRtSVXhJ1KD1hCWfo+vRm9GYyhLds/tXkFbm uPVOMWud6LbdcdgFpn+BA6MTvaE4L++4iebvhHir/gjaZB8ldPru5u6gVjx5TDvr4S80 QMRg53V8ZXXCZotN2d9ckdDdiN0NYAuFlu904oAD85tcxBADvmW+jjx8n5IdeXQfSMDY 3BJw== X-Gm-Message-State: APjAAAUvfc/afuhN2TjhbtsVaFeZPrqdwIlS+bVfkRbw9UrGyy8Z3HCl xie5aa9o63OURNtyQeeMVj6Bz1EG7cnyBcCNrB1+KgpF38Js1rLsiy9dzzGHMiNTQh2DnJOWeG2 wk3EyWxEP1TlYMfhrz84= X-Received: by 2002:a7b:c0d0:: with SMTP id s16mr89750345wmh.136.1564481639776; Tue, 30 Jul 2019 03:13:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqx4YA1rDKWhZ3B+uT26wiTKM8UH1DEK/VjI8HNqzcNUu8SuvpRDJ1WNcMe7GUvSKoT1VWOWSA== X-Received: by 2002:a7b:c0d0:: with SMTP id s16mr89750320wmh.136.1564481639482; Tue, 30 Jul 2019 03:13:59 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:46 +0200 Message-Id: <20190730101348.4055-7-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 6/8] conf: add support for Direct Mode for Hyper-V Synthetic timers X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 30 Jul 2019 10:14:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Support 'Direct Mode' for Hyper-V Synthetic Timers in domain config. Make it 'stimer' enlightenment option as it is not a separate thing. Signed-off-by: Vitaly Kuznetsov --- docs/formatdomain.html.in | 10 +++--- docs/schemas/domaincommon.rng | 16 ++++++++- src/conf/domain_conf.c | 62 ++++++++++++++++++++++++++++++++++- src/conf/domain_conf.h | 1 + src/cpu/cpu_x86.c | 3 ++ src/cpu/cpu_x86_data.h | 2 ++ 6 files changed, 88 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index f5c882141a..d778fc3f62 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2033,7 +2033,9 @@ <vpindex state=3D'on'/> <runtime state=3D'on'/> <synic state=3D'on'/> - <stimer state=3D'on'/> + <stimer state=3D'on'> + <direct state=3D'on'/> + </stimer> <reset state=3D'on'/> <vendor_id state=3D'on' value=3D'KVM Hv'/> <frequencies state=3D'on'/> @@ -2148,9 +2150,9 @@ stimer - Enable SynIC timers - on, off - 1.3.3 (QEMU 2.6) + Enable SynIC timers, optionally with Direct Mode support + on, off; direct - on,off + 1.3.3 (QEMU 2.6), direct mode 5.6.0 (Q= EMU 4.1) reset diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index a0771da45b..6707dcc634 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -5907,7 +5907,7 @@ - + @@ -5956,6 +5956,20 @@ =20 + + + + + + + + + + + + + + diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0871f21494..98273ab62a 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -20383,6 +20383,39 @@ virDomainDefParseXML(xmlDocPtr xml, ctxt->node =3D node; } =20 + if (def->features[VIR_DOMAIN_HYPERV_STIMER] =3D=3D VIR_TRISTATE_SWITCH= _ON) { + int value; + if ((n =3D virXPathNodeSet("./features/hyperv/stimer/*", ctxt, &no= des)) < 0) + goto error; + + for (i =3D 0; i < n; i++) { + if (STRNEQ((const char *)nodes[i]->name, "direct")) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unsupported Hyper-V stimer feature: %s"), + nodes[i]->name); + goto error; + } + + if (!(tmp =3D virXMLPropString(nodes[i], "state"))) { + virReportError(VIR_ERR_XML_ERROR, + _("missing 'state' attribute for " + "Hyper-V stimer '%s' feature"), "direct"); + goto error; + } + + if ((value =3D virTristateSwitchTypeFromString(tmp)) < 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("invalid value of state argument " + "for Hyper-V stimer '%s' feature"), "dire= ct"); + goto error; + } + + VIR_FREE(tmp); + def->hyperv_stimer_direct =3D value; + } + VIR_FREE(nodes); + } + if (def->features[VIR_DOMAIN_FEATURE_KVM] =3D=3D VIR_TRISTATE_SWITCH_O= N) { int feature; int value; @@ -22607,6 +22640,17 @@ virDomainDefFeaturesCheckABIStability(virDomainDef= Ptr src, } } =20 + if (src->hyperv_features[VIR_DOMAIN_HYPERV_STIMER] =3D=3D VIR_TRISTATE= _SWITCH_ON) { + if (src->hyperv_stimer_direct !=3D dst->hyperv_stimer_direct) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("State of HyperV stimer direct feature differ= s: " + "source: '%s', destination: '%s'"), + virTristateSwitchTypeToString(src->hyperv_stime= r_direct), + virTristateSwitchTypeToString(dst->hyperv_stime= r_direct)); + return false; + } + } + /* kvm */ if (src->features[VIR_DOMAIN_FEATURE_KVM] =3D=3D VIR_TRISTATE_SWITCH_O= N) { for (i =3D 0; i < VIR_DOMAIN_KVM_LAST; i++) { @@ -28066,7 +28110,6 @@ virDomainDefFormatFeatures(virBufferPtr buf, case VIR_DOMAIN_HYPERV_VPINDEX: case VIR_DOMAIN_HYPERV_RUNTIME: case VIR_DOMAIN_HYPERV_SYNIC: - case VIR_DOMAIN_HYPERV_STIMER: case VIR_DOMAIN_HYPERV_RESET: case VIR_DOMAIN_HYPERV_FREQUENCIES: case VIR_DOMAIN_HYPERV_REENLIGHTENMENT: @@ -28085,6 +28128,23 @@ virDomainDefFormatFeatures(virBufferPtr buf, def->hyperv_spinlocks); break; =20 + case VIR_DOMAIN_HYPERV_STIMER: + if (def->hyperv_features[j] !=3D VIR_TRISTATE_SWITCH_O= N) { + virBufferAddLit(&childBuf, "/>\n"); + break; + } + if (def->hyperv_stimer_direct =3D=3D VIR_TRISTATE_SWIT= CH_ON) { + virBufferAddLit(&childBuf, ">\n"); + virBufferAdjustIndent(&childBuf, 2); + virBufferAddLit(&childBuf, "= \n"); + virBufferAdjustIndent(&childBuf, -2); + virBufferAddLit(&childBuf, "\n"); + } else { + virBufferAddLit(&childBuf, "/>\n"); + } + + break; + case VIR_DOMAIN_HYPERV_VENDOR_ID: if (def->hyperv_features[j] !=3D VIR_TRISTATE_SWITCH_O= N) { virBufferAddLit(&childBuf, "/>\n"); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8a4425df64..7a2a9e16c0 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2400,6 +2400,7 @@ struct _virDomainDef { int kvm_features[VIR_DOMAIN_KVM_LAST]; int msrs_features[VIR_DOMAIN_MSRS_LAST]; unsigned int hyperv_spinlocks; + int hyperv_stimer_direct; virGICVersion gic_version; virDomainHPTResizing hpt_resizing; unsigned long long hpt_maxpagesize; /* Stored in KiB */ diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 8575915597..fbfd9a5bfa 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -102,6 +102,8 @@ KVM_FEATURE_DEF(VIR_CPU_x86_HV_IPI, 0x40000004, 0x00000400, 0x0); KVM_FEATURE_DEF(VIR_CPU_x86_HV_EVMCS, 0x40000004, 0x00004000, 0x0); +KVM_FEATURE_DEF(VIR_CPU_x86_HV_STIMER_DIRECT, + 0x40000003, 0x0, 0x00080000); =20 static virCPUx86Feature x86_kvm_features[] =3D { @@ -119,6 +121,7 @@ static virCPUx86Feature x86_kvm_features[] =3D KVM_FEATURE(VIR_CPU_x86_HV_TLBFLUSH), KVM_FEATURE(VIR_CPU_x86_HV_IPI), KVM_FEATURE(VIR_CPU_x86_HV_EVMCS), + KVM_FEATURE(VIR_CPU_x86_HV_STIMER_DIRECT), }; =20 typedef struct _virCPUx86Model virCPUx86Model; diff --git a/src/cpu/cpu_x86_data.h b/src/cpu/cpu_x86_data.h index cc0c93dff0..cebf3b6669 100644 --- a/src/cpu/cpu_x86_data.h +++ b/src/cpu/cpu_x86_data.h @@ -64,6 +64,8 @@ struct _virCPUx86MSR { #define VIR_CPU_x86_HV_IPI "hv-ipi" #define VIR_CPU_x86_HV_EVMCS "hv-evmcs" =20 +/* Hyper-V Synthetic Timer option */ +#define VIR_CPU_x86_HV_STIMER_DIRECT "hv-stimer-direct" =20 #define VIR_CPU_X86_DATA_INIT { 0 } =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481652; cv=none; d=zoho.com; s=zohoarc; b=M7jeTg+1AIoGgS+Jtu4wcEcboKRROfG9h77A2WEcGtdYmKykILMfOMyTS/H151pEEgBz88kz14j6ltTzSkhw1GeCjf40Js53S7Qo7U9qUkP2zB/BwVPD7jYO7LBlGcYA80iDnU8+Vm1Ye3WM1dKBWVJe+PoIA6BINz4TGSyt4Oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481652; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=5WZ2F4xrf0fMkm0zqoye7LBy62jeFlDyT+cJfxPp8DQ=; b=a1VfjZFnwwAV50/7wwJ1KqbhdMyfbCChWQEPbn5h/UJ5tt3/2XWHSk33KYg9naVV/X2EaiHADVAknyBWazU1Zu4GqTcDr9brxhn6w1A75MfYKCRjLeUKExg5xcSHU6QmJwa3vWQkZxpyiSRafd0AVU7oSJ0yGncAGgDkm0FBdIQ= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15644816520214.4946776256362; Tue, 30 Jul 2019 03:14:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 401DC300C72B; Tue, 30 Jul 2019 10:14:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EBA585D97C; Tue, 30 Jul 2019 10:14:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B3E7F3CBD; Tue, 30 Jul 2019 10:14:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UAE5E1002198 for ; Tue, 30 Jul 2019 06:14:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id D1E8E5C21F; Tue, 30 Jul 2019 10:14:05 +0000 (UTC) Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA73E5C205 for ; Tue, 30 Jul 2019 10:14:03 +0000 (UTC) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B887744FB1 for ; Tue, 30 Jul 2019 10:14:02 +0000 (UTC) Received: by mail-wm1-f69.google.com with SMTP id s19so12103470wmc.7 for ; Tue, 30 Jul 2019 03:14:02 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.13.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:14:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a+OFjusXtG4gix23MnJx2GYOfOpwJGLN3GMOS52FM2Y=; b=mgwFEiuo8Nb3a5Y4HGPZOyiJukVyhbGYY4GuottDfTs2g7FyVDgGEHzW9jLth6q7Be +JBsvxm3Iv10AMMYiR+9GcfLjfvVsR77NbX+0UsFtihvrk1TmiCua7NUbbkfN6PTU6vG PQm0CyGtTQRFi4uzxLyN9FEoR383X6kgtB6RoMVkmcB+MZsVELq0gzW3W961jpTbU1ZZ hjF5DdCWbiTF0ehNu+s8YA0VknKWRpzuye2c4hsjGT84hz+9I3isrznOYOqHjfjGvpmr rnyGOzbXBJafOCP3didiBU3Gxj2UlCjIWYcpOibbdI5HQ+1VaNW0BItwbsDEH5pcwbHb /gwA== X-Gm-Message-State: APjAAAWZe9K4SRV9tHiNLZxNMSBuGCngqWH9nmY/SZM0KMeRXWfyklSU 0rmxW+sqTCvnZPMeay1PwptfbR6D6mCNMlehW0nVRwy97Gs8gYs1ZvvL9Kfias1rf8kdEM6JMgB eO7OzUTjF/glGSAkfCR0= X-Received: by 2002:adf:f046:: with SMTP id t6mr10016406wro.307.1564481641184; Tue, 30 Jul 2019 03:14:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEuWWCchld7LFQMWOG6/DCgj4iAW0WmrXMYKzxQuVfPl5TwYOwIZGmvHKhYPvTJH01cwjr3g== X-Received: by 2002:adf:f046:: with SMTP id t6mr10016382wro.307.1564481640956; Tue, 30 Jul 2019 03:14:00 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:47 +0200 Message-Id: <20190730101348.4055-8-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 7/8] qemu: add support for Direct Mode for Hyper-V Synthetic timers X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 30 Jul 2019 10:14:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" QEMU-4.1 supports 'Direct Mode' for Hyper-V synthetic timers (hv-stimer-direct CPU flag): Windows guests can request that timer expiration notifications are delivered as normal interrupts (and not VMBus messages). This is used by Hyper-V on KVM. Signed-off-by: Vitaly Kuznetsov --- src/qemu/qemu_command.c | 12 ++++++++---- src/qemu/qemu_process.c | 20 ++++++++++++++++++-- tests/qemuxml2argvdata/hyperv.args | 4 ++-- tests/qemuxml2argvdata/hyperv.xml | 4 +++- tests/qemuxml2xmloutdata/hyperv.xml | 4 +++- 5 files changed, 34 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index fee51158a9..be5777023c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7151,10 +7151,10 @@ qemuBuildCpuCommandLine(virCommandPtr cmd, } =20 if (def->features[VIR_DOMAIN_FEATURE_HYPERV] =3D=3D VIR_TRISTATE_SWITC= H_ON) { - const char *hvPrefix =3D "hv-"; + const char *hvDelimiter =3D "-"; =20 if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_CANONICAL_CPU_FEATURES)) - hvPrefix =3D "hv_"; + hvDelimiter =3D "_"; =20 for (i =3D 0; i < VIR_DOMAIN_HYPERV_LAST; i++) { switch ((virDomainHyperv) i) { @@ -7171,9 +7171,13 @@ qemuBuildCpuCommandLine(virCommandPtr cmd, case VIR_DOMAIN_HYPERV_IPI: case VIR_DOMAIN_HYPERV_EVMCS: if (def->hyperv_features[i] =3D=3D VIR_TRISTATE_SWITCH_ON) - virBufferAsprintf(&buf, ",%s%s", - hvPrefix, + virBufferAsprintf(&buf, ",hv%s%s", + hvDelimiter, virDomainHypervTypeToString(i)); + if ((i =3D=3D VIR_DOMAIN_HYPERV_STIMER) && + (def->hyperv_stimer_direct =3D=3D VIR_TRISTATE_SWITCH_= ON)) + virBufferAsprintf(&buf, ",hv%sstimer%sdirect", hvDelim= iter, + hvDelimiter); break; =20 case VIR_DOMAIN_HYPERV_SPINLOCKS: diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0ee97e2296..ad1a75bfee 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4111,10 +4111,26 @@ qemuProcessVerifyHypervFeatures(virDomainDefPtr def, rc =3D virCPUDataCheckFeature(cpu, cpuFeature); VIR_FREE(cpuFeature); =20 - if (rc < 0) + if (rc < 0) { return -1; - else if (rc =3D=3D 1) + } else if (rc =3D=3D 1) { + if (i =3D=3D VIR_DOMAIN_HYPERV_STIMER) { + if (def->hyperv_stimer_direct !=3D VIR_TRISTATE_SWITCH_ON) + continue; + + rc =3D virCPUDataCheckFeature(cpu, "hv-stimer-direct"); + if (rc < 0) + return -1; + else if (rc =3D=3D 1) + continue; + + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("host doesn't support hyperv stimer '%s' = feature"), + "direct"); + return -1; + } continue; + } =20 switch ((virDomainHyperv) i) { case VIR_DOMAIN_HYPERV_RELAXED: diff --git a/tests/qemuxml2argvdata/hyperv.args b/tests/qemuxml2argvdata/hy= perv.args index 086adaa349..8040da9caa 100644 --- a/tests/qemuxml2argvdata/hyperv.args +++ b/tests/qemuxml2argvdata/hyperv.args @@ -12,8 +12,8 @@ QEMU_AUDIO_DRV=3Dnone \ -S \ -machine pc,accel=3Dtcg,usb=3Doff,dump-guest-core=3Doff \ -cpu 'qemu32,hv_relaxed,hv_vapic,hv-spinlocks=3D0x2fff,hv_vpindex,hv_runti= me,\ -hv_synic,hv_stimer,hv_reset,hv-vendor-id=3DKVM Hv,hv_frequencies,\ -hv_reenlightenment,hv_tlbflush,hv_ipi,hv_evmcs' \ +hv_synic,hv_stimer,hv_stimer_direct,hv_reset,hv-vendor-id=3DKVM Hv,\ +hv_frequencies,hv_reenlightenment,hv_tlbflush,hv_ipi,hv_evmcs' \ -m 214 \ -realtime mlock=3Doff \ -smp 6,sockets=3D6,cores=3D1,threads=3D1 \ diff --git a/tests/qemuxml2argvdata/hyperv.xml b/tests/qemuxml2argvdata/hyp= erv.xml index c6feaed528..ae0f934f76 100644 --- a/tests/qemuxml2argvdata/hyperv.xml +++ b/tests/qemuxml2argvdata/hyperv.xml @@ -17,7 +17,9 @@ - + + + diff --git a/tests/qemuxml2xmloutdata/hyperv.xml b/tests/qemuxml2xmloutdata= /hyperv.xml index 5510d3dfad..2e4b43d4c6 100644 --- a/tests/qemuxml2xmloutdata/hyperv.xml +++ b/tests/qemuxml2xmloutdata/hyperv.xml @@ -17,7 +17,9 @@ - + + + --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Sat Apr 27 10:13:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564481652; cv=none; d=zoho.com; s=zohoarc; b=adpgokHtlRyJ0p8Wsr+CmKVg9KXyRbmMCmNzpjzKbzBoFu0Ulq6+OzgaUk2HYdx5op7xHxlT3cOdXJ2JdPAtjj+wSHHhoeH2cYqZLBzJ4MnWWPlK9qRg/4wDmHFaowZ1dcMhseCe0rMVDvAX3V+CywIUv4CB7CZscKX56RDawd8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564481652; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=uxCdDKyxErS9g9nP3QYFbL209AfepTO8uMl70MnPMd4=; b=XHnyh21d9T8Bw9Ngc5xt/2A42LcfvTCBzz/xhDsMmMMrjC1A8nbr7CSas4sTx8fEBY93xZ1Lob5IAe+n2QjLMvO44XS3PbNJr05tZF9ytHl8pd7y+5Up/1GWhSWwy/amYLe0sSI9iHBuoul4bAFQyWfX4t9AvAfaTyFdZH5D1yg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564481652786698.9099054820177; Tue, 30 Jul 2019 03:14:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2102F3B77; Tue, 30 Jul 2019 10:14:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EF9915D9E2; Tue, 30 Jul 2019 10:14:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B3D71180BA9B; Tue, 30 Jul 2019 10:14:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6UAE4pm002165 for ; Tue, 30 Jul 2019 06:14:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 26E5A5C205; Tue, 30 Jul 2019 10:14:04 +0000 (UTC) Received: from mx1.redhat.com (ext-mx09.extmail.prod.ext.phx2.redhat.com [10.5.110.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FFEB5C1B4 for ; Tue, 30 Jul 2019 10:14:04 +0000 (UTC) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E5C0E2DE09 for ; Tue, 30 Jul 2019 10:14:03 +0000 (UTC) Received: by mail-wm1-f70.google.com with SMTP id r9so14559685wme.8 for ; Tue, 30 Jul 2019 03:14:03 -0700 (PDT) Received: from vitty.brq.redhat.com (ip-89-176-127-93.net.upcbroadband.cz. [89.176.127.93]) by smtp.gmail.com with ESMTPSA id o7sm34844155wru.58.2019.07.30.03.14.01 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 03:14:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JXDPk9xGwUIFVzqvxpRa/95L6AU2S/nuaqRRRs2WPUI=; b=KJ8wtjWweoBT2Y6QiZt9f2aeNR+/F8y5i/drIf1WVVM7mghyzcWJ37REtuhmeig+g1 lB4ZCG2OUtmE0lcB+IgW4m482Cu3t6T/n9nal7JdkNYONQlsVDr8JV4n591g/VW7WANc lWUg/RTGOLd6QG2Prqa0DNsokL0kMLvp2WA/uNneMaQv0vW4ayUd8jlON76ubIT9D5GV cXUJdxmM1lJ807jSCdn/uz7TrchDz2lB7k+Z0d9T2XUNww0FBbRAENGrUdxVttwiVUll MuHW6RUOM5eiUrlz7/8lGkMjP/v9s/48Rk6fk1695lesT7A/Xhm1bhZojviBbsUeZgoN 5Cow== X-Gm-Message-State: APjAAAVpWmP66i1yvDaRpZviCnbp/wtyZSqrw6Hudkh3l88pe6ZN3xkP zxXxVjv08wCOvTxUmfiHJTSGntODsEF06CXmEcEKmf6DHwBdDg7b5HIE18MX9dRoVSqEGiReyRj T6nbbrQTo15AHMvMEMjI= X-Received: by 2002:a05:600c:254b:: with SMTP id e11mr97489689wma.171.1564481642345; Tue, 30 Jul 2019 03:14:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyC5A0Zotvf9OEc4OypL90KR8OZfdmfj8eD1bDRfAcZ0gSEJk9DHOINE/tcYGGl8bsgtx39Fg== X-Received: by 2002:a05:600c:254b:: with SMTP id e11mr97489668wma.171.1564481642114; Tue, 30 Jul 2019 03:14:02 -0700 (PDT) From: Vitaly Kuznetsov To: libvir-list@redhat.com Date: Tue, 30 Jul 2019 12:13:48 +0200 Message-Id: <20190730101348.4055-9-vkuznets@redhat.com> In-Reply-To: <20190730101348.4055-1-vkuznets@redhat.com> References: <20190730101348.4055-1-vkuznets@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?J=C3=A1n=20Tomko?= , Nikolay Shirokovskiy Subject: [libvirt] [PATCH v2 8/8] news: mention Direct Mode for Hyper-V Synthetic timers support X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 30 Jul 2019 10:14:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The QEMU driver now supports Direct Mode for Hyper-V Synthetic timers for Hyper-V guests. Signed-off-by: Vitaly Kuznetsov --- docs/news.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 1134309ec2..e4d8f1ecac 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -54,6 +54,15 @@
+ + + qemu: Support Direct Mode for Hyper-V Synthetic timers + + + The QEMU driver now supports Direct Mode for Hyper-V Synthetic t= imers + for Hyper-V guests. + + qemu: Introduce a new video model of type 'bochs' --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list