From nobody Mon Feb 9 10:27:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1564063607; cv=none; d=zoho.com; s=zohoarc; b=f4BnWHihkhaw1Kq4hQ6EH32H3IB2Ht33bndiXC9ZL+k992jSnzVgYhsJKpFH3y9FeC2DTDh0a3ZmTAf6TZePHTWIEozIAm81xV6m7XO9M5CpqCM7Pecqu57uCo7pVdG+yZVE176BiTKtvLtlmtz/XKXHKMAKuuFFYNiF7rwZ7qU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1564063607; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=aCnyauCZFWvUwJI5tq1H0vkccy0SllinUQisCsPnO2k=; b=neA9+jERhb6tK1EwwaG6IFjIecq5QL9s/xERA9926atf/pG8TA03BgcxOLTX5U3su6xaaIwcM8VbbuXK2en5iSob6ywbobz9LkgWl3BtCtK6PohLboMGnC9U2YlAQRcIpmIn1h56F1ioOWZEzK6L/PC4Tr6EyFP7j/NsJYk3Ijo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1564063607046898.3419486711399; Thu, 25 Jul 2019 07:06:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B4CBFC066474; Thu, 25 Jul 2019 14:06:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8EB6D5C325; Thu, 25 Jul 2019 14:06:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4B2F63CBE; Thu, 25 Jul 2019 14:06:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6PE6hZF007520 for ; Thu, 25 Jul 2019 10:06:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8F001608AB; Thu, 25 Jul 2019 14:06:43 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 179F860606 for ; Thu, 25 Jul 2019 14:06:40 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Thu, 25 Jul 2019 16:06:20 +0200 Message-Id: <20190725140625.2397-7-abologna@redhat.com> In-Reply-To: <20190725140625.2397-1-abologna@redhat.com> References: <20190725140625.2397-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH RFC 06/11] qemu: Update query-cpu-model-expansion check X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 25 Jul 2019 14:06:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" CPU features are available on ARM only wherever the query-cpu-model-expansion QMP command is available, same as on s390. Update qemuBuildCpuModelArgStr() to reflect this fact. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1cf165079f..510e066733 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7050,7 +7050,8 @@ qemuBuildCpuModelArgStr(virQEMUDriverPtr driver, break; } =20 - if (ARCH_IS_S390(def->os.arch) && cpu->features && + if ((ARCH_IS_S390(def->os.arch) || ARCH_IS_ARM(def->os.arch)) && + cpu->features && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION)) { virReportError(VIR_ERR_INTERNAL_ERROR, _("CPU features not supported by hypervisor for %s " --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list