From nobody Wed Nov 27 00:30:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890334; cv=none; d=zoho.com; s=zohoarc; b=S4UKNWBAtmbvE0fRJBLAcMaKS1JrjQgyzfUtBCvgdC+Cd2HWV7MegAqx2POzNU3JKc37/C8/rZ7Rwp+lsoPpRWNVcGkFs+M89q9IZYMSGUD+j9yHpny0ZZBsMgXgPmEoJ/h/deXndGKMkHztt13L5SWkd01WpoiUYhzP1enk300= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890334; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=tghKDCYCkJMgjkxF/Qv9zwGuwckH/BXhRnoOYuQ+GWQ=; b=Iae9FsMoL1ZKk8XHFa/KqxBLWBg7CxUIQJ7VHEK90SfcWWYPr1rmY5th4uJKFOOdgoREY9dWOPK6CkveXYZH5LQ+FQGogvJkcsCp6BDkttfCFOzUvGCfWPVLNR3B+Ctsaacf5cpMn0qzV4D9xv4Ptpih3L1lxY8cxdPpLxWk36U= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890334448594.1272510080747; Tue, 23 Jul 2019 06:58:54 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CA11C025019; Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 45F9D60603; Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E86218089C8; Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwLJW029837 for ; Tue, 23 Jul 2019 09:58:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 846A35D72E; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43B555D704 for ; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:11 -0400 Message-Id: <20190723135811.26837-5-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/4] tests: Avoid possible error in testExecRestart X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 23 Jul 2019 13:58:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If the dup2 fails, then we aren't going to get the correct result. Found by Coverity Signed-off-by: John Ferlan --- tests/virnetdaemontest.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c index eae630a8f1..d0e9f241e3 100644 --- a/tests/virnetdaemontest.c +++ b/tests/virnetdaemontest.c @@ -287,10 +287,11 @@ static int testExecRestart(const void *opaque) * fds 100->103 for something else, which is probably * fairly reasonable in general */ - dup2(fdserver[0], 100); - dup2(fdserver[1], 101); - dup2(fdclient[0], 102); - dup2(fdclient[1], 103); + if (dup2(fdserver[0], 100) < 0 || + dup2(fdserver[1], 101) < 0 || + dup2(fdclient[0], 102) < 0 || + dup2(fdclient[1], 103) < 0) + goto cleanup; =20 if (virAsprintf(&infile, "%s/virnetdaemondata/input-data-%s.json", abs_srcdir, data->jsonfile) < 0) --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list