From nobody Wed Nov 27 00:32:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890331; cv=none; d=zoho.com; s=zohoarc; b=FFoi8AceaZxjpo8z2+Z+kZ4ZZnRnPNjBO8rSt/tJSy4QC6FEiprDBDZmVHYXRQKInV8AdDmTHrIiLBfP0gvOfRv/ebgqbJzvjo2pvogs8ZpPTEUHr6PsL1hfY5sMz0O2njM/ALmuxXE/Gstn4U9BYg6xlrRWhTKGSPlcMhQY8Kc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890331; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=N3cekm5AUACouxAHE4yHsDD5TO99qhbXefchKP273TY=; b=ZDNvaYOFTMHXRWo3u6ZPZhDMAGy0y++thJMxYV2MK+Y2yWY8qtFP02IRo5DQ+pqT5IUKV/ENWLeacb87u4GuG4eqCYq5kh3zyFGl6oEVp3tev/SXotEI29CVr9Bis4tXR5+o9kviquKqJMlsXVohTu8bmM8IZevB5FQvHyzMabo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890331015450.7610268570876; Tue, 23 Jul 2019 06:58:51 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB8FC3084242; Tue, 23 Jul 2019 13:58:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A720910114A1; Tue, 23 Jul 2019 13:58:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6823441F40; Tue, 23 Jul 2019 13:58:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwL3M029832 for ; Tue, 23 Jul 2019 09:58:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1AE665D72E; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEB695D704 for ; Tue, 23 Jul 2019 13:58:20 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:10 -0400 Message-Id: <20190723135811.26837-4-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/4] util: Avoid possible error in virCommandMassClose X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 23 Jul 2019 13:58:50 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Avoid the chance that sysconf(_SC_OPEN_MAX) returns -1 and thus would cause virBitmapNew would attempt to allocate a very large bitmap. Found by Coverity Signed-off-by: John Ferlan --- src/util/vircommand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 4501c96bbf..cedbd01446 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -487,7 +487,7 @@ virCommandMassClose(virCommandPtr cmd, * Therefore we can safely allocate memory here (and transitively call * opendir/readdir) without a deadlock. */ =20 - if (!(fds =3D virBitmapNew(openmax))) + if (openmax < 0 || !(fds =3D virBitmapNew(openmax))) return -1; =20 # ifdef __linux__ --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list