From nobody Wed Nov 27 00:44:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890307; cv=none; d=zoho.com; s=zohoarc; b=iNt3v0Q7tIxecvWBYA+xQ1TaqZHXLEcbN3jIs8UKic/kzVQtA/49hg8X+bYFJgLtwEo5y/SqKf2d58TkKBFNHJBPg5aqgEquGv8hNuBq6rrZKP1JNRLfOtSKLRxjdPwE7AzPpp4rbXB5STeOQoD3MtEAJVbhsDOsu/7pmWdWAos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890307; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=w/8+H9w1O+ZNjlAJ9ODA6dxPKvRpokBFRjPAql7ITSo=; b=hAXHIKYO6Hy2v6yiTOYWpIbg+boCOcAEMl6DlsQXB+nYssepbqR+E/biIvX6I7BN2fN2pTT9t3xGWFCYmqimpxSQ684JotGnTTrr3+AFM4NccjDVCs2zoQtSJht0XpNWqNgwXxgM1NT3Q+4CPz0Wfi8vwxe9aAP6C4fplIlsy1g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890307825413.1667326310927; Tue, 23 Jul 2019 06:58:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD484C065119; Tue, 23 Jul 2019 13:58:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 915AB60852; Tue, 23 Jul 2019 13:58:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A1B3318045CE; Tue, 23 Jul 2019 13:58:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwKpN029825 for ; Tue, 23 Jul 2019 09:58:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id A55315D704; Tue, 23 Jul 2019 13:58:20 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63C7D6266C for ; Tue, 23 Jul 2019 13:58:18 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:09 -0400 Message-Id: <20190723135811.26837-3-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/4] test: Return early in testQueryJobs X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 23 Jul 2019 13:58:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Avoid the chance that qemuMonitorTestNewSimple could return NULL Found by Coverity Signed-off-by: John Ferlan --- tests/qemumonitorjsontest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 8eb9d2e01b..bf89f49aca 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2959,6 +2959,9 @@ testQueryJobs(const void *opaque) size_t i; int ret =3D -1; =20 + if (!test) + return -1; + if (virAsprintf(&filenameJSON, abs_srcdir "/qemumonitorjsondata/query-jobs-%s.json", data->name) < 0 || --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list