From nobody Wed Nov 27 00:45:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563890327; cv=none; d=zoho.com; s=zohoarc; b=DaAfQaWWZ9mhohQ9fDwxr4hjG5z4nzCVpMKTpDpo16eerXKWqGyikYlZroKHYjPqAJjiSt6jTY4wz3KKwuAbqfZVk7pBsmEBe7UvBjIDJ3+gRRIStnXuvBPO0dGkzKzNqzNf3nFlY9p1QS9524+TnYU20vAxTby4TkrtTXep+Xs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563890327; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rWrXxVqTXy1iOxpoc1WHkgitXOUUq604NZE5Agvd3EI=; b=hxE35IURNwkkIai0SpAuTfWYkCvRqfRH2jBcxWGJKDDmARPBRwm/73Hi/9dT0MNHZolFiR5KsNVJDvzdMiwTqCk0qg+BeS7j5C0P+wE9NXkKu8XauyoPcAcTNXabhhVeScIUpQA/Cu4RaX25IQNquBbc/kGcI6g5cMW+3Gf2gEE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563890327651787.8069598797234; Tue, 23 Jul 2019 06:58:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E83D308620B; Tue, 23 Jul 2019 13:58:46 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 31DC7102486E; Tue, 23 Jul 2019 13:58:46 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D4CF018045CE; Tue, 23 Jul 2019 13:58:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6NDwI0i029812 for ; Tue, 23 Jul 2019 09:58:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 062715D72E; Tue, 23 Jul 2019 13:58:18 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-117-39.phx2.redhat.com [10.3.117.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B88D45D704 for ; Tue, 23 Jul 2019 13:58:17 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Tue, 23 Jul 2019 09:58:08 -0400 Message-Id: <20190723135811.26837-2-jferlan@redhat.com> In-Reply-To: <20190723135811.26837-1-jferlan@redhat.com> References: <20190723135811.26837-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] qemu: Remove unnecessary check in qemuMonitorJSONGetJobInfoOne X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Tue, 23 Jul 2019 13:58:46 +0000 (UTC) Content-Type: text/plain; charset="utf-8" It's already dereffed in the initialization and shouldn't be NULL unless virJSONValueArraySize after a virJSONValueObjectGetArray could return a NULL data entry. Found by Coverity Signed-off-by: John Ferlan --- src/qemu/qemu_monitor_json.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index f19dced014..d38b2f2cbe 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -9133,9 +9133,6 @@ qemuMonitorJSONGetJobInfoOne(virJSONValuePtr data) VIR_AUTOPTR(qemuMonitorJobInfo) job =3D NULL; qemuMonitorJobInfoPtr ret =3D NULL; =20 - if (!data) - return NULL; - if (VIR_ALLOC(job) < 0) return NULL; =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list