[v1] util: Fix uninitalized variable to avoid garbage value.

[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.

Julio Faracco posted 1 patch 4 years, 9 months ago

Diff against v1
Download mbox

Test syntax-check passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190718034456.15740-1-jcfaracco@gmail.com

src/util/virtime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.

Posted by Julio Faracco 4 years, 9 months ago

This commit is similar with 596aa144. It fixes an uninitialized
variable to avoid garbage value. This case, it uses time 't' 0 if
an error occurs with virTimeMillisNowRaw.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
---
 src/util/virtime.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virtime.c b/src/util/virtime.c
index d1187726ee..86993e4e8d 100644
--- a/src/util/virtime.c
+++ b/src/util/virtime.c
@@ -422,7 +422,7 @@ virTimeBackOffStart(virTimeBackOffVar *var,
 bool
 virTimeBackOffWait(virTimeBackOffVar *var)
 {
-    unsigned long long t, next;
+    unsigned long long next, t = 0;
 
     ignore_value(virTimeMillisNowRaw(&t));
 
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.

Posted by Michal Privoznik 4 years, 9 months ago

On 7/18/19 5:44 AM, Julio Faracco wrote:
> This commit is similar with 596aa144. It fixes an uninitialized
> variable to avoid garbage value. This case, it uses time 't' 0 if
> an error occurs with virTimeMillisNowRaw.
> 
> Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
> ---
>   src/util/virtime.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list