From nobody Fri Dec 19 20:34:50 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563371390; cv=none; d=zoho.com; s=zohoarc; b=fZslsLpv7dUAaTBKYjfDre4fI+DPFgdJuCGHzYIEmZyLk8LBvhScYb7ep6nxVG/mrQTO/RpfEadWm/Wthcg3R0jrq5pd1lKe8NV13eK4FMY8ydcj3xnRAGEuWvkqpRWQ+DO5ANOMAwAjwl5vZxs8Qo/QLpLn797q3qvZmZ7j4FQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563371390; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=m5qvy5dXjNCMPeRB7QTw/FxvhxfeY572kPNiRJIq+6E=; b=hvd/jHR3xMP9dboJNon0rI41t6m5pp6BDat+7FToge15KzUhxfLBeqy4ce+Q4a9/9rSNYWU70lCLf18lgc8waxzQfFZwBrZa1IhJIUrnfN57SToLaW7y43cIynZGpspp2NuWmE5A+jWAULa8ZCR5qKm23s64ctXqBqsJ+ZKJPkA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563371390876320.12810482685165; Wed, 17 Jul 2019 06:49:50 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 02BDB19CBED; Wed, 17 Jul 2019 13:49:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD4001001DDE; Wed, 17 Jul 2019 13:49:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8AA321800206; Wed, 17 Jul 2019 13:49:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6HDniqH025445 for ; Wed, 17 Jul 2019 09:49:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id 537B960A35; Wed, 17 Jul 2019 13:49:44 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D176B60920 for ; Wed, 17 Jul 2019 13:49:41 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Wed, 17 Jul 2019 15:49:16 +0200 Message-Id: <20190717134929.10540-8-abologna@redhat.com> In-Reply-To: <20190717134929.10540-1-abologna@redhat.com> References: <20190717134929.10540-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH v2 07/20] quayadmin: Implement debug mode X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 17 Jul 2019 13:49:49 +0000 (UTC) Content-Type: text/plain; charset="utf-8" While a command line parameter for enabling debug mode has been defined, it's not currently used in any form or shape. Make it so enabling debug mode actually does something useful, that is, prints the most important parts of the conversation happening between the client and the server. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/quayadmin | 41 +++++++++++++++++++++++++++++------------ 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/guests/quayadmin b/guests/quayadmin index 7ddf7a4..04a8b66 100755 --- a/guests/quayadmin +++ b/guests/quayadmin @@ -19,6 +19,7 @@ # with this program. If not, see . =20 import argparse +import pprint import requests import sys =20 @@ -28,26 +29,42 @@ clientsecret =3D "xxx" token=3D "xxx" =20 =20 -def request(endpoint, method, payload=3DNone, params=3DNone): +def request(endpoint, method, payload=3DNone, params=3DNone, debug=3DFalse= ): url =3D baseurl + endpoint =20 headers =3D { "Authorization": "Bearer {}".format(token) } =20 - return method(url, headers=3Dheaders, json=3Dpayload, params=3Dparams) + if debug: + print("=3D> {") + print(" url=3D{}".format(url)) + print(" params=3D{}".format(pprint.pformat(params))) + print(" payload=3D{}".format(pprint.pformat(payload))) + print("}") =20 + res =3D method(url, headers=3Dheaders, json=3Dpayload, params=3Dparams) =20 -def get(endpoint, params=3DNone): - return request(endpoint, method=3Drequests.get, params=3Dparams) + if debug: + print("<=3D {") + print(" status_code=3D{}".format(res.status_code)) + if res.text is not None and len(res.text) > 0: + print(" json=3D{}".format(pprint.pformat(res.json()))) + print("}") =20 + return res =20 -def delete(endpoint, payload=3DNone): - return request(endpoint, method=3Drequests.delete, payload=3Dpayload) =20 +def get(endpoint, params=3DNone, debug=3DFalse): + return request(endpoint, method=3Drequests.get, params=3Dparams, debug= =3Ddebug) =20 -def post(endpoint, payload=3DNone): - return request(endpoint, method=3Drequests.post, payload=3Dpayload) + +def delete(endpoint, payload=3DNone, debug=3DFalse): + return request(endpoint, method=3Drequests.delete, payload=3Dpayload, = debug=3Ddebug) + + +def post(endpoint, payload=3DNone, debug=3DFalse): + return request(endpoint, method=3Drequests.post, payload=3Dpayload, de= bug=3Ddebug) =20 =20 def has_error(quiet, res, expected, message): @@ -71,7 +88,7 @@ def run_list_repos(args): "namespace": args.namespace, } =20 - res =3D get(endpoint, params=3Dparams) + res =3D get(endpoint, params=3Dparams, debug=3Dargs.debug) =20 if has_error(args.quiet, res, 200, "Cannot list repositories"): return 1 @@ -85,7 +102,7 @@ def run_list_repos(args): def run_show_repo(args): endpoint =3D "/repository/{}/{}".format(args.namespace, args.repo) =20 - res =3D get(endpoint) + res =3D get(endpoint, debug=3Dargs.debug) =20 if has_error(args.quiet, res, 200, "Cannot query repository {}/{}" .format(args.namespace, args.repo)): @@ -112,7 +129,7 @@ def run_create_repo(args): "description": args.desc, } =20 - res =3D post(endpoint, payload=3Dpayload) + res =3D post(endpoint, payload=3Dpayload, debug=3Dargs.debug) =20 if has_error(args.quiet, res, 201, "Cannot create repository {}/{}" .format(args.namespace, args.repo)): @@ -127,7 +144,7 @@ def run_create_repo(args): def run_delete_repo(args): endpoint =3D "/repository/{}/{}".format(args.namespace, args.repo) =20 - res =3D delete(endpoint) + res =3D delete(endpoint, debug=3Dargs.debug) =20 if has_error(args.quiet, res, 204, "Cannot delete repository {}/{}" .format(args.namespace, args.repo)): --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list