From nobody Fri Dec 19 20:34:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563371387; cv=none; d=zoho.com; s=zohoarc; b=GKNMvK08dpyCidOmmK9RyRhV7N46t1SvSIqeG4mqaTFROeJSXujB6PdUWY22jeZPNVcSulJlZGkutv3IklfvNpCuWT45rliEoJVnLnM79ewTvzCKofcclDIfiaCQJSrsFIna/V3hK7mNTy8Ry69b3yyRp2Z6rrr16zUKsaywkFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563371387; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=r/jebztjB9GppPQcop7K6mj8B6mKXPnarBnrmNQU4jA=; b=doK1gYoFjEhOOLViB6k+TzylDtg9sKeTx/aR8E4HptlsTS2gG2+Nfo2LUVYxcjRoDpKNHcjBPRrPO+pWKdh3+66aqVjreyMgYy4r7Ev8QMfoBsRQ9cQnr0JHugYLaNu7LmF+BumFqD+NRw4kSG17H1E23/rQkTLoy68hCvplobc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563371387319448.7122336044155; Wed, 17 Jul 2019 06:49:47 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68823307154A; Wed, 17 Jul 2019 13:49:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3ED441001B38; Wed, 17 Jul 2019 13:49:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EAC321800208; Wed, 17 Jul 2019 13:49:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6HDndLE025403 for ; Wed, 17 Jul 2019 09:49:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2449760920; Wed, 17 Jul 2019 13:49:39 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A2C3660A35 for ; Wed, 17 Jul 2019 13:49:38 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Wed, 17 Jul 2019 15:49:12 +0200 Message-Id: <20190717134929.10540-4-abologna@redhat.com> In-Reply-To: <20190717134929.10540-1-abologna@redhat.com> References: <20190717134929.10540-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH v2 03/20] quayadmin: Tweak quiet logic X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Wed, 17 Jul 2019 13:49:45 +0000 (UTC) Content-Type: text/plain; charset="utf-8" If we've been asked not to produce any output, we can bail early: doing so means we don't need to increase indentation for subsequent code, and in some cases we can even avoid fetching the JSON data from the response object. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/quayadmin | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/guests/quayadmin b/guests/quayadmin index 5dc5eff..3e6cc87 100755 --- a/guests/quayadmin +++ b/guests/quayadmin @@ -83,9 +83,12 @@ def run_show_repo(args): .format(args.namespace, args.repo)): return 1 =20 + if args.quiet: + return 0 + info =3D res.json() - if not args.quiet: - print("{}/{}: {}".format(args.namespace, args.repo, info["descript= ion"])) + + print("{}/{}: {}".format(args.namespace, args.repo, info["description"= ])) =20 =20 def run_create_repo(args): @@ -101,8 +104,10 @@ def run_create_repo(args): .format(args.namespace, args.repo)): return 1 =20 - if not args.quiet: - print("Repository {}/{} created".format(args.namespace, args.repo)) + if args.quiet: + return 0 + + print("Repository {}/{} created".format(args.namespace, args.repo)) =20 =20 def run_delete_repo(args): @@ -112,8 +117,10 @@ def run_delete_repo(args): .format(args.namespace, args.repo)): return 1 =20 - if not args.quiet: - print("Repository {}/{} deleted".format(args.namespace, args.repo)) + if args.quiet: + return 0 + + print("Repository {}/{} deleted".format(args.namespace, args.repo)) =20 =20 def add_arg_namespace(parser): --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list