From nobody Mon Feb 9 04:29:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1563364483; cv=none; d=zoho.com; s=zohoarc; b=PAl57dj+BDkOWsXipF2wVB3MyAD3VYLSjX/zJJ80WcMDlWFCUgOByK4dU1Nqnx0iiFyIvizC/rD9m5OEOA1g6du43XYxlvHTCizXJhOyOiU2qshjTFSRLibspdOLY7ETgmyjBdn6zdQFaPlpJx9ZFlCOeLqhnmld6TnrSgDnFtU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1563364483; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=sdzrvyE8J/AI6ONLbCYyem7Qc2mOcyW187NMOtIXhbg=; b=j8cDefhpc3d7R1pGLOf5E74Tkd4GrRghZx7eBoZwqttW/zhpT97biLwqAve16BfhDJwSyDMtHpS7PUMGVxWgeeDNpha4uEq4hSj+HBPToS9jnv4d6M5yzfpBc757JA8jkw4pRRh7Y8tGQzuPwb3G+SI3ub7Qltpop15KRxWKgiA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1563364483098473.83608042770265; Wed, 17 Jul 2019 04:54:43 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2D45D308FBA9; Wed, 17 Jul 2019 11:54:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFAA35B689; Wed, 17 Jul 2019 11:54:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7252318045DA; Wed, 17 Jul 2019 11:54:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6HBsLCm031423 for ; Wed, 17 Jul 2019 07:54:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id B94D410A394B; Wed, 17 Jul 2019 11:54:21 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F0751091EFD for ; Wed, 17 Jul 2019 11:54:21 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Wed, 17 Jul 2019 13:53:59 +0200 Message-Id: <20190717115409.1452-11-abologna@redhat.com> In-Reply-To: <20190717115409.1452-1-abologna@redhat.com> References: <20190717115409.1452-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 10/20] quayadmin: Read configuration from file X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 17 Jul 2019 11:54:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" We don't want sensitive information such as the API token to be stored into the script, both because it could lead to them being leaked by mistake and because it makes it needlessly complicated for users to take advantage of the tool. Signed-off-by: Andrea Bolognani --- guests/quayadmin | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/guests/quayadmin b/guests/quayadmin index 25128e5..4e60653 100755 --- a/guests/quayadmin +++ b/guests/quayadmin @@ -19,15 +19,32 @@ # with this program. If not, see . =20 import argparse +import configparser +import os import pprint import requests import sys =20 def get_config(): - config =3D { - "baseurl": "https://quay.io/api/v1", - "token": "xxx", - } + try: + path =3D os.environ["XDG_CONFIG_HOME"] + except KeyError: + path =3D os.path.join(os.environ["HOME"], ".config") + path =3D os.path.join(os.path.join(path, "quayadmin"), "config.ini") + + try: + parser =3D configparser.ConfigParser() + parser.read_file(open(path)) + except Exception as ex: + raise Exception("Cannot load config: {}".format(ex)) + + try: + config =3D { + "baseurl": "https://quay.io/api/v1", + "token": parser["DEFAULT"]["token"], + } + except KeyError: + raise Exception("Token not found in {}".format(path)) =20 return config =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list