From nobody Wed Apr 24 07:34:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562829835; cv=none; d=zoho.com; s=zohoarc; b=fX5x39+uziizHknpunRaF6MaCEAWcWrSmjcCtZPlkumTmnPG4NZpNrvLIr93iSeUvChbzjkb52ZQTRRG6Fu47HvMOfPh8REQRfcnc368N40q6B5ISmFcUXJy1i1n0kr9Ip3yQ9ZcPikVWHdS5VLb8rEGE//vwa7sBlgUkuFaN0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562829835; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=E/Qhlvl1kcx57uGzpk3lXUXntdK+HwH/XtWSRu+6wWQ=; b=JAWbTEu6sUXsyGDi3k/3fMMmPF95HFCuB4GXx49qMPHvkny0D66/hiM1u2RMHkFOds+agMRcNWlWnN3CSKRfPnEQpIcnfMpyeoFacWlszQ63axu05rgr3UC68hgZa3T6qxYAPeAaSEKd56uipvdcg+B5oSbDgfwugwvrkyJQC3s= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1562829835793270.03789133548014; Thu, 11 Jul 2019 00:23:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A71CA81F01; Thu, 11 Jul 2019 07:23:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 825B960143; Thu, 11 Jul 2019 07:23:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 42A0218184AC; Thu, 11 Jul 2019 07:23:53 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6B7NVJc012253 for ; Thu, 11 Jul 2019 03:23:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9553E6014E; Thu, 11 Jul 2019 07:23:31 +0000 (UTC) Received: from hansolo.nay.redhat.com (unknown [10.66.4.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8765760141; Thu, 11 Jul 2019 07:23:28 +0000 (UTC) From: Han Han To: libvir-list@redhat.com Date: Thu, 11 Jul 2019 15:23:05 +0800 Message-Id: <20190711072307.14686-2-hhan@redhat.com> In-Reply-To: <20190711072307.14686-1-hhan@redhat.com> References: <20190711072307.14686-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH v2 1/3] storage: Add iscsi-direct pool list type flag X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 11 Jul 2019 07:23:54 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Add pool list type flag VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT, which was forgotten when introducing iscsi-direct pool at f0bf1be3. https://bugzilla.redhat.com/show_bug.cgi?id=3D1726609 Signed-off-by: Han Han --- include/libvirt/libvirt-storage.h | 1 + src/conf/storage_conf.h | 3 ++- src/conf/virstorageobj.c | 4 +++- src/libvirt-storage.c | 1 + tools/virsh-pool.c | 2 +- tools/virsh.pod | 2 +- 6 files changed, 9 insertions(+), 4 deletions(-) diff --git a/include/libvirt/libvirt-storage.h b/include/libvirt/libvirt-st= orage.h index 5a95b2b139..089e1e0bd1 100644 --- a/include/libvirt/libvirt-storage.h +++ b/include/libvirt/libvirt-storage.h @@ -244,6 +244,7 @@ typedef enum { VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER =3D 1 << 16, VIR_CONNECT_LIST_STORAGE_POOLS_ZFS =3D 1 << 17, VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE =3D 1 << 18, + VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT =3D 1 << 19, } virConnectListAllStoragePoolsFlags; =20 int virConnectListAllStoragePools(virConnectPtr conn, diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index 338e70244d..f399ac6192 100644 --- a/src/conf/storage_conf.h +++ b/src/conf/storage_conf.h @@ -484,7 +484,8 @@ VIR_ENUM_DECL(virStoragePartedFs); VIR_CONNECT_LIST_STORAGE_POOLS_SHEEPDOG | \ VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER | \ VIR_CONNECT_LIST_STORAGE_POOLS_ZFS | \ - VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE) + VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE | \ + VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT) =20 #define VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ALL \ (VIR_CONNECT_LIST_STORAGE_POOLS_FILTERS_ACTIVE | \ diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 31b5af8e9e..0ac128c4bc 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -1967,7 +1967,9 @@ virStoragePoolObjMatch(virStoragePoolObjPtr obj, (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_ZFS) && (obj->def->type =3D=3D VIR_STORAGE_POOL_ZFS)) || (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE) && - (obj->def->type =3D=3D VIR_STORAGE_POOL_VSTORAGE)))) + (obj->def->type =3D=3D VIR_STORAGE_POOL_VSTORAGE)) || + (MATCH(VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT) && + (obj->def->type =3D=3D VIR_STORAGE_POOL_ISCSI_DIRECT)))) return false; } =20 diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index 3bd61dc986..24e28083ed 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -93,6 +93,7 @@ virStoragePoolGetConnect(virStoragePoolPtr pool) * VIR_CONNECT_LIST_STORAGE_POOLS_MPATH * VIR_CONNECT_LIST_STORAGE_POOLS_RBD * VIR_CONNECT_LIST_STORAGE_POOLS_SHEEPDOG + * VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT * * Returns the number of storage pools found or -1 and sets @pools to * NULL in case of error. On success, the array stored into @pools is diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index c56ab2d90a..510d41b508 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -1205,7 +1205,7 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd ATTRIB= UTE_UNUSED) flags |=3D VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI; break; case VIR_STORAGE_POOL_ISCSI_DIRECT: - flags |=3D VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI; + flags |=3D VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT; break; case VIR_STORAGE_POOL_SCSI: flags |=3D VIR_CONNECT_LIST_STORAGE_POOLS_SCSI; diff --git a/tools/virsh.pod b/tools/virsh.pod index dbcac24292..62ffd43ba9 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4093,7 +4093,7 @@ I<--uuid> and I<--name>. You may also want to list pools with specified types using I, the pool types must be separated by comma, e.g. --type dir,disk. The valid pool types include 'dir', 'fs', 'netfs', 'logical', 'disk', 'iscsi', 'scsi', -'mpath', 'rbd', 'sheepdog' and 'gluster'. +'mpath', 'rbd', 'sheepdog', 'gluster', 'iscsi-direct'. =20 The I<--details> option instructs virsh to additionally display pool persistence and capacity related information where available. --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed Apr 24 07:34:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562829838; cv=none; d=zoho.com; s=zohoarc; b=EB7HjJw7JCPavTLK/iOaRfCGDMBTbNsllM3RDlvOeXNoG0p581gWwuUmyzQPfzYMnj4UQBx1+B/iEYip/eMX+Gnd8SlDp2+VKmoHT9fXj88zi2wzUkjnwoszAMPuhxwowrSaSrjVz62vvQEmjcSN01aSe8c4IgLWTKBEVDQd0F4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562829838; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Ud2oPyX2AnGdNhf7bYKO/gQH8QnbCo57kp6NL51exVI=; b=GGIYdz5jtdruWJCbaN7T2n43sabqWOG0cSQSopjYDbleTvuE/Nit3MbWEY7N+JwMKluVGk1UKVx1YKDTzbAJoYe2iP73DBeCPnL8N4nU3GR/frMAQYPCG7frj74sbFwiPhhMEztpg87Dz+5CkSGp0tLxhTS1KDbUdMMhHidsTyI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1562829838425552.5630011278968; Thu, 11 Jul 2019 00:23:58 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CCF5D85539; Thu, 11 Jul 2019 07:23:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A37E95C8BD; Thu, 11 Jul 2019 07:23:56 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 61CDE18184B6; Thu, 11 Jul 2019 07:23:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6B7NY9e012263 for ; Thu, 11 Jul 2019 03:23:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2DCAA6014E; Thu, 11 Jul 2019 07:23:34 +0000 (UTC) Received: from hansolo.nay.redhat.com (unknown [10.66.4.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 20E9060141; Thu, 11 Jul 2019 07:23:31 +0000 (UTC) From: Han Han To: libvir-list@redhat.com Date: Thu, 11 Jul 2019 15:23:06 +0800 Message-Id: <20190711072307.14686-3-hhan@redhat.com> In-Reply-To: <20190711072307.14686-1-hhan@redhat.com> References: <20190711072307.14686-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH v2 2/3] storage: Add missing pool type flags in comment X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 11 Jul 2019 07:23:57 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: Han Han --- src/libvirt-storage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index 24e28083ed..8d1effe33c 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -94,6 +94,9 @@ virStoragePoolGetConnect(virStoragePoolPtr pool) * VIR_CONNECT_LIST_STORAGE_POOLS_RBD * VIR_CONNECT_LIST_STORAGE_POOLS_SHEEPDOG * VIR_CONNECT_LIST_STORAGE_POOLS_ISCSI_DIRECT + * VIR_CONNECT_LIST_STORAGE_POOLS_GLUSTER + * VIR_CONNECT_LIST_STORAGE_POOLS_VSTORAGE + * VIR_CONNECT_LIST_STORAGE_POOLS_ZFS * * Returns the number of storage pools found or -1 and sets @pools to * NULL in case of error. On success, the array stored into @pools is --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Wed Apr 24 07:34:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562829823; cv=none; d=zoho.com; s=zohoarc; b=mwm4VnaKvUJSyC3uchztXUvs7ywxJRz76/hVNh4MorVnwA2EiHcaHf8oPII6uqG2fdMr7gqI2cynVGQkmLrMr7daoxT31O2H8ni+5RFYtbju/RxMYH+T1wKRqKpSdSKWsHJaHZJZcnVvHKbkqgB6owqOJMZiuyw/68FNyneijDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562829823; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=5j8MC9aZeatsOigoHUYGcbKprqWHmWvTYOmzbnOEDNQ=; b=UA1Dsc9+4EBGEQToQZjlpJpAhVb1owVsaWOA7bI/JDPd7pkKiM8Rq3/k+Sj4EHqXExs/QUR1pHF9uE5LKbhN4eGMpZDLuvdTAGo1PvNyi0wyt2bihuzRT7Lqot+btzqYoK/VWh81FzIO29Ho2fswaCxdulqfB/G61/ztkrYvbgE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1562829823221907.6744363274647; Thu, 11 Jul 2019 00:23:43 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 317CA8552A; Thu, 11 Jul 2019 07:23:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EB79C60A97; Thu, 11 Jul 2019 07:23:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 939BD41F66; Thu, 11 Jul 2019 07:23:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6B7NYMl012271 for ; Thu, 11 Jul 2019 03:23:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id BCA8B60141; Thu, 11 Jul 2019 07:23:34 +0000 (UTC) Received: from hansolo.nay.redhat.com (unknown [10.66.4.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF3A16014C; Thu, 11 Jul 2019 07:23:33 +0000 (UTC) From: Han Han To: libvir-list@redhat.com Date: Thu, 11 Jul 2019 15:23:07 +0800 Message-Id: <20190711072307.14686-4-hhan@redhat.com> In-Reply-To: <20190711072307.14686-1-hhan@redhat.com> References: <20190711072307.14686-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Han Han Subject: [libvirt] [PATCH v2 3/3] virsh.pod: Add zfs and vstorage pool types X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 11 Jul 2019 07:23:37 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: Han Han --- tools/virsh.pod | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 62ffd43ba9..e8b63fdab2 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -4093,7 +4093,7 @@ I<--uuid> and I<--name>. You may also want to list pools with specified types using I, the pool types must be separated by comma, e.g. --type dir,disk. The valid pool types include 'dir', 'fs', 'netfs', 'logical', 'disk', 'iscsi', 'scsi', -'mpath', 'rbd', 'sheepdog', 'gluster', 'iscsi-direct'. +'mpath', 'rbd', 'sheepdog', 'gluster', 'iscsi-direct', 'zfs' and 'vstorage= '. =20 The I<--details> option instructs virsh to additionally display pool persistence and capacity related information where available. --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list