From nobody Mon Feb 9 02:51:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562694430; cv=none; d=zoho.com; s=zohoarc; b=ByRYLDyTgEdJtz6fuKGqTS7cdgMZukH1u9ImU4BxmuDHEVEyDAXjxhyRySRxbtn1N8calenSUsypT1Tny0N4KKFjOGCUdNsVoDCEJeBlQUKz3rsgltV8kJuIhxize1ViFjW7GKg31XzAwd5qRcDOwoypKPkborNK1cQmnCJ9Ry0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562694430; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=v3uWo5qPZdljHOik0NnZgCdn127TJMx46kyUI0W170s=; b=F64mzQ13zrKyfnjXvSBpdPXMXrJMV5buLf0XS2iZQcHnxDUBJ2taCPz7gGfCOONzby37M5X2Hheln/d7VVT/Pf3pQpmyk9CoJ/wCLdCkOy+r8zaxpxvOo0bjzPVNWlq+i5PtcdRHsi3Fa7K/TfMnb3V+03PitjtOxPvhNPXZdmo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1562694430900865.1558739403729; Tue, 9 Jul 2019 10:47:10 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 38DE03001C93; Tue, 9 Jul 2019 17:47:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0D5985C8AD; Tue, 9 Jul 2019 17:47:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BE0F4206DB; Tue, 9 Jul 2019 17:47:08 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x69HkhZc031158 for ; Tue, 9 Jul 2019 13:46:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 554961001E65; Tue, 9 Jul 2019 17:46:43 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED8911001E63; Tue, 9 Jul 2019 17:46:42 +0000 (UTC) From: Eric Blake To: libvir-list@redhat.com Date: Tue, 9 Jul 2019 12:46:33 -0500 Message-Id: <20190709174638.17164-5-eblake@redhat.com> In-Reply-To: <20190709174638.17164-1-eblake@redhat.com> References: <20190709174638.17164-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: pkrempa@redhat.com Subject: [libvirt] [PATCH v2 4/9] bhyve: Ignore no-op flag during virDomainUndefine X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 09 Jul 2019 17:47:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op, and in line with the recent doc tweak in commit c049f022. Signed-off-by: Eric Blake --- src/bhyve/bhyve_driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 4ce9ef0b95..84720e89e7 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -584,7 +584,11 @@ bhyveDomainUndefineFlags(virDomainPtr domain, unsigned= int flags) virDomainObjPtr vm; int ret =3D -1; - virCheckFlags(0, -1); + /* No managed save, so we explicitly reject + * VIR_DOMAIN_UNDEFINE_MANAGED_SAVE. No snapshot metadata for + * bhyve, so we can trivially ignore that flag. */ + virCheckFlags(VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, -1); + if (!(vm =3D bhyveDomObjFromDomain(domain))) goto cleanup; --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list