From nobody Mon Feb 9 14:14:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562694448; cv=none; d=zoho.com; s=zohoarc; b=C4YFaJNB6M09Sl0BxIlzXLZKPfvoqulLdP0khjAvAfMyW7smfhsiHxoVvtGznkaBdJYdd2XmeHHseefsX+7Una2x8RRjyjef+qQ8AD6OVXXYjZo33e3rshgFbqM4VKUMgwpO985Onj1YaoRPWjjdume3XFlP8p4bUdM7x70cwUg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562694448; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=DX/7H9EM8UbzePpiANmuj/4Wxsc+Kb8JaKQ7w1JVko8=; b=kvB0wMJL4ogZVhd3+g5ei63Lzk5aCCu+9zOooOPTtFNud3XbdC+QMf5nV8teF2dchi3AprFke/U5Xt7A2CKhvqpm1Nmc4NqqvXNeobawRdd6u49XSiUOOgO43is6BSqVXOUavo/OXU+DbeuqNrWhC1BxP38hO1ko/sYhFgl86jI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 15626944489531016.6632295196903; Tue, 9 Jul 2019 10:47:28 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8471FF9E84; Tue, 9 Jul 2019 17:47:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 593D65CC16; Tue, 9 Jul 2019 17:47:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 02608206D9; Tue, 9 Jul 2019 17:47:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x69HkjwQ031193 for ; Tue, 9 Jul 2019 13:46:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id F021E1001B29; Tue, 9 Jul 2019 17:46:45 +0000 (UTC) Received: from blue.redhat.com (ovpn-116-78.phx2.redhat.com [10.3.116.78]) by smtp.corp.redhat.com (Postfix) with ESMTP id 92F3A1001B11; Tue, 9 Jul 2019 17:46:45 +0000 (UTC) From: Eric Blake To: libvir-list@redhat.com Date: Tue, 9 Jul 2019 12:46:38 -0500 Message-Id: <20190709174638.17164-10-eblake@redhat.com> In-Reply-To: <20190709174638.17164-1-eblake@redhat.com> References: <20190709174638.17164-1-eblake@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: pkrempa@redhat.com Subject: [libvirt] [PATCH v2 9/9] xenapi: Ignore no-op flag during virDomainUndefine X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 09 Jul 2019 17:47:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Copy what esx does in ignoring the SNAPSHOTS_METADATA flag as a no-op, and in line with the recent doc tweak in commit c049f022. Signed-off-by: Eric Blake --- src/xenapi/xenapi_driver.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 026acef680..2cc6dbd22d 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -1791,7 +1791,11 @@ xenapiDomainUndefineFlags(virDomainPtr dom, unsigned= int flags) struct xen_vm_set *vms; xen_vm vm; xen_session *session =3D ((struct _xenapiPrivate *)(dom->conn->private= Data))->session; - virCheckFlags(0, -1); + + /* No managed save, so we explicitly reject + * VIR_DOMAIN_UNDEFINE_MANAGED_SAVE. No snapshot metadata for + * xenapi, so we can trivially ignore that flag. */ + virCheckFlags(VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, -1); if (xen_vm_get_by_name_label(session, &vms, dom->name) && vms->size > = 0) { if (vms->size !=3D 1) { --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list