[libvirt] [jenkins-ci PATCH] guests: Always install the freshest point release

Andrea Bolognani posted 1 patch 13 weeks ago
Failed in applying to current master (apply log)
guests/host_vars/libvirt-debian-10/install.yml | 2 +-
guests/host_vars/libvirt-debian-9/install.yml  | 2 +-
guests/host_vars/libvirt-ubuntu-16/install.yml | 2 +-
guests/host_vars/libvirt-ubuntu-18/install.yml | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

[libvirt] [jenkins-ci PATCH] guests: Always install the freshest point release

Posted by Andrea Bolognani 13 weeks ago
Sometimes the original URL might even stop working, as is the
case for Ubuntu 16.04 this very moment. We want the lastest
point release anyway.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/host_vars/libvirt-debian-10/install.yml | 2 +-
 guests/host_vars/libvirt-debian-9/install.yml  | 2 +-
 guests/host_vars/libvirt-ubuntu-16/install.yml | 2 +-
 guests/host_vars/libvirt-ubuntu-18/install.yml | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/guests/host_vars/libvirt-debian-10/install.yml b/guests/host_vars/libvirt-debian-10/install.yml
index 0a30571..d6452b6 100644
--- a/guests/host_vars/libvirt-debian-10/install.yml
+++ b/guests/host_vars/libvirt-debian-10/install.yml
@@ -1,2 +1,2 @@
 ---
-install_url: http://deb.debian.org/debian/dists/buster/main/installer-amd64/
+install_url: http://deb.debian.org/debian/dists/buster-updates/main/installer-amd64/
diff --git a/guests/host_vars/libvirt-debian-9/install.yml b/guests/host_vars/libvirt-debian-9/install.yml
index 7641753..a8c5d25 100644
--- a/guests/host_vars/libvirt-debian-9/install.yml
+++ b/guests/host_vars/libvirt-debian-9/install.yml
@@ -1,2 +1,2 @@
 ---
-install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
+install_url: http://deb.debian.org/debian/dists/stretch-updates/main/installer-amd64/
diff --git a/guests/host_vars/libvirt-ubuntu-16/install.yml b/guests/host_vars/libvirt-ubuntu-16/install.yml
index d8ce841..c3edf40 100644
--- a/guests/host_vars/libvirt-ubuntu-16/install.yml
+++ b/guests/host_vars/libvirt-ubuntu-16/install.yml
@@ -1,2 +1,2 @@
 ---
-install_url: http://archive.ubuntu.com/ubuntu/dists/xenial/main/installer-amd64/
+install_url: http://archive.ubuntu.com/ubuntu/dists/xenial-updates/main/installer-amd64/
diff --git a/guests/host_vars/libvirt-ubuntu-18/install.yml b/guests/host_vars/libvirt-ubuntu-18/install.yml
index 544b3f2..f8a18f6 100644
--- a/guests/host_vars/libvirt-ubuntu-18/install.yml
+++ b/guests/host_vars/libvirt-ubuntu-18/install.yml
@@ -1,2 +1,2 @@
 ---
-install_url: http://archive.ubuntu.com/ubuntu/dists/bionic/main/installer-amd64/
+install_url: http://archive.ubuntu.com/ubuntu/dists/bionic-updates/main/installer-amd64/
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Always install the freshest point release

Posted by Erik Skultety 13 weeks ago
On Tue, Jul 09, 2019 at 06:15:39PM +0200, Andrea Bolognani wrote:
> Sometimes the original URL might even stop working, as is the
> case for Ubuntu 16.04 this very moment. We want the lastest
> point release anyway.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/host_vars/libvirt-debian-10/install.yml | 2 +-
>  guests/host_vars/libvirt-debian-9/install.yml  | 2 +-
>  guests/host_vars/libvirt-ubuntu-16/install.yml | 2 +-
>  guests/host_vars/libvirt-ubuntu-18/install.yml | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/guests/host_vars/libvirt-debian-10/install.yml b/guests/host_vars/libvirt-debian-10/install.yml
> index 0a30571..d6452b6 100644
> --- a/guests/host_vars/libvirt-debian-10/install.yml
> +++ b/guests/host_vars/libvirt-debian-10/install.yml
> @@ -1,2 +1,2 @@
>  ---
> -install_url: http://deb.debian.org/debian/dists/buster/main/installer-amd64/
> +install_url: http://deb.debian.org/debian/dists/buster-updates/main/installer-amd64/
> diff --git a/guests/host_vars/libvirt-debian-9/install.yml b/guests/host_vars/libvirt-debian-9/install.yml
> index 7641753..a8c5d25 100644
> --- a/guests/host_vars/libvirt-debian-9/install.yml
> +++ b/guests/host_vars/libvirt-debian-9/install.yml
> @@ -1,2 +1,2 @@
>  ---
> -install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
> +install_url: http://deb.debian.org/debian/dists/stretch-updates/main/installer-amd64/

These 2 URLs return 404 because /installer-amd64/ directory doesn't exist.

Erik

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Always install the freshest point release

Posted by Andrea Bolognani 13 weeks ago
On Tue, 2019-07-09 at 18:48 +0200, Erik Skultety wrote:
> On Tue, Jul 09, 2019 at 06:15:39PM +0200, Andrea Bolognani wrote:
> > diff --git a/guests/host_vars/libvirt-debian-10/install.yml b/guests/host_vars/libvirt-debian-10/install.yml
> > index 0a30571..d6452b6 100644
> > --- a/guests/host_vars/libvirt-debian-10/install.yml
> > +++ b/guests/host_vars/libvirt-debian-10/install.yml
> > @@ -1,2 +1,2 @@
> >  ---
> > -install_url: http://deb.debian.org/debian/dists/buster/main/installer-amd64/
> > +install_url: http://deb.debian.org/debian/dists/buster-updates/main/installer-amd64/
> > diff --git a/guests/host_vars/libvirt-debian-9/install.yml b/guests/host_vars/libvirt-debian-9/install.yml
> > index 7641753..a8c5d25 100644
> > --- a/guests/host_vars/libvirt-debian-9/install.yml
> > +++ b/guests/host_vars/libvirt-debian-9/install.yml
> > @@ -1,2 +1,2 @@
> >  ---
> > -install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
> > +install_url: http://deb.debian.org/debian/dists/stretch-updates/main/installer-amd64/
> 
> These 2 URLs return 404 because /installer-amd64/ directory doesn't exist.

Good catch. Things might differ between Debian and Ubuntu on this
front - I'll admit I only tested Ubuntu 16.04 before sending the
patch. I'll look into it further and get back to you.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Always install the freshest point release

Posted by Andrea Bolognani 13 weeks ago
On Wed, 2019-07-10 at 09:42 +0200, Andrea Bolognani wrote:
> On Tue, 2019-07-09 at 18:48 +0200, Erik Skultety wrote:
> > On Tue, Jul 09, 2019 at 06:15:39PM +0200, Andrea Bolognani wrote:
> > > diff --git a/guests/host_vars/libvirt-debian-10/install.yml b/guests/host_vars/libvirt-debian-10/install.yml
> > > index 0a30571..d6452b6 100644
> > > --- a/guests/host_vars/libvirt-debian-10/install.yml
> > > +++ b/guests/host_vars/libvirt-debian-10/install.yml
> > > @@ -1,2 +1,2 @@
> > >  ---
> > > -install_url: http://deb.debian.org/debian/dists/buster/main/installer-amd64/
> > > +install_url: http://deb.debian.org/debian/dists/buster-updates/main/installer-amd64/
> > > diff --git a/guests/host_vars/libvirt-debian-9/install.yml b/guests/host_vars/libvirt-debian-9/install.yml
> > > index 7641753..a8c5d25 100644
> > > --- a/guests/host_vars/libvirt-debian-9/install.yml
> > > +++ b/guests/host_vars/libvirt-debian-9/install.yml
> > > @@ -1,2 +1,2 @@
> > >  ---
> > > -install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
> > > +install_url: http://deb.debian.org/debian/dists/stretch-updates/main/installer-amd64/
> > 
> > These 2 URLs return 404 because /installer-amd64/ directory doesn't exist.
> 
> Good catch. Things might differ between Debian and Ubuntu on this
> front - I'll admit I only tested Ubuntu 16.04 before sending the
> patch. I'll look into it further and get back to you.

Yeah, so it looks like Ubuntu folks create updated versions of their
installer from time to time (each point release?), and make it
available under ${dist}-updates, whereas Debian folks either doen't
touch the installer after the initial release or substitute it in
place.

The takeaway is that these two hunks are incorrect, but we want the
remaining ones. Does that sound good to you?

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH] guests: Always install the freshest point release

Posted by Erik Skultety 13 weeks ago
On Wed, Jul 10, 2019 at 01:53:02PM +0200, Andrea Bolognani wrote:
> On Wed, 2019-07-10 at 09:42 +0200, Andrea Bolognani wrote:
> > On Tue, 2019-07-09 at 18:48 +0200, Erik Skultety wrote:
> > > On Tue, Jul 09, 2019 at 06:15:39PM +0200, Andrea Bolognani wrote:
> > > > diff --git a/guests/host_vars/libvirt-debian-10/install.yml b/guests/host_vars/libvirt-debian-10/install.yml
> > > > index 0a30571..d6452b6 100644
> > > > --- a/guests/host_vars/libvirt-debian-10/install.yml
> > > > +++ b/guests/host_vars/libvirt-debian-10/install.yml
> > > > @@ -1,2 +1,2 @@
> > > >  ---
> > > > -install_url: http://deb.debian.org/debian/dists/buster/main/installer-amd64/
> > > > +install_url: http://deb.debian.org/debian/dists/buster-updates/main/installer-amd64/
> > > > diff --git a/guests/host_vars/libvirt-debian-9/install.yml b/guests/host_vars/libvirt-debian-9/install.yml
> > > > index 7641753..a8c5d25 100644
> > > > --- a/guests/host_vars/libvirt-debian-9/install.yml
> > > > +++ b/guests/host_vars/libvirt-debian-9/install.yml
> > > > @@ -1,2 +1,2 @@
> > > >  ---
> > > > -install_url: http://deb.debian.org/debian/dists/stretch/main/installer-amd64/
> > > > +install_url: http://deb.debian.org/debian/dists/stretch-updates/main/installer-amd64/
> > >
> > > These 2 URLs return 404 because /installer-amd64/ directory doesn't exist.
> >
> > Good catch. Things might differ between Debian and Ubuntu on this
> > front - I'll admit I only tested Ubuntu 16.04 before sending the
> > patch. I'll look into it further and get back to you.
>
> Yeah, so it looks like Ubuntu folks create updated versions of their
> installer from time to time (each point release?), and make it
> available under ${dist}-updates, whereas Debian folks either doen't
> touch the installer after the initial release or substitute it in
> place.
>
> The takeaway is that these two hunks are incorrect, but we want the
> remaining ones. Does that sound good to you?

Yes it does.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list