From nobody Mon Feb 9 23:38:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562569792; cv=none; d=zoho.com; s=zohoarc; b=G5wWbS7lGlCnF/YGags5q5BHmC+IhqV2K+PsNOaAYnqP9jC3/2XwWGxWle86pxewN2JZiXa+maHYOWh5zwoT8YhQ8ikDxiVpI1HC5QlEJW1P5Df9pHWenfqQM7rpG173KFIGABHVlNNKKnl9budAgbfcZaNLWQi0et1DF24Sqcw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562569792; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=WqDTIGj5QSBRzDVlxOLSyDywCCIN0GIzNYnz4VT/8fc=; b=UGXFVMh/IgOuEex/ce5PHKmrApIFolFJrcyZ+SbchMY6IcSkto4g+EizEnAU9fLN33o/WoEiDK91N6/wDw/ZEURBNQxV2HOgI7cvs7CMDGayyzUcWMa1EulJp2vx81AktQTNbgnoEw7CrcBvu05QjhtQdnqYgvo4UtCZ29aj9yA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1562569792031146.74255711673197; Mon, 8 Jul 2019 00:09:52 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7077D5946F; Mon, 8 Jul 2019 07:09:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CEB053B01; Mon, 8 Jul 2019 07:09:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0E514206D5; Mon, 8 Jul 2019 07:09:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x6879mmu006807 for ; Mon, 8 Jul 2019 03:09:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id D1FCA19C77; Mon, 8 Jul 2019 07:09:48 +0000 (UTC) Received: from localhost (ovpn-112-17.ams2.redhat.com [10.36.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id EA26E1972B; Mon, 8 Jul 2019 07:09:40 +0000 (UTC) From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Date: Mon, 8 Jul 2019 11:07:34 +0400 Message-Id: <20190708070747.1962-11-marcandre.lureau@redhat.com> In-Reply-To: <20190708070747.1962-1-marcandre.lureau@redhat.com> References: <20190708070747.1962-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [libvirt] [PATCH 10/23] qemu: add a DBus daemon helper unit X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 08 Jul 2019 07:09:50 +0000 (UTC) From: Marc-Andr=C3=A9 Lureau Add a unit to start & stop a private dbus-daemon. The daemon is meant to be started on demand, and associated with a QEMU process. It is stopped when the QEMU process is stopped. Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/qemu/Makefile.inc.am | 4 + src/qemu/qemu_dbus.c | 370 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_dbus.h | 40 +++++ src/qemu/qemu_domain.c | 10 ++ src/qemu/qemu_domain.h | 5 + src/qemu/qemu_process.c | 6 + tests/Makefile.am | 1 + 7 files changed, 436 insertions(+) create mode 100644 src/qemu/qemu_dbus.c create mode 100644 src/qemu/qemu_dbus.h diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 254ba07dc0..248f3970c9 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -58,6 +58,8 @@ QEMU_DRIVER_SOURCES =3D \ qemu/qemu_qapi.h \ qemu/qemu_tpm.c \ qemu/qemu_tpm.h \ + qemu/qemu_dbus.c \ + qemu/qemu_dbus.h \ $(NULL) =20 =20 @@ -81,6 +83,7 @@ libvirt_driver_qemu_impl_la_CFLAGS =3D \ $(LIBNL_CFLAGS) \ $(SELINUX_CFLAGS) \ $(XDR_CFLAGS) \ + $(DBUS_CFLAGS) \ -I$(srcdir)/access \ -I$(srcdir)/conf \ -I$(srcdir)/secret \ @@ -92,6 +95,7 @@ libvirt_driver_qemu_impl_la_LIBADD =3D \ $(GNUTLS_LIBS) \ $(LIBNL_LIBS) \ $(SELINUX_LIBS) \ + $(DBUS_LIBS) \ $(LIBXML_LIBS) \ $(NULL) libvirt_driver_qemu_impl_la_SOURCES =3D $(QEMU_DRIVER_SOURCES) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c new file mode 100644 index 0000000000..bf24c85910 --- /dev/null +++ b/src/qemu/qemu_dbus.c @@ -0,0 +1,370 @@ +/* + * qemu_dbus.c: QEMU dbus daemon + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * . + */ + +#include + +#include "qemu_extdevice.h" +#include "qemu_dbus.h" +#include "qemu_security.h" + +#include "viralloc.h" +#include "virlog.h" +#include "virstring.h" +#include "virtime.h" +#include "virpidfile.h" + +#define VIR_FROM_THIS VIR_FROM_QEMU + +VIR_LOG_INIT("qemu.dbus"); + + +int +qemuDBusPrepareHost(virQEMUDriverPtr driver) +{ + virQEMUDriverConfigPtr cfg =3D virQEMUDriverGetConfig(driver); + + return virDirCreate(cfg->dbusStateDir, 0770, cfg->user, cfg->group, + VIR_DIR_CREATE_ALLOW_EXIST); +} + + +static char * +qemuDBusCreatePidFilename(const char *stateDir, + const char *shortName) +{ + VIR_AUTOFREE(char *) name =3D NULL; + + if (virAsprintf(&name, "%s-dbus", shortName) < 0) + return NULL; + + return virPidFileBuildPath(stateDir, name); +} + + +static char * +qemuDBusCreateFilename(const char *stateDir, + const char *shortName, + const char *ext) +{ + VIR_AUTOFREE(char *) name =3D NULL; + + if (virAsprintf(&name, "%s-dbus", shortName) < 0) + return NULL; + + return virFileBuildPath(stateDir, name, ext); +} + + +static char * +qemuDBusCreateSocketPath(virQEMUDriverConfigPtr cfg, + const char *shortName) +{ + return qemuDBusCreateFilename(cfg->dbusStateDir, shortName, ".sock"); +} + + +char * +qemuDBusGetAddress(virQEMUDriverPtr driver, + virDomainObjPtr vm) +{ + virQEMUDriverConfigPtr cfg =3D virQEMUDriverGetConfig(driver); + VIR_AUTOFREE(char *) shortName =3D virDomainDefGetShortName(vm->def); + VIR_AUTOFREE(char *) path =3D qemuDBusCreateSocketPath(cfg, shortName); + char *ret; + + ignore_value(virAsprintf(&ret, "unix:path=3D%s", path)); + + return ret; +} + + +static int +qemuDBusGetPid(const char *binPath, + const char *stateDir, + const char *shortName, + pid_t *pid) +{ + VIR_AUTOFREE(char *) pidfile =3D qemuDBusCreatePidFilename(stateDir, s= hortName); + + if (!pidfile) + return -ENOMEM; + + return virPidFileReadPathIfAlive(pidfile, pid, binPath); +} + + +static int +qemuDBusWriteConfig(const char *filename, const char *path) +{ + virBuffer buf =3D VIR_BUFFER_INITIALIZER; + VIR_AUTOFREE(char *) config =3D NULL; + + virBufferAddLit(&buf, "\n"); + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); + + virBufferAddLit(&buf, "org.libvirt.qemu\n"); + + /* This may become useful: */ + /* virBufferAddLit(&buf, "" DATADIR "/dbus-1/libvirt-qemu-= services\n"); */ + + virBufferAsprintf(&buf, "unix:path=3D%s\n", path); + + virBufferAddLit(&buf, "EXTERNAL\n"); + + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, 2); + virBufferAddLit(&buf, "\n"); + virBufferAddLit(&buf, "\n"); + virBufferAddLit(&buf, "\n"); + virBufferAddLit(&buf, "\n"); + virBufferAddLit(&buf, "\n"); + virBufferAddLit(&buf, "\n"); + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); + + virBufferAddLit(&buf, "contexts/dbus_contexts\n"); + + virBufferAdjustIndent(&buf, -2); + virBufferAddLit(&buf, "\n"); + + if (virBufferCheckError(&buf) < 0) + return -1; + + config =3D virBufferContentAndReset(&buf); + + return virFileWriteStr(filename, config, 0600); +} + + +void +qemuDBusStop(virQEMUDriverPtr driver, + virDomainObjPtr vm) +{ + qemuDomainObjPrivatePtr priv =3D vm->privateData; + virQEMUDriverConfigPtr cfg =3D virQEMUDriverGetConfig(driver); + VIR_AUTOFREE(char *) shortName =3D NULL; + VIR_AUTOFREE(char *) pidfile =3D NULL; + VIR_AUTOFREE(char *) configfile =3D NULL; + virErrorPtr orig_err; + int rc; + pid_t pid; + + shortName =3D virDomainDefGetShortName(vm->def); + pidfile =3D qemuDBusCreatePidFilename(cfg->dbusStateDir, shortName); + configfile =3D qemuDBusCreateFilename(cfg->dbusStateDir, shortName, ".= conf"); + + if (!shortName || !pidfile || !configfile) + return; + + rc =3D qemuDBusGetPid(cfg->dbusDaemonName, cfg->dbusStateDir, shortNam= e, &pid); + if (rc =3D=3D 0 && pid !=3D (pid_t)-1) { + char ebuf[1024]; + + VIR_DEBUG("Killing dbus-daemon process %lld", (long long)pid); + if (virProcessKill(pid, SIGTERM) < 0 && errno !=3D ESRCH) + VIR_ERROR(_("Failed to kill process %lld: %s"), + (long long)pid, + virStrerror(errno, ebuf, sizeof(ebuf))); + } + + virErrorPreserveLast(&orig_err); + if (virPidFileForceCleanupPath(pidfile) < 0) { + VIR_WARN("Unable to kill dbus-daemon process"); + } else { + if (unlink(pidfile) < 0 && + errno !=3D ENOENT) { + virReportSystemError(errno, + _("Unable to remove stale pidfile %s"), + pidfile); + } + } + if (unlink(configfile) < 0 && + errno !=3D ENOENT) { + virReportSystemError(errno, + _("Unable to remove stale configfile %s"), + pidfile); + } + virErrorRestore(&orig_err); + + VIR_FREE(pidfile); + + priv->dbusDaemonRunning =3D false; +} + + +int +qemuDBusStart(virQEMUDriverPtr driver, + virDomainObjPtr vm) +{ + qemuDomainObjPrivatePtr priv =3D vm->privateData; + virQEMUDriverConfigPtr cfg =3D virQEMUDriverGetConfig(driver); + VIR_AUTOPTR(virCommand) cmd =3D NULL; + VIR_AUTOFREE(char *) shortName =3D NULL; + VIR_AUTOFREE(char *) pidfile =3D NULL; + VIR_AUTOFREE(char *) configfile =3D NULL; + VIR_AUTOFREE(char *) sockpath =3D NULL; + virTimeBackOffVar timebackoff; + const unsigned long long timeout =3D 500 * 1000; /* ms */ + int errfd =3D -1; + int cmdret =3D 0; + int exitstatus =3D 0; + + if (priv->dbusDaemonRunning) + return 0; + + /* cleanup */ + qemuDBusStop(driver, vm); + + cmd =3D virCommandNew(cfg->dbusDaemonName); + shortName =3D virDomainDefGetShortName(vm->def); + pidfile =3D qemuDBusCreatePidFilename(cfg->dbusStateDir, shortName); + configfile =3D qemuDBusCreateFilename(cfg->dbusStateDir, shortName, ".= conf"); + sockpath =3D qemuDBusCreateSocketPath(cfg, shortName); + + if (!cmd || !pidfile || !configfile || !sockpath) + return -1; + + if (qemuDBusWriteConfig(configfile, sockpath) < 0) { + virReportSystemError(errno, _("Failed to write '%s'"), configfile); + return -1; + } + + if (qemuSecurityDomainSetPathLabel(driver, vm, configfile, true) < 0) + return -1; + + virCommandClearCaps(cmd); + virCommandSetPidFile(cmd, pidfile); + virCommandSetErrorFD(cmd, &errfd); + virCommandDaemonize(cmd); + virCommandAddArgFormat(cmd, "--config-file=3D%s", configfile); + + if (qemuExtDeviceLogCommand(driver, vm, cmd, "DBus") < 0) + return -1; + + if (qemuSecurityCommandRun(driver, vm, cmd, + &exitstatus, &cmdret) < 0) + return -1; + + if (cmdret < 0 || exitstatus !=3D 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Could not start 'vhost-user-gpu'. exitstatus: %d= "), + exitstatus); + return -1; + } + + if (virTimeBackOffStart(&timebackoff, 1, timeout) < 0) + return -1; + while (virTimeBackOffWait(&timebackoff)) { + pid_t pid; + + if (qemuDBusGetPid(cfg->dbusDaemonName, cfg->dbusStateDir, shortNa= me, &pid) < 0) + continue; + + if (pid =3D=3D (pid_t)-1) + break; + + if (virFileExists(sockpath)) + break; + } + + if (!virFileExists(sockpath)) { + char errbuf[1024] =3D { 0 }; + + if (saferead(errfd, errbuf, sizeof(errbuf) - 1) < 0) { + virReportSystemError(errno, "%s", _("dbus-daemon died unexpect= edly")); + } else { + virReportError(VIR_ERR_OPERATION_FAILED, + _("dbus-daemon died and reported: %s"), errbuf); + } + + return -1; + } + + if (qemuSecurityDomainSetPathLabel(driver, vm, sockpath, true) < 0) + return -1; + + priv->dbusDaemonRunning =3D true; + + return 0; +} + + +int +qemuDBusSetupCgroup(virQEMUDriverPtr driver, + virDomainDefPtr def, + virCgroupPtr cgroup) +{ + virQEMUDriverConfigPtr cfg =3D virQEMUDriverGetConfig(driver); + VIR_AUTOFREE(char *) shortName =3D virDomainDefGetShortName(def); + pid_t pid; + int rc; + + rc =3D qemuDBusGetPid(cfg->dbusDaemonName, cfg->dbusStateDir, shortNam= e, &pid); + if (rc < 0 || (rc =3D=3D 0 && pid =3D=3D (pid_t)-1)) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Could not get process id of dbus-daemon")); + return -1; + } + + if (virCgroupAddProcess(cgroup, pid) < 0) + return -1; + + return 0; +} + + +int +qemuDBusConnect(virQEMUDriverPtr driver, + virDomainObjPtr vm) +{ + qemuDomainObjPrivatePtr priv =3D vm->privateData; + VIR_AUTOFREE(char *) addr =3D qemuDBusGetAddress(driver, vm); + DBusConnection *conn =3D NULL; + DBusError error; + int ret =3D -1; + + if (!priv->dbusDaemonRunning || priv->dbusConn) + return 0; + + dbus_error_init(&error); + conn =3D dbus_connection_open(addr, &error); + if (!conn) { + virReportError(VIR_ERR_DBUS_SERVICE, _("failed to connect to DBus:= %s"), + error.message ? : _("unknown error")); + goto end; + } + + if (!dbus_bus_register(conn, &error)) { + virReportError(VIR_ERR_DBUS_SERVICE, _("failed to register to DBus= : %s"), + error.message ? : _("unknown error")); + goto end; + } + + priv->dbusConn =3D conn; + conn =3D NULL; + ret =3D 0; + +end: + if (conn) { + dbus_connection_unref(conn); + } + dbus_error_free(&error); + return ret; +} diff --git a/src/qemu/qemu_dbus.h b/src/qemu/qemu_dbus.h new file mode 100644 index 0000000000..8728824bd7 --- /dev/null +++ b/src/qemu/qemu_dbus.h @@ -0,0 +1,40 @@ +/* + * qemu_dbus.h: QEMU dbus daemon + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * . + */ + +#pragma once + +#include "qemu_conf.h" +#include "qemu_domain.h" + +int qemuDBusPrepareHost(virQEMUDriverPtr driver); + +char *qemuDBusGetAddress(virQEMUDriverPtr driver, + virDomainObjPtr vm); + +int qemuDBusConnect(virQEMUDriverPtr driver, + virDomainObjPtr vm); + +int qemuDBusStart(virQEMUDriverPtr driver, + virDomainObjPtr vm); + +void qemuDBusStop(virQEMUDriverPtr driver, + virDomainObjPtr vm); + +int qemuDBusSetupCgroup(virQEMUDriverPtr driver, + virDomainDefPtr def, + virCgroupPtr cgroup); diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6225ac23e2..192aceb605 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2051,6 +2051,11 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivatePt= r priv) =20 qemuDomainObjResetJob(priv); qemuDomainObjResetAsyncJob(priv); + + if (priv->dbusConn) { + dbus_connection_unref(priv->dbusConn); + priv->dbusConn =3D NULL; + } } =20 =20 @@ -2479,6 +2484,9 @@ qemuDomainObjPrivateXMLFormat(virBufferPtr buf, virDomainChrTypeToString(priv->monConfig->type)); } =20 + if (priv->dbusDaemonRunning) + virBufferAddLit(buf, "\n"); + if (priv->namespaces) { ssize_t ns =3D -1; =20 @@ -2910,6 +2918,8 @@ qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, goto error; } =20 + priv->dbusDaemonRunning =3D virXPathBoolean("boolean(./dbusDaemon)", c= txt) > 0; + if ((node =3D virXPathNode("./namespaces", ctxt))) { xmlNodePtr next; =20 diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 3eea8b0f96..9d14163c21 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -39,6 +39,7 @@ #include "logging/log_manager.h" #include "virdomainmomentobjlist.h" #include "virenum.h" +#include "virdbus.h" =20 #define QEMU_DOMAIN_FORMAT_LIVE_FLAGS \ (VIR_DOMAIN_XML_SECURE) @@ -386,6 +387,10 @@ struct _qemuDomainObjPrivate { =20 /* true if global -mem-prealloc appears on cmd line */ bool memPrealloc; + + /* true if dbus-daemon is running */ + bool dbusDaemonRunning; + DBusConnection *dbusConn; }; =20 #define QEMU_DOMAIN_PRIVATE(vm) \ diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 5156b4906c..5e8184b0e2 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -57,6 +57,7 @@ #include "qemu_security.h" #include "qemu_extdevice.h" #include "qemu_firmware.h" +#include "qemu_dbus.h" =20 #include "cpu/cpu.h" #include "cpu/cpu_x86.h" @@ -6452,6 +6453,9 @@ qemuProcessPrepareHost(virQEMUDriverPtr driver, qemuDomainObjPrivatePtr priv =3D vm->privateData; virQEMUDriverConfigPtr cfg =3D virQEMUDriverGetConfig(driver); =20 + if (qemuDBusPrepareHost(driver) < 0) + goto cleanup; + if (qemuPrepareNVRAM(cfg, vm) < 0) goto cleanup; =20 @@ -7399,6 +7403,8 @@ void qemuProcessStop(virQEMUDriverPtr driver, =20 qemuExtDevicesStop(driver, vm); =20 + qemuDBusStop(driver, vm); + vm->def->id =3D -1; =20 /* Stop autodestroy in case guest is restarted */ diff --git a/tests/Makefile.am b/tests/Makefile.am index 115afa1c1a..85d0d8f614 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -42,6 +42,7 @@ AM_CFLAGS =3D \ $(APPARMOR_CFLAGS) \ $(YAJL_CFLAGS) \ $(XDR_CFLAGS) \ + $(DBUS_CFLAGS) \ $(WARN_CFLAGS) =20 AM_LDFLAGS =3D \ --=20 2.22.0.214.g8dca754b1e -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list