The sysvinit script was previously removed in
commit 912fe2df9d8628b2f3d54485f1cb919cb124d07a
Author: Andrea Bolognani <abologna@redhat.com>
Date: Fri Mar 15 16:47:27 2019 +0100
Drop support for "Red Hat" init scripts
A make rule was accidentally left behind.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
src/remote/Makefile.inc.am | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am
index 013cd3e382..43ad53bedb 100644
--- a/src/remote/Makefile.inc.am
+++ b/src/remote/Makefile.inc.am
@@ -296,15 +296,6 @@ INSTALL_DATA_LOCAL += install-sasl
UNINSTALL_LOCAL += uninstall-sasl
endif WITH_SASL
-libvirtd.init: remote/libvirtd.init.in $(top_builddir)/config.status
- $(AM_V_GEN)sed \
- -e 's|[@]localstatedir[@]|$(localstatedir)|g' \
- -e 's|[@]sbindir[@]|$(sbindir)|g' \
- -e 's|[@]sysconfdir[@]|$(sysconfdir)|g' \
- < $< > $@-t && \
- chmod a+x $@-t && \
- mv $@-t $@
-
libvirtd.service: remote/libvirtd.service.in $(top_builddir)/config.status
$(AM_V_GEN)sed \
-e 's|[@]localstatedir[@]|$(localstatedir)|g' \
--
2.21.0
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, 2019-07-03 at 14:14 +0100, Daniel P. Berrangé wrote: > The sysvinit script was previously removed in > > commit 912fe2df9d8628b2f3d54485f1cb919cb124d07a > Author: Andrea Bolognani <abologna@redhat.com> > Date: Fri Mar 15 16:47:27 2019 +0100 > > Drop support for "Red Hat" init scripts > > A make rule was accidentally left behind. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > src/remote/Makefile.inc.am | 9 --------- > 1 file changed, 9 deletions(-) My bad O:-) I think it's unnecessary to include that much information about the original commit, just the (shortened) hash would be enough. Either way, Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Wed, Jul 03, 2019 at 05:14:10PM +0200, Andrea Bolognani wrote: > On Wed, 2019-07-03 at 14:14 +0100, Daniel P. Berrangé wrote: > > The sysvinit script was previously removed in > > > > commit 912fe2df9d8628b2f3d54485f1cb919cb124d07a > > Author: Andrea Bolognani <abologna@redhat.com> > > Date: Fri Mar 15 16:47:27 2019 +0100 > > > > Drop support for "Red Hat" init scripts > > > > A make rule was accidentally left behind. > > > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > > --- > > src/remote/Makefile.inc.am | 9 --------- > > 1 file changed, 9 deletions(-) > > My bad O:-) > > I think it's unnecessary to include that much information about > the original commit, just the (shortened) hash would be enough. I've seen plenty of times when people cut & paste the wrong hash, so it is always worth including down to the summary line. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
© 2016 - 2024 Red Hat, Inc.