From nobody Wed May 8 02:50:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561995794; cv=none; d=zoho.com; s=zohoarc; b=Vn0cZoVzhi+1cXLXLR4fUGwuUqlI4Y2fgw6HYAtOWpQyY1+d0N7Idwmzi+vyCijWu50w4ecFNy4NabirQTx6/unXZr/OHQA4i+VrSqmjuxXj8E8S0WkKumi53/SlyOQjSamde9netMH7D8Zm5F3RTEfkHSP2Ge3StxR3DZ9kE5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561995794; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=Wmx1oKu5KAk5Kv86pxN4Yp5tCx2zsUZhs9t49+3ojAI=; b=Kg3Wk3QYXsDIqmsNnUhzZFLrylbChxrL1C3cYuFusuQ2x1ICLLCKvgvAHl5zCGp7i94oq0tq6ofApmXzlnhCzZtZxn03nQWSPJGdBV0wD1SapO3UbsBXI3YjYw4BHUWwqt0obwmjDFVEjYowtgfypDLDH6PkOu3nS0WXr/LYiyA= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561995794784534.9617569654148; Mon, 1 Jul 2019 08:43:14 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1D573082E72; Mon, 1 Jul 2019 15:42:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D16586085B; Mon, 1 Jul 2019 15:42:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A6D371806B16; Mon, 1 Jul 2019 15:42:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x61Fg9PL018080 for ; Mon, 1 Jul 2019 11:42:09 -0400 Received: by smtp.corp.redhat.com (Postfix) id D6CAE6F940; Mon, 1 Jul 2019 15:42:09 +0000 (UTC) Received: from unknown04D3B0C4CC7D.redhat.com (ovpn-116-56.phx2.redhat.com [10.3.116.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED6756C35B for ; Mon, 1 Jul 2019 15:42:06 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Mon, 1 Jul 2019 11:42:04 -0400 Message-Id: <20190701154204.8107-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] rpc: Fix build error for virNetServerNew ATTRIBUTE_NONNULL values X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Mon, 01 Jul 2019 15:43:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Commit 5a148ce84 altered the virNetServerNew to remove a parameter but neglected to update the ATTRIBUTE_NONNULL's which causes a build failure for when checking is enabled such as when lv_cv_static_analysis is enabled. Signed-off-by: John Ferlan --- Pushing as build breaker/trivial src/rpc/virnetserver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetserver.h b/src/rpc/virnetserver.h index b47b71b4b2..6b2541588c 100644 --- a/src/rpc/virnetserver.h +++ b/src/rpc/virnetserver.h @@ -42,7 +42,7 @@ virNetServerPtr virNetServerNew(const char *name, virNetServerClientPrivPreExecRestart clien= tPrivPreExecRestart, virFreeCallback clientPrivFree, void *clientPrivOpaque) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(11) ATTRIBUTE_NONNULL(13); + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(10) ATTRIBUTE_NONNULL(12); =20 virNetServerPtr virNetServerNewPostExecRestart(virJSONValuePtr object, const char *name, --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list