From nobody Sun Feb 8 01:34:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561564632; cv=none; d=zoho.com; s=zohoarc; b=cc7/Uw5WKg7ZY+IarSRXYK5ZqBui3z+V0WfYZ9+yiGIpm8vw3LGQ4pbyOT+fI74yVOkUA4ZR+Cr5q2YMeGJzgFAYZIAtDHu0RQpG8k5YT8QphnnOTXXLIe3BzsjJyZjMwZ42ULjaNRFJ72PtJVQhS2ts4Ss8nuwCAgK9XJvBi0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561564632; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=q7ao+gxj/LAwigFTsUkRxDLqZLOxOYlAaXV2G2zrEjE=; b=KwW9oYn/lTNqwpmC53V++JL65Vy2LfcUP5dhgVgrKXJ7u4/t2RvFHNS6wYcMUshTrM9sYVGj7M+0hV0y1ud60YI7LX1HYxDm25iNL7Oje4QO4gU5/wVsFozeCzVpwkzvCZtg5hw/WEpghbEkIcQSOn/TrNrffCdQ+4x6O1n/70M= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561564632236662.89088182418; Wed, 26 Jun 2019 08:57:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 022D7C18B2D6; Wed, 26 Jun 2019 15:57:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D086A5D9E1; Wed, 26 Jun 2019 15:56:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 86B3C1806B12; Wed, 26 Jun 2019 15:56:56 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5QFspRN023854 for ; Wed, 26 Jun 2019 11:54:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 017845D71D; Wed, 26 Jun 2019 15:54:51 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.42.22.189]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27D955D71B; Wed, 26 Jun 2019 15:54:49 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 26 Jun 2019 16:54:41 +0100 Message-Id: <20190626155443.7038-3-berrange@redhat.com> In-Reply-To: <20190626155443.7038-1-berrange@redhat.com> References: <20190626155443.7038-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/4] Revert "error: Add VIR_ERR_DEPRECATED error code" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 26 Jun 2019 15:57:11 +0000 (UTC) This reverts commit 226094fbc483128c8888f4171c353aed738b8346. A deprecation is a warning to something that use of a feature is being discouraged. By definition it is not an error condition to continue to use a deprecated feature. A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For features which are entirely absent we already document that the VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish between a feature which never existed and a feature which previously existed and was since removed. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- include/libvirt/virterror.h | 1 - src/util/virerror.c | 4 ---- 2 files changed, 5 deletions(-) diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h index 22bc3c2d27..102a2573bf 100644 --- a/include/libvirt/virterror.h +++ b/include/libvirt/virterror.h @@ -329,7 +329,6 @@ typedef enum { VIR_ERR_INVALID_NETWORK_PORT =3D 105, /* invalid network port object */ VIR_ERR_NETWORK_PORT_EXIST =3D 106, /* the network port already exis= t */ VIR_ERR_NO_NETWORK_PORT =3D 107, /* network port not found */ - VIR_ERR_DEPRECATED =3D 108, /* configuration or operation is= no longer supported */ =20 # ifdef VIR_ENUM_SENTINELS VIR_ERR_NUMBER_LAST diff --git a/src/util/virerror.c b/src/util/virerror.c index 26f14ddd29..dfba8c5712 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -1235,10 +1235,6 @@ const virErrorMsgTuple virErrorMsgStrings[VIR_ERR_NU= MBER_LAST] =3D { [VIR_ERR_NO_NETWORK_PORT] =3D { N_("network port not found"), N_("network port not found: %s") }, - [VIR_ERR_DEPRECATED] =3D { - N_("operation or configuration no longer supported"), - "%s", - }, }; =20 =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list