[libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace

Sergei Turchanov posted 1 patch 4 years, 9 months ago
Failed in applying to current master (apply log)
libvirt-lxc-override.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace
Posted by Sergei Turchanov 4 years, 9 months ago
This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1

fdlist[i] erroneously was replaced by fdlist[1] which caused
lxcOpenNamespace to return a list with identical elements.

Signed-off-by: Sergei Turchanov <turchanov@farpost.com>
---
 libvirt-lxc-override.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c
index 60c2e48..d7af154 100644
--- a/libvirt-lxc-override.c
+++ b/libvirt-lxc-override.c
@@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED,
         goto error;
 
     for (i = 0; i < c_retval; i++)
-        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), error);
+        VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), error);
 
  cleanup:
     VIR_FREE(fdlist);
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH libvirt-python] Fix regression in lxcOpenNamespace
Posted by Ján Tomko 4 years, 9 months ago
On Wed, Jun 26, 2019 at 11:27:45AM +1000, Sergei Turchanov wrote:
>This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1
>
>fdlist[i] erroneously was replaced by fdlist[1] which caused
>lxcOpenNamespace to return a list with identical elements.
>
>Signed-off-by: Sergei Turchanov <turchanov@farpost.com>
>---
> libvirt-lxc-override.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>
and pushed now.

Jano
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list