From nobody Sun May 5 10:03:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561145562; cv=none; d=zoho.com; s=zohoarc; b=eobqmEtkor69Qw8YSXwlFRoFm64vHTf+w8R1Lj+BBy3PEr/6LbOPbN9CCnPkGvimNFZDVOupTS1LtjcZjbWMLxMfy0wTLUXMZAGLmcR+WFNNBbuwPQVkNZa2njlMWmkz9QxVU2YEyq57jw7Zn2dGdGudUG0M2dt6EIFaPLnvsgE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561145562; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=SJ1GDswjtr/kqAfGdUmwPnSgQ32etHP0VRJaOrA0Jpk=; b=dnvb7mg9G4tjc6SsAI0kIj6y/3VqHYKF5lWr2aTmfobJSXR0Yoza0T3RI6ClV/JxL36emG+B1/ePqT/r4ouulGl1JVXi2RA5Bzfv1MQ8W/F8PdxDxmYK9FQ04GtM3HL4c1oQlrwDgSlogDPz619u/V3N7SjWmdCUHqQReN/2d0E= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156114556200637.38614001915357; Fri, 21 Jun 2019 12:32:42 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 42A3CC04AC69; Fri, 21 Jun 2019 19:32:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D16CC19C68; Fri, 21 Jun 2019 19:32:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A15491806B19; Fri, 21 Jun 2019 19:32:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5LJW8SO009348 for ; Fri, 21 Jun 2019 15:32:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0BCC65B689; Fri, 21 Jun 2019 19:32:08 +0000 (UTC) Received: from unknown04D3B0C4CC7D.redhat.com (ovpn-116-57.phx2.redhat.com [10.3.116.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 012325D772 for ; Fri, 21 Jun 2019 19:32:03 +0000 (UTC) From: John Ferlan To: libvir-list@redhat.com Date: Fri, 21 Jun 2019 15:32:01 -0400 Message-Id: <20190621193201.14624-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] qemu: Adjust ATTRIBUTE_NONNULL X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 21 Jun 2019 19:32:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Commit 7bf679ae removed the @json argument from the qemuMonitorOpen prototype; however, it did not update the ATTRIBUTE_NONNULL value which causes a build failure for when checking is enabled such as when lv_cv_static_analysis is enabled. Signed-off-by: John Ferlan --- Pushing under build breaker rule. src/qemu/qemu_monitor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 35e3d28c22..c41428b048 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -343,7 +343,7 @@ qemuMonitorPtr qemuMonitorOpen(virDomainObjPtr vm, unsigned long long timeout, qemuMonitorCallbacksPtr cb, void *opaque) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(6); + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5); qemuMonitorPtr qemuMonitorOpenFD(virDomainObjPtr vm, int sockfd, qemuMonitorCallbacksPtr cb, --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list