From nobody Fri May 3 11:56:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561128213; cv=none; d=zoho.com; s=zohoarc; b=WStlaDKBvS0hI7h7Cb0GMj/YgNTWd3O685B3R6HOfTaxcIYIrxQxAY2fcfS0Zi4YKFrGWuDRJSt3eGSJhTMLxv4jlQwQYY99eWY6aVr/7TGXhIYtJ7sYxrmhu3ykQx0PNK+G6fT6vOxcMlMjp81UtP0Ohy/zMXnIX5AhRDZwQeE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561128213; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=F4b+9smcoaFyGK/bmjjtgFKYhgJjj+PE+qq0rdo8oM4=; b=of9U6lC3V7I9GXzwSNvU4oVUT2Vq9OTgSQ1/tcSHEmdyUm2q3sVZcc2ypkWVkYsQJRmdG1aL7Dm0U7ye790ZLJ/yYMVIBNk+f8GGanF2+Wb9HgxZi2HCjjcf7K8Z/kiBmlXOHDo/tKxXCblZaltnIEjSqn3arcUyrbT3t0nRZbw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561128213055650.2081481956651; Fri, 21 Jun 2019 07:43:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D23838535D; Fri, 21 Jun 2019 14:42:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B29FA5D9E2; Fri, 21 Jun 2019 14:42:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C0263206D2; Fri, 21 Jun 2019 14:42:04 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5LEg1vb000558 for ; Fri, 21 Jun 2019 10:42:01 -0400 Received: by smtp.corp.redhat.com (Postfix) id E1FF860FFE; Fri, 21 Jun 2019 14:42:01 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-66.ams2.redhat.com [10.36.112.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE97560BFB; Fri, 21 Jun 2019 14:41:58 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 21 Jun 2019 15:41:55 +0100 Message-Id: <20190621144155.29866-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] rpc: add $(SASL_CFLAGS) to libvirt_net_rpc_server_la_CFLAGS X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 21 Jun 2019 14:43:23 +0000 (UTC) The files for libvirt-net-rpc-server.la refernce the sasl/sasl.h system header but never used the $(SASL_CFLAGS) variable. This was never noticed previously because the $(AVAHI_CLFAGS) were set and these typically pulled in the same include directory. When mDNS/Avahi support was removed this exposed the bug which caused FreeBSD builds to break as /usr/local/include was no longer searched for headers. Signed-off-by: Daniel P. Berrang=C3=A9 --- Pushed as a build fix src/rpc/Makefile.inc.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index e5b830605a..b8ca53c69a 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -111,6 +111,7 @@ libvirt_net_rpc_server_la_SOURCES =3D \ libvirt_net_rpc_server_la_CFLAGS =3D \ $(DBUS_CFLAGS) \ $(XDR_CFLAGS) \ + $(SASL_CFLAGS) \ $(AM_CFLAGS) \ $(NULL) libvirt_net_rpc_server_la_LDFLAGS =3D \ --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list