From nobody Mon Apr 29 05:28:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1561024174; cv=none; d=zoho.com; s=zohoarc; b=ABjO6FAkexOe1Ndc3qNf3q/HU6szg1cK7nAvSOacJy6b9aV+Qr1JAw3gdZqEvv0aifg2kRKvatwd06cedNjAicfKgZbMZQpXsKNbiCeOoDLTcbeoMhjkJyRh41pM7ZMz8749y1n9mE+Dy73USRT6ZjY3JOL3oGGtltzl8aiU/2M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561024174; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=F310rEeKGZcx7rRKViBxrvYGk2Ag9ghDMpVioOa2Z9k=; b=PfkZRiqgMcMpraK6wsf6rETedlGLswJCE7vmJR/cu0/v3Ngmll8GascvoLqL/sB0i9DKCUI7HmSZTlh9UT3wn6YeJdJGA3BXWbQs5Oi5k9KaIOqUusEfb7Hi8mOIzd8mTDzB/f/QCoBVidcsro9ScoIRq7RHoUIh1RigGmzDOGs= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1561024174618377.3571555312551; Thu, 20 Jun 2019 02:49:34 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3A2C0308622E; Thu, 20 Jun 2019 09:49:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1096360156; Thu, 20 Jun 2019 09:49:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7228B1806B0F; Thu, 20 Jun 2019 09:49:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5K9nL6u013830 for ; Thu, 20 Jun 2019 05:49:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id 13EE419936; Thu, 20 Jun 2019 09:49:21 +0000 (UTC) Received: from mx1.redhat.com (ext-mx15.extmail.prod.ext.phx2.redhat.com [10.5.110.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0DBE51972A for ; Thu, 20 Jun 2019 09:49:18 +0000 (UTC) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99E7230860CC for ; Thu, 20 Jun 2019 09:49:17 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id a14so3752029edv.12 for ; Thu, 20 Jun 2019 02:49:17 -0700 (PDT) Received: from archpc.localdomain (x8d1ee222.agdsn.tu-dresden.de. [141.30.226.34]) by smtp.gmail.com with ESMTPSA id g8sm3016392eje.1.2019.06.20.02.49.09 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 20 Jun 2019 02:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=uloNr97JbhrQb7tkS6v2qVT2QE4usA9UwW0Z68kF42k=; b=LVKy6MVBmv6J4OymlcpWsjAFBl7Of6ZxhaW375xotAtbQDbS1dV13CvArNj0/maeY7 3X5fbutIsgFiBBJv1SnOOC8ZCq1kOZdXiMWRdZoQuRWRNILFP0NJKVXVBkqeX1TVBykd wjZugGOQ8//WnffSyI2tUs/R/6dhcxI8YA0rNW9kOE0gPmygItXvk9fKJxoBxxi7AeW/ +aKKcTDkustSXsssnYx7GLBD4hiGop7lIjzdUYk7iaua0i4Sk0CnJm84bZGMB28asv2v VNzFK1OC7+hVS46G2eKNl/3fP4QhKPj+J2xM7ZDUuab27ah76E/YbyhXbzoZOM7SR3Q9 xLkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=uloNr97JbhrQb7tkS6v2qVT2QE4usA9UwW0Z68kF42k=; b=Qg877vri0P7tul1Pxp3mLb4DxzhQAmWB2y5HiXApfYiwbS5qNvHmWXkT4cusMzKbQg IPpDcP4+9wJVXyQbVwMC44Xy3TNGCRtLOho3D2nQWqiBJzruZr0NgeQ8bCviewoJXEVy LT8RB54a+Yj7HGmac4Wsb67nhDnBZD9QdIRWT12hEP2Xwb67vE880LpZedNDHRGtmvy6 s/+NqWmRfw4GW4UQrSfzC4sNzLjiDn1/ypbx65lElgOwSWq7TciG/cfFOzdl6qoXEMIE 8BLUtgD2M7FYji+yOpo0sRfM6rRI0B8ws22QUGYn0ieAPBUaUeAq8Gg/gSnrADajHsCr mP0g== X-Gm-Message-State: APjAAAW0wqzxzpCdJ/HBOOkl+22+RP/jrdQnvWntuMy3kpTarsNZOBBx AYcYQ/fSDnw/KhLF8sw5aYvhQi6BNs2DAw== X-Google-Smtp-Source: APXvYqwpVZocWn5rGcpZt/t5qeFfP5GUcuZkEns1h4r3YRC5KmR+xC1kb+M/aqfl+q/jVdICfMG0fA== X-Received: by 2002:a17:906:79d2:: with SMTP id m18mr13730099ejo.233.1561024150988; Thu, 20 Jun 2019 02:49:10 -0700 (PDT) From: Ilias Stamatis To: libvir-list@redhat.com Date: Thu, 20 Jun 2019 11:48:57 +0200 Message-Id: <20190620094857.26321-1-stamatis.iliass@gmail.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 20 Jun 2019 09:49:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 20 Jun 2019 09:49:17 +0000 (UTC) for IP:'209.85.208.68' DOMAIN:'mail-ed1-f68.google.com' HELO:'mail-ed1-f68.google.com' FROM:'stamatis.iliass@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.109 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS) 209.85.208.68 mail-ed1-f68.google.com 209.85.208.68 mail-ed1-f68.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.44 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] test_driver: call virCheckFlags on testDomainReboot X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 20 Jun 2019 09:49:33 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Currently the flags argument is completely ignored, but it should be checked for any unsupported flags that might have been passed. Signed-off-by: Ilias Stamatis Reviewed-by: Erik Skultety --- src/test/test_driver.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2a0ffbc6c5..6b1d53b06d 100755 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1850,13 +1850,16 @@ static int testDomainShutdown(virDomainPtr domain) /* Similar behaviour as shutdown */ static int testDomainReboot(virDomainPtr domain, - unsigned int action ATTRIBUTE_UNUSED) + unsigned int flags) { testDriverPtr privconn =3D domain->conn->privateData; virDomainObjPtr privdom; virObjectEventPtr event =3D NULL; int ret =3D -1; + virCheckFlags(VIR_DOMAIN_REBOOT_DEFAULT | VIR_DOMAIN_REBOOT_ACPI_POWER= _BTN | + VIR_DOMAIN_REBOOT_GUEST_AGENT | VIR_DOMAIN_REBOOT_INITCT= L | + VIR_DOMAIN_REBOOT_SIGNAL | VIR_DOMAIN_REBOOT_PARAVIRT, -= 1); if (!(privdom =3D testDomObjFromDomain(domain))) goto cleanup; -- 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list