From nobody Sun Feb 8 04:28:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560879727; cv=none; d=zoho.com; s=zohoarc; b=QQrnzgxyusCQbJ+pBWAQvz0tsG0+VlvV7ZykVTP8RITBQ9CVQINhMoVZ2lIAZdsTQwq82NQfD9ULw2/syv225jA+QoYoM25XwCPqMhJUJDTRjrlVasD5Nxd07oqrrTLWskRJ4BdASlaI3SiTHkklRuSRpwcJsiH1rVOs0lqeQNc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560879727; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=Ih2GhQZlpQHyAUW6HOeWP+ct/CDYV3LWNs5Dsq0xybY=; b=oW9vLvzy98OrZzGYVGeMiYGBtylZeN1HNru2QJN6Ri+YcBapQm0LZS49D1CoACy1/XIYtY4LMGBV2eiQ+FEULPsPYYLW5bOiPG9hYs6TE9D0mESxJUYkkdE8Q55II72S6AMOOz1fbqoKM8VftN+ypmRJjMhVnAEdpBg65EMxtn0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560879727273248.30072182475715; Tue, 18 Jun 2019 10:42:07 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99FCA356F6; Tue, 18 Jun 2019 17:41:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 298C65F1B7; Tue, 18 Jun 2019 17:41:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EFD591806B19; Tue, 18 Jun 2019 17:41:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5IHde0d009175 for ; Tue, 18 Jun 2019 13:39:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 754481001B34; Tue, 18 Jun 2019 17:39:40 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-51.ams2.redhat.com [10.36.112.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BFA91001DDC; Tue, 18 Jun 2019 17:39:35 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Tue, 18 Jun 2019 18:39:20 +0100 Message-Id: <20190618173921.22902-4-berrange@redhat.com> In-Reply-To: <20190618173921.22902-1-berrange@redhat.com> References: <20190618173921.22902-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 3/4] conf: fix NULL deref when exporting ports X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 18 Jun 2019 17:42:06 +0000 (UTC) Signed-off-by: Daniel P. Berrang=C3=A9 --- src/conf/virnetworkobj.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index ed1f02f4c5..fd4bf779b9 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -1810,10 +1810,12 @@ virNetworkObjPortListExport(virNetworkPtr net, }; int ret =3D -1; =20 - *ports =3D NULL; + if (ports) { + *ports =3D NULL; =20 - if (ports && VIR_ALLOC_N(data.ports, virHashSize(obj->ports) + 1) < 0) - goto cleanup; + if (VIR_ALLOC_N(data.ports, virHashSize(obj->ports) + 1) < 0) + goto cleanup; + } =20 virHashForEach(obj->ports, virNetworkObjPortListExportCallback, &data); =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list