From nobody Sat Feb 7 21:30:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560879706; cv=none; d=zoho.com; s=zohoarc; b=LS38foE5XQpN3NGwzg8zlOVJtY45jyfU2pJPjhAhpttO22M75XqQpydWYUXH00RRJCJrIPMFlTx0ZFlCSglB0GaAqIJVFswsD2Hqzh/mL4fof5gZwja9LFYDiQgaWJM3DAg8CekRK6ugB/APFYEy7i4hdBcU5oMWz4Ko/LA0RQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560879706; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=6zEGrWnIxfiAHN0lNaotjz6kO1qBuXOkiHmSrLFZvGk=; b=ghYvfPIFSlyOj9g6yC34Wr7zbLo9/yb8LwogzV7n7rAWZpaGe6uiM2/NzNpR1ZH7O4jt1cAmeGXF9kbIAvDa5okw253lUTn061s4b9N3vARyu9/dzIMuW9Tcz8WvaRg2CS+1WSwpPfKYSZrwCDLxIPtH3ZPCEPqTTWL87VFQrl0= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560879706449459.02566451585267; Tue, 18 Jun 2019 10:41:46 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63E6C8830B; Tue, 18 Jun 2019 17:40:56 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76F3D5786; Tue, 18 Jun 2019 17:40:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 35F99206D3; Tue, 18 Jun 2019 17:40:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5IHdWEd009135 for ; Tue, 18 Jun 2019 13:39:32 -0400 Received: by smtp.corp.redhat.com (Postfix) id 75A4B1001DEE; Tue, 18 Jun 2019 17:39:32 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-51.ams2.redhat.com [10.36.112.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id 685321001DDC; Tue, 18 Jun 2019 17:39:29 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Tue, 18 Jun 2019 18:39:18 +0100 Message-Id: <20190618173921.22902-2-berrange@redhat.com> In-Reply-To: <20190618173921.22902-1-berrange@redhat.com> References: <20190618173921.22902-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 1/4] conf: fix leak when parsing network port XML X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 18 Jun 2019 17:41:43 +0000 (UTC) Use auto free to avoid leaking the "trustGuestRxFilters" strings Signed-off-by: Daniel P. Berrang=C3=A9 --- src/conf/virnetworkportdef.c | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/src/conf/virnetworkportdef.c b/src/conf/virnetworkportdef.c index 379411e088..5dfa3a3583 100644 --- a/src/conf/virnetworkportdef.c +++ b/src/conf/virnetworkportdef.c @@ -76,19 +76,19 @@ static virNetworkPortDefPtr virNetworkPortDefParseXML(xmlXPathContextPtr ctxt) { virNetworkPortDefPtr def; - char *uuid =3D NULL; + VIR_AUTOFREE(char *) uuid =3D NULL; xmlNodePtr virtPortNode; xmlNodePtr vlanNode; xmlNodePtr bandwidthNode; xmlNodePtr addressNode; - char *trustGuestRxFilters =3D NULL; - char *mac =3D NULL; - char *macmgr =3D NULL; - char *mode =3D NULL; - char *plugtype =3D NULL; - char *managed =3D NULL; - char *driver =3D NULL; - char *class_id =3D NULL; + VIR_AUTOFREE(char *) trustGuestRxFilters =3D NULL; + VIR_AUTOFREE(char *) mac =3D NULL; + VIR_AUTOFREE(char *) macmgr =3D NULL; + VIR_AUTOFREE(char *) mode =3D NULL; + VIR_AUTOFREE(char *) plugtype =3D NULL; + VIR_AUTOFREE(char *) managed =3D NULL; + VIR_AUTOFREE(char *) driver =3D NULL; + VIR_AUTOFREE(char *) class_id =3D NULL; =20 if (VIR_ALLOC(def) < 0) return NULL; @@ -255,14 +255,6 @@ virNetworkPortDefParseXML(xmlXPathContextPtr ctxt) } =20 cleanup: - VIR_FREE(class_id); - VIR_FREE(uuid); - VIR_FREE(plugtype); - VIR_FREE(mac); - VIR_FREE(mode); - VIR_FREE(macmgr); - VIR_FREE(driver); - VIR_FREE(managed); return def; =20 error: --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list