From nobody Mon Feb 9 06:48:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511477; cv=none; d=zoho.com; s=zohoarc; b=VRTtF0j6D2mZtHi/cOX9TLYpOfc7prK4REulU/js8cRSLISLglR4BojTt5tpPl60UUsAYzBECvltwaIWFErwby1uudS0mZtExCjU/4tYYq5O+g1rY5G7E4OrfbSMf3r1KGSGoCmAQVPlfn/OSUHRTBqI47S9wPO8EU+FOdqDCfs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511477; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=CMFchPyV4icH+fAY8cnG1/83qB0FO5SHulk0JQyL8QU=; b=HbKSnpNme8jRv2dlkxiJg00mQC/2ckD5nzYSnQ7uQdmWWVP7Tpzn6UK510MDlW4nFN0xR/XftpDbRn5k3jKmEutRjuL3PfjXDWCLEC3n24pk4bI5H8TRqIb62EzYeLnjeM4+WlBg89uL6uQV0DE3gTEQ63DCo9S4GI7sscBKLu4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156051147768894.04995997346703; Fri, 14 Jun 2019 04:24:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8C67C058CC0; Fri, 14 Jun 2019 11:24:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B15F61001DC0; Fri, 14 Jun 2019 11:24:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6B76E206D6; Fri, 14 Jun 2019 11:24:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNgCJ026552 for ; Fri, 14 Jun 2019 07:23:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 371351A924; Fri, 14 Jun 2019 11:23:42 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5C6F1A8F1 for ; Fri, 14 Jun 2019 11:23:41 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:30 +0200 Message-Id: <20190614112331.25725-7-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 6/7] qemu: Format spapr-vio addresses as 32-bit X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 14 Jun 2019 11:24:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" No reason not to be consistent with the user-visible value. Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 2 +- tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pseries-vio-user-assigned.args | 2 +- tests/qemuxml2argvdata/pseries-vio.args | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 59dc134785..9d4d0b8fc2 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -395,7 +395,7 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, } } else if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO) { if (info->addr.spaprvio.has_reg) - virBufferAsprintf(buf, ",reg=3D0x%llx", info->addr.spaprvio.re= g); + virBufferAsprintf(buf, ",reg=3D0x%08llx", info->addr.spaprvio.= reg); } else if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { if (info->addr.ccw.assigned) virBufferAsprintf(buf, ",devno=3D%x.%x.%04x", diff --git a/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args b/tests/qe= muxml2argvdata/disk-scsi.x86_64-latest.args index 6c2618ed61..7bf011fd5f 100644 --- a/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args +++ b/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args @@ -30,7 +30,7 @@ file=3D/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ -device lsi,id=3Dscsi0,bus=3Dpci.0,addr=3D0x2 \ -device megasas,id=3Dscsi1,bus=3Dpci.0,addr=3D0x3 \ -device mptsas1068,id=3Dscsi2,bus=3Dpci.0,addr=3D0x4 \ --device spapr-vscsi,id=3Dscsi3,reg=3D0x2000 \ +-device spapr-vscsi,id=3Dscsi3,reg=3D0x00002000 \ -drive file=3D/dev/HostVG/QEMUGuest1,format=3Draw,if=3Dnone,id=3Ddrive-ide= 0-0-0 \ -device ide-hd,bus=3Dide.0,unit=3D0,drive=3Ddrive-ide0-0-0,id=3Dide0-0-0,b= ootindex=3D1 \ -drive file=3D/tmp/scsidisk.img,format=3Draw,if=3Dnone,id=3Ddrive-scsi0-0-= 0 \ diff --git a/tests/qemuxml2argvdata/pseries-vio-user-assigned.args b/tests/= qemuxml2argvdata/pseries-vio-user-assigned.args index 534037607a..a412593c9a 100644 --- a/tests/qemuxml2argvdata/pseries-vio-user-assigned.args +++ b/tests/qemuxml2argvdata/pseries-vio-user-assigned.args @@ -23,7 +23,7 @@ server,nowait \ -mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ -rtc base=3Dutc \ -no-shutdown \ --device spapr-vscsi,id=3Dscsi0,reg=3D0x2000 \ +-device spapr-vscsi,id=3Dscsi0,reg=3D0x00002000 \ -device spapr-vscsi,id=3Dscsi1,reg=3D0x30000000 \ -usb \ -drive file=3D/tmp/scsidisk.img,format=3Draw,if=3Dnone,id=3Ddrive-scsi1-0-= 0-0 \ diff --git a/tests/qemuxml2argvdata/pseries-vio.args b/tests/qemuxml2argvda= ta/pseries-vio.args index 9d4f77b85e..a500e9b4b9 100644 --- a/tests/qemuxml2argvdata/pseries-vio.args +++ b/tests/qemuxml2argvdata/pseries-vio.args @@ -23,8 +23,8 @@ server,nowait \ -mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ -rtc base=3Dutc \ -no-shutdown \ --device spapr-vscsi,id=3Dscsi0,reg=3D0x2000 \ --device spapr-vscsi,id=3Dscsi1,reg=3D0x3000 \ +-device spapr-vscsi,id=3Dscsi0,reg=3D0x00002000 \ +-device spapr-vscsi,id=3Dscsi1,reg=3D0x00003000 \ -usb \ -drive file=3D/tmp/scsidisk.img,format=3Draw,if=3Dnone,id=3Ddrive-scsi1-0-= 0-0 \ -device scsi-hd,bus=3Dscsi1.0,channel=3D0,scsi-id=3D0,lun=3D0,drive=3Ddriv= e-scsi1-0-0-0,\ --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list