From nobody Mon May 6 03:39:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511435; cv=none; d=zoho.com; s=zohoarc; b=CxCTt0EFxH4xUNippyMabvdjdcUaIywkXhmZHEOfwTafnxAKTsI2EVbxuq98DukGvr6uUf3M4GSSxMdbsJ+t/N1h6peeLJKV/HkpjdVabTm+ehy/V2AS9P4rlry/NDJcBZStDSSBK6FQ5beeHiP5PcBZaKHzlPlpmcgFyryXdYI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511435; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=+ZfCIPi8Ua8AeMjzIgici4PLWP04ESOfwgPAuHJBjrU=; b=irPtGqGwVLoxNOFunhnWtIHDE17wvZSKXTLzc/1OaMdD9+kpU+b1hVR4vdKQ5wmG2lJiqy4q6zYv3OP+QsoCl10lHOHS7Tqx5UF9da4w7VahUuJHsZZ8o1p964iLUeLAwS0edPSQ5O0/HWyHLFf0y3jfFxVv/ekOO/Jfh5K5QfI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560511435391797.9998332995806; Fri, 14 Jun 2019 04:23:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0472230917AA; Fri, 14 Jun 2019 11:23:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7A8439C3; Fri, 14 Jun 2019 11:23:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6A35D3D87; Fri, 14 Jun 2019 11:23:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNcBK026431 for ; Fri, 14 Jun 2019 07:23:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3DA5F1A924; Fri, 14 Jun 2019 11:23:38 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC57C1A8F1 for ; Fri, 14 Jun 2019 11:23:37 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:25 +0200 Message-Id: <20190614112331.25725-2-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/7] docs: Fix validation of spapr-vio addresses X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 14 Jun 2019 11:23:54 +0000 (UTC) Content-Type: text/plain; charset="utf-8" According to sPAPR, addresses are 32-bit (8 hex digits) rather than 64-bit (16 hex digits). Update the schema accordingly. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- docs/schemas/domaincommon.rng | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 4bd75e3055..9fd23efb47 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -6386,7 +6386,7 @@ - (0x)?[0-9a-fA-F]{1,16} + (0x)?[0-9a-fA-F]{1,8} --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 03:39:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511469; cv=none; d=zoho.com; s=zohoarc; b=KpTNng69h3sUaXaEYcRaoE5Xwb7dWlOXrflStJry3Cjju+Z18SBX5wZZhkRM8s5rAg2KYzkC9ouu9+/qG5iHe9DQTipQdkedFe3G/GLIwsTMj5Ge0+hDjC7Zx8C6IMGjLF2b7yvVBqvOevNJzPKVjpn+xzhApXYFveYw2U6EmUg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511469; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=pgIZ7JbKUQooDm9IpAo8eE5MTV5f3ApW9d3IcxGp1Pc=; b=Pu+Y0mxSZgEXg1IcZs7e1E/3RyhWiypusATJTyDiVw5jNsjufrnukrUEQM6wwRxEGckzmK5LkdyPrUtADf1VVZ1C8G54Q/YNc2DA+LUnU2xUFJFOPFYr2aCUEVkACsacW7xY88nDabwANj1xjNcdpfk6XPKGKBMTYTXBtGVBL/c= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560511469844545.7948904281294; Fri, 14 Jun 2019 04:24:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0BF77308427E; Fri, 14 Jun 2019 11:24:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D61319885; Fri, 14 Jun 2019 11:24:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 95E4B206D6; Fri, 14 Jun 2019 11:24:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNdwJ026453 for ; Fri, 14 Jun 2019 07:23:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0B5322B465; Fri, 14 Jun 2019 11:23:39 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89E761A8F1 for ; Fri, 14 Jun 2019 11:23:38 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:26 +0200 Message-Id: <20190614112331.25725-3-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/7] qemu: Rework qemuDomainDeviceDefValidateAddress() X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 14 Jun 2019 11:24:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Introduce a switch() statement and prepare for validating more address types than just PCI. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/qemu/qemu_domain.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index e5c6ef3fda..76963d1c5a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6193,9 +6193,35 @@ qemuDomainDeviceDefValidateAddress(const virDomainDe= viceDef *dev, if (!(info =3D virDomainDeviceGetInfo((virDomainDeviceDef *)dev))) return 0; =20 - if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) + switch ((virDomainDeviceAddressType) info->type) { + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI: return qemuDomainDeviceDefValidateZPCIAddress(info, qemuCaps); =20 + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE: + /* Address validation might happen before we have had a chance to + * automatically assign addresses to devices for which the user + * didn't specify one themselves */ + break; + + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCID: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_ISA: + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DIMM: + /* No validation for these address types yet */ + break; + + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_LAST: + default: + virReportEnumRangeError(virDomainDeviceAddressType, info->type); + return -1; + } + return 0; } =20 --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 03:39:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511475; cv=none; d=zoho.com; s=zohoarc; b=Ri3NQ/S7akRsIhyfqjskKj3gBASZmfIwQ9lNgPJ+nKSRvktc/dzv069jvl64hqrjR1sqXtOzYmwadeWIWEsIjydg1Z6UycpWif7J+P1dxh8yFU9TwdHjIgzN6FRmN4XE+4PmXwaNNGzJ87qlpXyy4vQVGaxJLxW4ASSELBPYP9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511475; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=aaHbxxZ9JbKIm12JXjg87iIF/SJfgVW1agjOVMNlWAM=; b=PGGfZPIxSrdh9pgUutAXeFoycoCeuvZh+Zf7tMqk54mvhKwr3sVusK7btTUX+OOH6V2B169+ZU4fDaBIDanYtpK6cBQB3v0rQ9PqjWRh/p+9WC0Zb50eymt4cwiAjm0iIrY601sHj8poCaK7+UaRRUR8Q6wQDzBbYpx/UpYBz1U= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560511475072734.940447379699; Fri, 14 Jun 2019 04:24:35 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 51559308FB9D; Fri, 14 Jun 2019 11:24:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9ACFB1001B3D; Fri, 14 Jun 2019 11:24:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5A1D21806B15; Fri, 14 Jun 2019 11:24:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNdKu026479 for ; Fri, 14 Jun 2019 07:23:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id CC4231A8F1; Fri, 14 Jun 2019 11:23:39 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 57E8E1A924 for ; Fri, 14 Jun 2019 11:23:39 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:27 +0200 Message-Id: <20190614112331.25725-4-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 3/7] qemu: Validate spapr-vio addresses X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 14 Jun 2019 11:24:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" According to sPAPR, addresses are 32-bit rather than 64-bit. Update qemuDomainDeviceDefValidateAddress() accordingly. https://bugzilla.redhat.com/show_bug.cgi?id=3D1598657 Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/qemu/qemu_domain.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 76963d1c5a..abc8809b56 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6203,11 +6203,24 @@ qemuDomainDeviceDefValidateAddress(const virDomainD= eviceDef *dev, * didn't specify one themselves */ break; =20 + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO: { + virDomainDeviceSpaprVioAddressPtr addr =3D &(info->addr.spaprvio); + + if (addr->has_reg && addr->reg > 0xffffffff) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("spapr-vio reg=3D'0x%llx' exceeds maximum " + "possible value (0xffffffff)"), + addr->reg); + return -1; + } + + break; + } + case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCID: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_USB: - case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_MMIO: --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 03:39:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511441; cv=none; d=zoho.com; s=zohoarc; b=SR7VcaZwIoCB/0nYDhkxKJC3LSx/Vv1veng/5rw3lYAibz83EsiZ7qXklcN3Hoj4eBT8iUGt+t4FykQBitim7IwI6wTrzNusG/Z/DSffJeJ4IMv3cJ8oMMInQBzfut6ey6nyjhmo3vA9qKuo3RTixLfUm+/A/qbABdZHoiNSyqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511441; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=FoRrW3xrTZWyenArYcCxXvQzZ2ON01Ih2ATzdJvyyHE=; b=Q8LF5taG8LPBM70mB4YdE5e3YaVwVdxOXqVqiHOr6b191uZbT7i7oq5lEThv/ZXJqwBfdKTCHaTmTSXacV/aBlGZv1QwV1jTBJmNWZMiLlEQvtU7hD79bXecBp1Jh0xS1fHPYGAn4QP4zahlmyexWw/S2B68KmytUQ8g6YmIyKU= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560511441497587.9216124145739; Fri, 14 Jun 2019 04:24:01 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BB7E030832C5; Fri, 14 Jun 2019 11:23:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90261648C8; Fri, 14 Jun 2019 11:23:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3B57924AFA; Fri, 14 Jun 2019 11:23:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNe0s026500 for ; Fri, 14 Jun 2019 07:23:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 99FFF1A924; Fri, 14 Jun 2019 11:23:40 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 250651A8F1 for ; Fri, 14 Jun 2019 11:23:39 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:28 +0200 Message-Id: <20190614112331.25725-5-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 4/7] tests: Add pseries-spaprvio-invalid X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 14 Jun 2019 11:24:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This test case shows that we now reject invalid spapr-vio addresses. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- .../pseries-spaprvio-invalid.xml | 17 +++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 2 files changed, 18 insertions(+) create mode 100644 tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml diff --git a/tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml b/tests/qe= muxml2argvdata/pseries-spaprvio-invalid.xml new file mode 100644 index 0000000000..cd658e314b --- /dev/null +++ b/tests/qemuxml2argvdata/pseries-spaprvio-invalid.xml @@ -0,0 +1,17 @@ + + guest + b35969f7-e7cf-4d90-a9a0-4dd9000f9824 + 4194304 + 4 + + hvm + + + /usr/bin/qemu-system-ppc64 + + +
+ + + diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 49220733ae..6a75d663c5 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1898,6 +1898,7 @@ mymain(void) DO_TEST("pseries-console-virtio", QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE); DO_TEST_PARSE_ERROR("pseries-serial-invalid-machine", NONE); + DO_TEST_PARSE_ERROR("pseries-spaprvio-invalid", "ppc64"); =20 DO_TEST("mach-virt-serial-native", QEMU_CAPS_DEVICE_PL011); --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 03:39:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511478; cv=none; d=zoho.com; s=zohoarc; b=j4MsWyf/aOOvzoucJlaiyTkrXzCf+cbKezwLPrxOs9btfwKfH9Soala7ES8g5+LZH7i0a35gBOlS1toq6VR5MUdUwy3DC8vMYLUJPVcXY8MTRTuzKN1EGafShfJBigOdoOGNXJ7x95Dn4V0gdXZZSqbxToYJmLfKBIlL7yMAyUI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511478; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=MATJgHZKneh5rurdt+hgeLQW5QpIpc1AqpTG9P0oULA=; b=VNg0eYDiivhQj6dEDVgONWAzi/e3XhzWvqoIWT70lJC0x1PyRHwaOBl0Ux9uKvaYtLPVenMPqWRQS1s12RkQnOBb5WFuRYV1Zr8dHdAf98iH/q/wLXVkgqJWJMo/tsqjWJ00osEttbuMvhepyjXfsr+lt3dH6lq1rBKSArEdBLc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560511478943907.6013102952274; Fri, 14 Jun 2019 04:24:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5890C33025C; Fri, 14 Jun 2019 11:24:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 309B560BE2; Fri, 14 Jun 2019 11:24:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EA14C1806B1A; Fri, 14 Jun 2019 11:24:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNfDg026522 for ; Fri, 14 Jun 2019 07:23:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6A1C01A8F1; Fri, 14 Jun 2019 11:23:41 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E757E2B45C for ; Fri, 14 Jun 2019 11:23:40 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:29 +0200 Message-Id: <20190614112331.25725-6-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 5/7] conf: Format spapr-vio addresses as 32-bit X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 14 Jun 2019 11:24:37 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Using 8 hex digits all the time, regardless of whether the actual value can fit in fewer, makes it more obvious to the user what the limits are. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 2 +- tests/qemuargv2xmldata/nomachine-ppc64.xml | 2 +- tests/qemuargv2xmldata/pseries-disk.xml | 2 +- tests/qemuargv2xmldata/pseries-nvram.xml | 2 +- tests/qemuxml2xmloutdata/disk-scsi.xml | 2 +- tests/qemuxml2xmloutdata/pseries-nvram.xml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 97ba8bd53a..54a24b6276 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7135,7 +7135,7 @@ virDomainDeviceInfoFormat(virBufferPtr buf, =20 case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO: if (info->addr.spaprvio.has_reg) - virBufferAsprintf(&attrBuf, " reg=3D'0x%llx'", info->addr.spap= rvio.reg); + virBufferAsprintf(&attrBuf, " reg=3D'0x%08llx'", info->addr.sp= aprvio.reg); break; =20 case VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW: diff --git a/tests/qemuargv2xmldata/nomachine-ppc64.xml b/tests/qemuargv2xm= ldata/nomachine-ppc64.xml index 18b0c5c20a..f61006efec 100644 --- a/tests/qemuargv2xmldata/nomachine-ppc64.xml +++ b/tests/qemuargv2xmldata/nomachine-ppc64.xml @@ -35,7 +35,7 @@ -
+
diff --git a/tests/qemuargv2xmldata/pseries-disk.xml b/tests/qemuargv2xmlda= ta/pseries-disk.xml index 18b0c5c20a..f61006efec 100644 --- a/tests/qemuargv2xmldata/pseries-disk.xml +++ b/tests/qemuargv2xmldata/pseries-disk.xml @@ -35,7 +35,7 @@ -
+
diff --git a/tests/qemuargv2xmldata/pseries-nvram.xml b/tests/qemuargv2xmld= ata/pseries-nvram.xml index 500227afc0..78f79f17d7 100644 --- a/tests/qemuargv2xmldata/pseries-nvram.xml +++ b/tests/qemuargv2xmldata/pseries-nvram.xml @@ -23,7 +23,7 @@ -
+
diff --git a/tests/qemuxml2xmloutdata/disk-scsi.xml b/tests/qemuxml2xmloutd= ata/disk-scsi.xml index 9cfff4b14e..45fed6423a 100644 --- a/tests/qemuxml2xmloutdata/disk-scsi.xml +++ b/tests/qemuxml2xmloutdata/disk-scsi.xml @@ -62,7 +62,7 @@
-
+
diff --git a/tests/qemuxml2xmloutdata/pseries-nvram.xml b/tests/qemuxml2xml= outdata/pseries-nvram.xml index f89b23b338..fd77c7aa89 100644 --- a/tests/qemuxml2xmloutdata/pseries-nvram.xml +++ b/tests/qemuxml2xmloutdata/pseries-nvram.xml @@ -23,7 +23,7 @@ -
+
--=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 03:39:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511477; cv=none; d=zoho.com; s=zohoarc; b=VRTtF0j6D2mZtHi/cOX9TLYpOfc7prK4REulU/js8cRSLISLglR4BojTt5tpPl60UUsAYzBECvltwaIWFErwby1uudS0mZtExCjU/4tYYq5O+g1rY5G7E4OrfbSMf3r1KGSGoCmAQVPlfn/OSUHRTBqI47S9wPO8EU+FOdqDCfs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511477; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=CMFchPyV4icH+fAY8cnG1/83qB0FO5SHulk0JQyL8QU=; b=HbKSnpNme8jRv2dlkxiJg00mQC/2ckD5nzYSnQ7uQdmWWVP7Tpzn6UK510MDlW4nFN0xR/XftpDbRn5k3jKmEutRjuL3PfjXDWCLEC3n24pk4bI5H8TRqIb62EzYeLnjeM4+WlBg89uL6uQV0DE3gTEQ63DCo9S4GI7sscBKLu4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156051147768894.04995997346703; Fri, 14 Jun 2019 04:24:37 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D8C67C058CC0; Fri, 14 Jun 2019 11:24:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B15F61001DC0; Fri, 14 Jun 2019 11:24:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6B76E206D6; Fri, 14 Jun 2019 11:24:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNgCJ026552 for ; Fri, 14 Jun 2019 07:23:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 371351A924; Fri, 14 Jun 2019 11:23:42 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5C6F1A8F1 for ; Fri, 14 Jun 2019 11:23:41 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:30 +0200 Message-Id: <20190614112331.25725-7-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 6/7] qemu: Format spapr-vio addresses as 32-bit X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 14 Jun 2019 11:24:36 +0000 (UTC) Content-Type: text/plain; charset="utf-8" No reason not to be consistent with the user-visible value. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- src/qemu/qemu_command.c | 2 +- tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pseries-vio-user-assigned.args | 2 +- tests/qemuxml2argvdata/pseries-vio.args | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 59dc134785..9d4d0b8fc2 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -395,7 +395,7 @@ qemuBuildDeviceAddressStr(virBufferPtr buf, } } else if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_SPAPRVIO) { if (info->addr.spaprvio.has_reg) - virBufferAsprintf(buf, ",reg=3D0x%llx", info->addr.spaprvio.re= g); + virBufferAsprintf(buf, ",reg=3D0x%08llx", info->addr.spaprvio.= reg); } else if (info->type =3D=3D VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { if (info->addr.ccw.assigned) virBufferAsprintf(buf, ",devno=3D%x.%x.%04x", diff --git a/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args b/tests/qe= muxml2argvdata/disk-scsi.x86_64-latest.args index 6c2618ed61..7bf011fd5f 100644 --- a/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args +++ b/tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args @@ -30,7 +30,7 @@ file=3D/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ -device lsi,id=3Dscsi0,bus=3Dpci.0,addr=3D0x2 \ -device megasas,id=3Dscsi1,bus=3Dpci.0,addr=3D0x3 \ -device mptsas1068,id=3Dscsi2,bus=3Dpci.0,addr=3D0x4 \ --device spapr-vscsi,id=3Dscsi3,reg=3D0x2000 \ +-device spapr-vscsi,id=3Dscsi3,reg=3D0x00002000 \ -drive file=3D/dev/HostVG/QEMUGuest1,format=3Draw,if=3Dnone,id=3Ddrive-ide= 0-0-0 \ -device ide-hd,bus=3Dide.0,unit=3D0,drive=3Ddrive-ide0-0-0,id=3Dide0-0-0,b= ootindex=3D1 \ -drive file=3D/tmp/scsidisk.img,format=3Draw,if=3Dnone,id=3Ddrive-scsi0-0-= 0 \ diff --git a/tests/qemuxml2argvdata/pseries-vio-user-assigned.args b/tests/= qemuxml2argvdata/pseries-vio-user-assigned.args index 534037607a..a412593c9a 100644 --- a/tests/qemuxml2argvdata/pseries-vio-user-assigned.args +++ b/tests/qemuxml2argvdata/pseries-vio-user-assigned.args @@ -23,7 +23,7 @@ server,nowait \ -mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ -rtc base=3Dutc \ -no-shutdown \ --device spapr-vscsi,id=3Dscsi0,reg=3D0x2000 \ +-device spapr-vscsi,id=3Dscsi0,reg=3D0x00002000 \ -device spapr-vscsi,id=3Dscsi1,reg=3D0x30000000 \ -usb \ -drive file=3D/tmp/scsidisk.img,format=3Draw,if=3Dnone,id=3Ddrive-scsi1-0-= 0-0 \ diff --git a/tests/qemuxml2argvdata/pseries-vio.args b/tests/qemuxml2argvda= ta/pseries-vio.args index 9d4f77b85e..a500e9b4b9 100644 --- a/tests/qemuxml2argvdata/pseries-vio.args +++ b/tests/qemuxml2argvdata/pseries-vio.args @@ -23,8 +23,8 @@ server,nowait \ -mon chardev=3Dcharmonitor,id=3Dmonitor,mode=3Dcontrol \ -rtc base=3Dutc \ -no-shutdown \ --device spapr-vscsi,id=3Dscsi0,reg=3D0x2000 \ --device spapr-vscsi,id=3Dscsi1,reg=3D0x3000 \ +-device spapr-vscsi,id=3Dscsi0,reg=3D0x00002000 \ +-device spapr-vscsi,id=3Dscsi1,reg=3D0x00003000 \ -usb \ -drive file=3D/tmp/scsidisk.img,format=3Draw,if=3Dnone,id=3Ddrive-scsi1-0-= 0-0 \ -device scsi-hd,bus=3Dscsi1.0,channel=3D0,scsi-id=3D0,lun=3D0,drive=3Ddriv= e-scsi1-0-0-0,\ --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Mon May 6 03:39:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560511485; cv=none; d=zoho.com; s=zohoarc; b=lCiYUvv4ySxEVMkoy7CVvLpAAk+4vvVP4cFETQ5fXJVPXkwO5M2L7nYVhnHX89XN7WSNlkGNI/LOrxJfxZFsgZsO8XiDf6MajZG07HkMAjiSny6mbAezx/wuK8ovvAAh7AHoTqGQNYV6sejIS5OJj11vhFAmYifKFbpEKlavuXY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560511485; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=6j/W5i6emXTYxIjUcFQ3qSDhU614UxEcK05T6r/Y0XY=; b=cKCIAZW+OcMYbflogUxhaeD0wcbxfsFVe2gJm8P/vK/9bcJBexmKF90rs7McLvjbaE7Qm0MLx45EVUfrc7mRWkkmEbLw9WToWNB0WYyLWzYG8WH62CBCvTF3P++CauE6jtbYHh8u0x5Np9J2e7d1VewPC5RBkSwWQOfCyTS9B9Y= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 156051148596677.74683443475624; Fri, 14 Jun 2019 04:24:45 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5C6955D674; Fri, 14 Jun 2019 11:24:44 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 355FF1001B3F; Fri, 14 Jun 2019 11:24:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DB09E206DA; Fri, 14 Jun 2019 11:24:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5EBNhWp026575 for ; Fri, 14 Jun 2019 07:23:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0350C1A8F1; Fri, 14 Jun 2019 11:23:43 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 831FA1A924 for ; Fri, 14 Jun 2019 11:23:42 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 13:23:31 +0200 Message-Id: <20190614112331.25725-8-abologna@redhat.com> In-Reply-To: <20190614112331.25725-1-abologna@redhat.com> References: <20190614112331.25725-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 7/7] docs: Update documentation for spapr-vio addresses X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 14 Jun 2019 11:24:44 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik --- docs/formatdomain.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 22ddcb71d3..144baa2e85 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4076,9 +4076,9 @@
spapr-vio
On PowerPC pseries guests, devices can be assigned to the - SPAPR-VIO bus. It has a flat 64-bit address space; by + SPAPR-VIO bus. It has a flat 32-bit address space; by convention, devices are generally assigned at a non-zero - multiple of 0x1000, but other addresses are valid and + multiple of 0x00001000, but other addresses are valid and permitted by libvirt. Each address has the following additional attribute: reg (the hex value address of the starting register). Since @@ -8291,7 +8291,7 @@ qemu-kvm -net nic,model=3D? /dev/null ... <devices> <nvram> - <address type=3D'spapr-vio' reg=3D'0x3000'/> + <address type=3D'spapr-vio' reg=3D'0x00003000'/> </nvram> </devices> ... --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list