From nobody Tue Feb 10 03:45:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560499503; cv=none; d=zoho.com; s=zohoarc; b=T/HJYoYj4gaTnoJqBbQEqU2h6tUiM/V/L7Fyz0DZGAcSoByhpXMNXhgfIpOLRIwojWeaP6hCtaQbWBoDcYjtr/FtZyCyC1MCrykGxoZcnVQ3Gc9fNB7U/8EHsQxRQ+qLUeF3W4VwnGjGtnq5qZQUrULEbZWJ/YUVUF2TbquqyqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560499503; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=asciPc2riaDFz1WvVKv2UImqxgSSrcA952pVzZ36HHY=; b=QNcHI6LP1/z1jiO02KhjbztM5Enbej5jZy/5uSYZJG+Y0f8WxNprF5hPJTf02zF50+ynSwFmbNwlFh7Fun3F4rUJcP7UBW1L67O53xWdlqX/PQnzLs8J8SmdsUKdsX0kaH3Q4dOu/obevkktjijUYIw5vsUtVbU5aLiJUcd5gLw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560499503338863.3403263723037; Fri, 14 Jun 2019 01:05:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 25018308FBB4; Fri, 14 Jun 2019 08:04:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0B5760C44; Fri, 14 Jun 2019 08:04:53 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2CE971833004; Fri, 14 Jun 2019 08:04:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5E84idD028861 for ; Fri, 14 Jun 2019 04:04:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id C667B90A2; Fri, 14 Jun 2019 08:04:44 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BD0D2855D for ; Fri, 14 Jun 2019 08:04:44 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 14 Jun 2019 10:04:36 +0200 Message-Id: <20190614080439.29627-2-abologna@redhat.com> In-Reply-To: <20190614080439.29627-1-abologna@redhat.com> References: <20190614080439.29627-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 1/4] tests: Normalize quotes for *-graphics X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 14 Jun 2019 08:04:58 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Right now *-headless and *-graphics tests are using different quoting styles, which results in the diff between them being basically useless, whereas we would like it to be possible to compare these files directly and easily spot the differences. Convert all *-graphics tests to single quotes, which is the overwhelmingly more popular style and also the one libvirt itself uses when formatting XML, which is a fact that will come in handy later. Signed-off-by: Andrea Bolognani Reviewed-by: J=C3=A1n Tomko --- .../aarch64-virt-graphics.xml | 50 ++++++++--------- .../ppc64-pseries-graphics.xml | 48 ++++++++-------- tests/qemuxml2argvdata/s390x-ccw-graphics.xml | 46 +++++++-------- tests/qemuxml2argvdata/x86_64-pc-graphics.xml | 56 +++++++++---------- .../qemuxml2argvdata/x86_64-q35-graphics.xml | 56 +++++++++---------- 5 files changed, 128 insertions(+), 128 deletions(-) diff --git a/tests/qemuxml2argvdata/aarch64-virt-graphics.xml b/tests/qemux= ml2argvdata/aarch64-virt-graphics.xml index 0748b8da2d..54cfea634c 100644 --- a/tests/qemuxml2argvdata/aarch64-virt-graphics.xml +++ b/tests/qemuxml2argvdata/aarch64-virt-graphics.xml @@ -1,49 +1,49 @@ - + guest 33844184-97c0-4cc0-aa7d-206f5803530b - - + + 4194304 4194304 4 - hvm - /usr/share/AAVMF/AAVMF_CODE.f= d + hvm + /usr/share/AAVMF/AAVMF_CODE.f= d /var/lib/libvirt/qemu/nvram/guest_VARS.fd - + - + /usr/bin/qemu-system-aarch64 - - - - + + + + - - - - + + + + - - - - + + + + - - - + + + - - /dev/urandom + + /dev/urandom diff --git a/tests/qemuxml2argvdata/ppc64-pseries-graphics.xml b/tests/qemu= xml2argvdata/ppc64-pseries-graphics.xml index 3d54a4f171..c4ef08b2bf 100644 --- a/tests/qemuxml2argvdata/ppc64-pseries-graphics.xml +++ b/tests/qemuxml2argvdata/ppc64-pseries-graphics.xml @@ -1,44 +1,44 @@ - + guest b35969f7-e7cf-4d90-a9a0-4dd9000f9824 - - + + 4194304 4194304 4 - hvm - + hvm + - + /usr/bin/qemu-system-ppc64 - - - - + + + + - - - - + + + + - - - - + + + + - - - + + + - - /dev/urandom + + /dev/urandom diff --git a/tests/qemuxml2argvdata/s390x-ccw-graphics.xml b/tests/qemuxml2= argvdata/s390x-ccw-graphics.xml index 3f54fdf9bd..a9bb3485db 100644 --- a/tests/qemuxml2argvdata/s390x-ccw-graphics.xml +++ b/tests/qemuxml2argvdata/s390x-ccw-graphics.xml @@ -1,43 +1,43 @@ - + guest a7ca230a-fbe0-48b8-8ea6-25836f8cbc32 - - + + 4194304 4194304 4 - hvm - + hvm + - + /usr/bin/qemu-system-s390x - - - - + + + + - - - + + + - - - - + + + + - - - + + + - - /dev/urandom + + /dev/urandom diff --git a/tests/qemuxml2argvdata/x86_64-pc-graphics.xml b/tests/qemuxml2= argvdata/x86_64-pc-graphics.xml index 03745eabf4..3c7dbc9438 100644 --- a/tests/qemuxml2argvdata/x86_64-pc-graphics.xml +++ b/tests/qemuxml2argvdata/x86_64-pc-graphics.xml @@ -1,55 +1,55 @@ - + guest 2c0abd3d-8f18-42c0-a132-9708213aaac9 - - + + 4194304 4194304 4 - hvm - + hvm + - - - - + + + + - - + + /usr/bin/qemu-system-x86_64 - - - - + + + + - - - - + + + + - - - - + + + + - - + + - - /dev/urandom + + /dev/urandom diff --git a/tests/qemuxml2argvdata/x86_64-q35-graphics.xml b/tests/qemuxml= 2argvdata/x86_64-q35-graphics.xml index 56db898e64..d3ad87c963 100644 --- a/tests/qemuxml2argvdata/x86_64-q35-graphics.xml +++ b/tests/qemuxml2argvdata/x86_64-q35-graphics.xml @@ -1,55 +1,55 @@ - + guest 61288c03-0b0d-4f1e-9496-0f0256f2e013 - - + + 4194304 4194304 4 - hvm - + hvm + - - - - + + + + - - + + /usr/bin/qemu-system-x86_64 - - - - + + + + - - - - + + + + - - - - + + + + - - + + - - /dev/urandom + + /dev/urandom --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list