From nobody Fri Apr 26 16:16:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1560138295; cv=none; d=zoho.com; s=zohoarc; b=jeJiXn423UCfiGzrkVQae5QVRZwbY+6Slpx+EyYFsyJ6DbXfkdCRYPPg+3mgKbS+6SqBWi55JrgTmT38QlGQZga6M9AazuyEmvrabMN+lv5HhZSZ4jGqeG25pu1s2hBFOZGpm1R/OXsU1/E5wyKaA1fHPMviWFsoEnx8jHL51So= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1560138295; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=A4PWSUdB4pkzbdZRfdxw1yQGZHF7OEb/trOhE49dk64=; b=IL5uvh1IisAtbcU6YQqHoA26JvRZDDrHYQIonqTmuTpbYfSk7SW71lbfJqmHO03CH0xCU1Z46DahPtHQdDBccpKZa77te31e7fBQuh2i9jtwwPLi1r9Hh/h7hNaVjumPm6VBMHFQo/5xY00idlxTCC0pHcz5YUb8lGB91QpnJEY= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1560138295235305.7458969762788; Sun, 9 Jun 2019 20:44:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4418458E33; Mon, 10 Jun 2019 03:44:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B2BF60852; Mon, 10 Jun 2019 03:44:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E6BAAE161; Mon, 10 Jun 2019 03:44:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x5A3igRe011099 for ; Sun, 9 Jun 2019 23:44:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 45DF85B685; Mon, 10 Jun 2019 03:44:42 +0000 (UTC) Received: from mx1.redhat.com (ext-mx10.extmail.prod.ext.phx2.redhat.com [10.5.110.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 412D25B684 for ; Mon, 10 Jun 2019 03:44:40 +0000 (UTC) Received: from mx2.mail.vl.ru (mx2.mail.vl.ru [80.92.161.251]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C5D0558E33 for ; Mon, 10 Jun 2019 03:44:36 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mx2.mail.vl.ru (Postfix) with ESMTP id B841B1850FF1 for ; Mon, 10 Jun 2019 03:44:31 +0000 (UTC) Received: from mx2.mail.vl.ru ([127.0.0.1]) by localhost (smtp2.srv.loc [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8xEviDTTLlW0; Mon, 10 Jun 2019 13:44:30 +1000 (+10) Received: from plumber.farpost.loc (unknown [95.154.107.219]) (Authenticated sender: turchanov@vl.ru) by mx2.mail.vl.ru (Postfix) with ESMTPSA id DC70F1850FD6; Mon, 10 Jun 2019 13:44:26 +1000 (+10) X-Virus-Scanned: amavisd-new at mail.vl.ru From: Sergei Turchanov To: libvir-list@redhat.com Date: Mon, 10 Jun 2019 13:44:18 +1000 Message-Id: <20190610034418.2394-1-turchanov@farpost.com> X-Greylist: Sender passed SPF test, Sender IP whitelisted by DNSRBL, ACL 216 matched, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 10 Jun 2019 03:44:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 10 Jun 2019 03:44:37 +0000 (UTC) for IP:'80.92.161.251' DOMAIN:'mx2.mail.vl.ru' HELO:'mx2.mail.vl.ru' FROM:'turchanov@farpost.com' RCPT:'' X-RedHat-Spam-Score: -0.01 (RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS) 80.92.161.251 mx2.mail.vl.ru 80.92.161.251 mx2.mail.vl.ru X-Scanned-By: MIMEDefang 2.78 on 10.5.110.39 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Sergei Turchanov Subject: [libvirt] [PATCH] Fix regression in lxcOpenNamespace X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 10 Jun 2019 03:44:53 +0000 (UTC) Content-Type: text/plain; charset="utf-8" This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1 fdlist[i] erroneously was replaced by fdlist[1] which caused lxcOpenNamespace to return a list with identical elements. --- libvirt-lxc-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c index 60c2e48..d7af154 100644 --- a/libvirt-lxc-override.c +++ b/libvirt-lxc-override.c @@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTR= IBUTE_UNUSED, goto error; =20 for (i =3D 0; i < c_retval; i++) - VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), err= or); + VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), err= or); =20 cleanup: VIR_FREE(fdlist); --=20 2.17.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list