From nobody Mon Apr 29 12:13:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558711035; cv=none; d=zoho.com; s=zohoarc; b=J5Z0O6A4rMmhNrWuc6fgUn6xeNy4OIY1R6aBMZeoPRjCRwBshDoD2O+yUPX9V7+wzBgJDQ2XEXDMUdyL2yw+kj7R9uVb2J6Eyzi6UGkimoSdpjkQVqCilWyhxucDA0xOzDJ+yTXBOw0aUkSFSFu3HZVhltDDqf/GKVtP6vH7qSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558711035; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=HpCW2pQOIBBLahm1HYPaJPO/i4aPWgIktLN2U3pLkTg=; b=WmTsoKvdLDDYTZSFWXzumaOrgkKxtof9M/J9QyoXpPfqUO6toQvhzwAqri0W019ABFLhtJJzOgBf0GsTgDFGCXttXeC6VwLVCaeeWF0LFMscyviAGcvw0mjZTs0sMRQe0i8Xb9YS5+of6tybPvtAOxgZvBppyhbVsMhPZDmn8Vg= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1558711035099160.01958958356204; Fri, 24 May 2019 08:17:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0DF3C3003A5B; Fri, 24 May 2019 15:16:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98B072CFD6; Fri, 24 May 2019 15:16:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E26EF4EBD7; Fri, 24 May 2019 15:16:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4OFGLw9019544 for ; Fri, 24 May 2019 11:16:21 -0400 Received: by smtp.corp.redhat.com (Postfix) id D58987D57D; Fri, 24 May 2019 15:16:21 +0000 (UTC) Received: from laerte.brq.redhat.com (unknown [10.43.2.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3536F7D57C; Fri, 24 May 2019 15:16:14 +0000 (UTC) From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= To: libvir-list@redhat.com Date: Fri, 24 May 2019 17:16:14 +0200 Message-Id: <20190524151614.27209-1-fidencio@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Subject: [libvirt] [glib PATCH] docs: explicitly link against libvirt-g{config, lib, object} X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 24 May 2019 15:17:13 +0000 (UTC) Let's explicitly link against the built libvirt-gconfig, libvirt-glib, and libvirt-gobject libtool files for introspecting the gobjects. In case it's *not* done we can run into some issues when where we try to link against installed library, causing failures related to undefined reference of the new symbols. Signed-off-by: Fabiano Fid=C3=AAncio Reviewed-by: Andrea Bolognani --- This issue was caught by libvirt-jenkins-ci on a debian-9 machine only. However, it's easily reproducible with other distros. https://ci.centos.org/job/libvirt-glib-build/systems=3Dlibvirt-debian-9/445= /console --- docs/libvirt-gconfig/Makefile.am | 5 ++++- docs/libvirt-glib/Makefile.am | 5 ++++- docs/libvirt-gobject/Makefile.am | 5 ++++- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/docs/libvirt-gconfig/Makefile.am b/docs/libvirt-gconfig/Makefi= le.am index 6a3df37..7d02354 100644 --- a/docs/libvirt-gconfig/Makefile.am +++ b/docs/libvirt-gconfig/Makefile.am @@ -34,6 +34,9 @@ GTKDOC_CFLAGS=3D \ GTKDOC_LIBS =3D \ $(GOBJECT2_LIBS) \ $(LIBXML2_LIBS) \ - $(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la + $(top_builddir)/libvirt-glib/libvirt-glib-1.0.la \ + $(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la \ + $(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la \ + $(NULL) =20 include $(top_srcdir)/gtk-doc.make diff --git a/docs/libvirt-glib/Makefile.am b/docs/libvirt-glib/Makefile.am index 186f8ff..e3445b9 100644 --- a/docs/libvirt-glib/Makefile.am +++ b/docs/libvirt-glib/Makefile.am @@ -36,7 +36,10 @@ GTKDOC_LIBS =3D \ $(LIBVIRT_LIBS) \ $(GLIB2_LIBS) \ $(GTHREAD2_LIBS) \ - $(top_builddir)/libvirt-glib/libvirt-glib-1.0.la + $(top_builddir)/libvirt-glib/libvirt-glib-1.0.la \ + $(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la \ + $(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la \ + $(NULL) =20 include $(top_srcdir)/gtk-doc.make =20 diff --git a/docs/libvirt-gobject/Makefile.am b/docs/libvirt-gobject/Makefi= le.am index c068a96..f54c389 100644 --- a/docs/libvirt-gobject/Makefile.am +++ b/docs/libvirt-gobject/Makefile.am @@ -36,6 +36,9 @@ GTKDOC_LIBS =3D \ $(LIBVIRT_LIBS) \ $(GOBJECT2_LIBS) \ $(GIO2_LIBS) \ - $(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la + $(top_builddir)/libvirt-glib/libvirt-glib-1.0.la \ + $(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la \ + $(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la \ + $(NULL) =20 include $(top_srcdir)/gtk-doc.make --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list