[libvirt] [glib PATCH] docs: explicitly link against libvirt-g{config, lib, object}

Fabiano Fidêncio posted 1 patch 4 years, 10 months ago
Failed in applying to current master (apply log)
docs/libvirt-gconfig/Makefile.am | 5 ++++-
docs/libvirt-glib/Makefile.am    | 5 ++++-
docs/libvirt-gobject/Makefile.am | 5 ++++-
3 files changed, 12 insertions(+), 3 deletions(-)
[libvirt] [glib PATCH] docs: explicitly link against libvirt-g{config, lib, object}
Posted by Fabiano Fidêncio 4 years, 10 months ago
Let's explicitly link against the built libvirt-gconfig, libvirt-glib,
and libvirt-gobject libtool files for introspecting the gobjects.

In case it's *not* done we can run into some issues when where we try to
link against installed library, causing failures related to undefined
reference of the new symbols.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
---
This issue was caught by libvirt-jenkins-ci on a debian-9 machine only.
However, it's easily reproducible with other distros.

https://ci.centos.org/job/libvirt-glib-build/systems=libvirt-debian-9/445/console
---
 docs/libvirt-gconfig/Makefile.am | 5 ++++-
 docs/libvirt-glib/Makefile.am    | 5 ++++-
 docs/libvirt-gobject/Makefile.am | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/docs/libvirt-gconfig/Makefile.am b/docs/libvirt-gconfig/Makefile.am
index 6a3df37..7d02354 100644
--- a/docs/libvirt-gconfig/Makefile.am
+++ b/docs/libvirt-gconfig/Makefile.am
@@ -34,6 +34,9 @@ GTKDOC_CFLAGS= \
 GTKDOC_LIBS = \
 	$(GOBJECT2_LIBS) \
 	$(LIBXML2_LIBS) \
-	$(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la
+	$(top_builddir)/libvirt-glib/libvirt-glib-1.0.la \
+	$(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la \
+	$(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la \
+	$(NULL)
 
 include $(top_srcdir)/gtk-doc.make
diff --git a/docs/libvirt-glib/Makefile.am b/docs/libvirt-glib/Makefile.am
index 186f8ff..e3445b9 100644
--- a/docs/libvirt-glib/Makefile.am
+++ b/docs/libvirt-glib/Makefile.am
@@ -36,7 +36,10 @@ GTKDOC_LIBS = \
 	$(LIBVIRT_LIBS) \
 	$(GLIB2_LIBS) \
 	$(GTHREAD2_LIBS) \
-	$(top_builddir)/libvirt-glib/libvirt-glib-1.0.la
+	$(top_builddir)/libvirt-glib/libvirt-glib-1.0.la \
+	$(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la \
+	$(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la \
+	$(NULL)
 
 include $(top_srcdir)/gtk-doc.make
 
diff --git a/docs/libvirt-gobject/Makefile.am b/docs/libvirt-gobject/Makefile.am
index c068a96..f54c389 100644
--- a/docs/libvirt-gobject/Makefile.am
+++ b/docs/libvirt-gobject/Makefile.am
@@ -36,6 +36,9 @@ GTKDOC_LIBS = \
 	$(LIBVIRT_LIBS) \
 	$(GOBJECT2_LIBS) \
 	$(GIO2_LIBS) \
-	$(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la
+	$(top_builddir)/libvirt-glib/libvirt-glib-1.0.la \
+	$(top_builddir)/libvirt-gconfig/libvirt-gconfig-1.0.la \
+	$(top_builddir)/libvirt-gobject/libvirt-gobject-1.0.la \
+	$(NULL)
 
 include $(top_srcdir)/gtk-doc.make
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [glib PATCH] docs: explicitly link against libvirt-g{config, lib, object}
Posted by Andrea Bolognani 4 years, 10 months ago
On Fri, 2019-05-24 at 17:16 +0200, Fabiano Fidêncio wrote:
> Let's explicitly link against the built libvirt-gconfig, libvirt-glib,
> and libvirt-gobject libtool files for introspecting the gobjects.
> 
> In case it's *not* done we can run into some issues when where we try to
> link against installed library, causing failures related to undefined
> reference of the new symbols.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
> ---
> This issue was caught by libvirt-jenkins-ci on a debian-9 machine only.
> However, it's easily reproducible with other distros.
> 
> https://ci.centos.org/job/libvirt-glib-build/systems=libvirt-debian-9/445/console
> ---
>  docs/libvirt-gconfig/Makefile.am | 5 ++++-
>  docs/libvirt-glib/Makefile.am    | 5 ++++-
>  docs/libvirt-gobject/Makefile.am | 5 ++++-
>  3 files changed, 12 insertions(+), 3 deletions(-)

Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list