[libvirt] [PATCH] rpm: remove dependancy from qemu to network/storage drivers

Daniel P. Berrangé posted 1 patch 4 years, 10 months ago
Test syntax-check passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190517133903.20797-1-berrange@redhat.com
libvirt.spec.in | 3 ---
1 file changed, 3 deletions(-)
[libvirt] [PATCH] rpm: remove dependancy from qemu to network/storage drivers
Posted by Daniel P. Berrangé 4 years, 10 months ago
The libvirt-daemon-driver-qemu RPM has historically had a hard
dependency on the libvirt-daemon-driver-network and
libvirt-daemon-driver-storage-core packages. This was because the QEMU
driver would directly call into APIs that were part of these drivers.

The dependency to the storage driver was eliminated in

  commit 064fec69be4a4673e0df17b007bf781026c3b4b2
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Thu Jan 25 09:35:46 2018 +0000

    storage: move storage file backend framework into util directory

The dependency to the network driver was eliminated in

  commit 5b13570ab8b43ec3c590399ec5a7644d91082149
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   Thu Jan 25 09:35:47 2018 +0000

    conf: introduce callback registration for domain net device allocation

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

Previously sent as patch of the the network refactor but it can in
fact be merged now as it doesn't depend on it directly.

 libvirt.spec.in | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 5c27a44fc5..b159c50d8f 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -720,9 +720,6 @@ parted and more.
 Summary: QEMU driver plugin for the libvirtd daemon
 Requires: libvirt-daemon = %{version}-%{release}
 Requires: libvirt-libs = %{version}-%{release}
-# There really is a hard cross-driver dependency here
-Requires: libvirt-daemon-driver-network = %{version}-%{release}
-Requires: libvirt-daemon-driver-storage-core = %{version}-%{release}
 Requires: /usr/bin/qemu-img
 # For image compression
 Requires: gzip
-- 
2.21.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] rpm: remove dependancy from qemu to network/storage drivers
Posted by Michal Privoznik 4 years, 10 months ago
On 5/17/19 3:39 PM, Daniel P. Berrangé wrote:
> The libvirt-daemon-driver-qemu RPM has historically had a hard
> dependency on the libvirt-daemon-driver-network and
> libvirt-daemon-driver-storage-core packages. This was because the QEMU
> driver would directly call into APIs that were part of these drivers.
> 
> The dependency to the storage driver was eliminated in
> 
>    commit 064fec69be4a4673e0df17b007bf781026c3b4b2
>    Author: Daniel P. Berrangé <berrange@redhat.com>
>    Date:   Thu Jan 25 09:35:46 2018 +0000
> 
>      storage: move storage file backend framework into util directory
> 
> The dependency to the network driver was eliminated in
> 
>    commit 5b13570ab8b43ec3c590399ec5a7644d91082149
>    Author: Daniel P. Berrangé <berrange@redhat.com>
>    Date:   Thu Jan 25 09:35:47 2018 +0000
> 
>      conf: introduce callback registration for domain net device allocation
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> 
> Previously sent as patch of the the network refactor but it can in
> fact be merged now as it doesn't depend on it directly.
> 
>   libvirt.spec.in | 3 ---
>   1 file changed, 3 deletions(-)

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list