From nobody Fri May 3 19:24:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1558088182; cv=none; d=zoho.com; s=zohoarc; b=DMdlp+JItP95bH+GnTyTctDes+QlZRyvCl7mn0WpY0dDgNR6MjuIcUdnXd91pwyETVitiWU0/dn5WmsNJq5j4CpXoRMpKhEYaaOwOWe7ueu8SPqPnlgYywibOnOqMmlzfTxk8TOvbJEPi2rjEMx5BFh18T/JG+ii6covto+s6/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1558088182; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=zlSdGvI/J3xsbHruRqGqdECK/AwZIAUqBqMWNHxJ9No=; b=ak9TvWT4Ejo6KQL5xvuAcoRAcwvu33dknVeZFxd1ptRkaTWjF2S/yvtQpE4OZizAIQQDralrN55ZN2uswjc6DSh/J6DgvqkUc8CA+p/NXnqICBJexWfr4amFKhYReQ+FTiZAQmR+ADZBAfYyFjy09b4eKezK2Vhg1R+sdcgAHgw= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1558088182920203.49064214847238; Fri, 17 May 2019 03:16:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5242A3086205; Fri, 17 May 2019 10:16:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4F5D5F9DC; Fri, 17 May 2019 10:16:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 80DB424B25; Fri, 17 May 2019 10:15:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x4HAFu0J022185 for ; Fri, 17 May 2019 06:15:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id EE294611DB; Fri, 17 May 2019 10:15:56 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9FA4578375; Fri, 17 May 2019 10:15:50 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Fri, 17 May 2019 11:15:48 +0100 Message-Id: <20190517101548.16155-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2] src: don't statically link code that's already in libvirt.so X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 17 May 2019 10:16:21 +0000 (UTC) Various binaries are statically linking to libvirt_util.la and other intermediate libraries we build. These intermediate libs all get built into the main libvirt.so shared library eventually, so we can dynamically link to that instead and reduce the on disk footprint. In libvirt-daemon RPM: virtlockd: 1.6 MB -> 153 KB virtlogd: 1.6 MB -> 157 KB libvirt_iohelper: 937 KB -> 23 KB In libvirt-daemon-driver-network RPM: libvirt_leaseshelper: 940 KB -> 26 KB In libvirt-daemon-driver-storage-core RPM: libvirt_parthelper: 926 KB -> 21 KB IOW, about 5.6 MB total space saving Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- src/Makefile.am | 2 +- src/libvirt_remote.syms | 1 + src/locking/Makefile.inc.am | 4 +--- src/logging/Makefile.inc.am | 4 +--- src/network/Makefile.inc.am | 2 +- src/security/Makefile.inc.am | 2 -- src/storage/Makefile.inc.am | 2 +- 7 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 7d452a9490..0b562dc250 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -851,7 +851,7 @@ libvirt_iohelper_LDFLAGS =3D \ $(PIE_LDFLAGS) \ $(NULL) libvirt_iohelper_LDADD =3D \ - libvirt_util.la \ + libvirt.la \ ../gnulib/lib/libgnu.la if WITH_DTRACE_PROBES libvirt_iohelper_LDADD +=3D libvirt_probes.lo diff --git a/src/libvirt_remote.syms b/src/libvirt_remote.syms index 98586d1584..3d68f6ce0a 100644 --- a/src/libvirt_remote.syms +++ b/src/libvirt_remote.syms @@ -176,6 +176,7 @@ virNetServerClientSetAuthLocked; virNetServerClientSetAuthPendingLocked; virNetServerClientSetCloseHook; virNetServerClientSetDispatcher; +virNetServerClientSetQuietEOF; virNetServerClientSetReadonly; virNetServerClientStartKeepAlive; virNetServerClientWantCloseLocked; diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index da26fab91f..46ab11c2a9 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -145,10 +145,8 @@ virtlockd_LDFLAGS =3D \ $(NO_UNDEFINED_LDFLAGS) \ $(NULL) virtlockd_LDADD =3D \ + libvirt.la \ libvirt_driver_admin.la \ - libvirt-net-rpc-server.la \ - libvirt-net-rpc.la \ - libvirt_util.la \ ../gnulib/lib/libgnu.la \ $(CYGWIN_EXTRA_LIBADD) \ $(NULL) diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index f5eba2a4f7..d57394cbde 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -80,9 +80,7 @@ virtlogd_LDFLAGS =3D \ $(NULL) virtlogd_LDADD =3D \ libvirt_driver_admin.la \ - libvirt-net-rpc-server.la \ - libvirt-net-rpc.la \ - libvirt_util.la \ + libvirt.la \ ../gnulib/lib/libgnu.la \ $(CYGWIN_EXTRA_LIBADD) \ $(NULL) diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index 3fed59c13b..52270049d5 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -56,7 +56,7 @@ libvirt_leaseshelper_LDFLAGS =3D \ $(PIE_LDFLAGS) \ $(NULL) libvirt_leaseshelper_LDADD =3D \ - libvirt_util.la \ + libvirt.la \ ../gnulib/lib/libgnu.la if WITH_DTRACE_PROBES libvirt_leaseshelper_LDADD +=3D libvirt_probes.lo diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am index 7fb6d8cc4f..64e0f46857 100644 --- a/src/security/Makefile.inc.am +++ b/src/security/Makefile.inc.am @@ -72,8 +72,6 @@ virt_aa_helper_LDFLAGS =3D \ $(NULL) virt_aa_helper_LDADD =3D \ libvirt.la \ - libvirt_conf.la \ - libvirt_util.la \ libvirt_driver_storage_impl.la \ ../gnulib/lib/libgnu.la \ $(NULL) diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index ea4681f70e..538709256d 100644 --- a/src/storage/Makefile.inc.am +++ b/src/storage/Makefile.inc.am @@ -378,7 +378,7 @@ libvirt_parthelper_LDFLAGS =3D \ $(NULL) libvirt_parthelper_LDADD =3D \ $(LIBPARTED_LIBS) \ - libvirt_util.la \ + libvirt.la \ ../gnulib/lib/libgnu.la \ $(NULL) if WITH_DTRACE_PROBES --=20 2.21.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list