[libvirt] [jenkins-ci PATCH 3/4] guests: Don't call out to the shell twice

Andrea Bolognani posted 4 patches 61 weeks ago

[libvirt] [jenkins-ci PATCH 3/4] guests: Don't call out to the shell twice

Posted by Andrea Bolognani 61 weeks ago
We're already doing this for FreeBSD, so do it for CentOS
and Fedora as well.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
 guests/playbooks/update/tasks/base.yml | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml
index 59f6124..8fe114e 100644
--- a/guests/playbooks/update/tasks/base.yml
+++ b/guests/playbooks/update/tasks/base.yml
@@ -56,16 +56,7 @@
     - package_format == 'pkg'
 
 - name: Clean up packages after update
-  command: '{{ package_manager }} clean packages -y'
-  args:
-    warn: no
-  when:
-    - package_format == 'rpm'
-
-- name: Clean up packages after update
-  command: '{{ package_manager }} autoremove -y'
-  args:
-    warn: no
+  shell: '{{ package_manager }} clean packages -y && {{ package_manager }} autoremove -y'
   when:
     - package_format == 'rpm'
 
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [jenkins-ci PATCH 3/4] guests: Don't call out to the shell twice

Posted by Daniel P. Berrangé 61 weeks ago
On Tue, May 07, 2019 at 03:17:41PM +0200, Andrea Bolognani wrote:
> We're already doing this for FreeBSD, so do it for CentOS
> and Fedora as well.
> 
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
> ---
>  guests/playbooks/update/tasks/base.yml | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list