[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.

Julio Faracco posted 1 patch 4 years, 11 months ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20190430002954.14080-1-jcfaracco@gmail.com
src/util/virnetdevbridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.
Posted by Julio Faracco 4 years, 11 months ago
This commit is similar with 692400f4. It fixes an uninitialized
variable to avoid garbage value. This case, returns 0 jiffies if an
error occurs with virNetDevBridgeGet.

Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
---
 src/util/virnetdevbridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c
index 0f301d9216..4f21a82fb7 100644
--- a/src/util/virnetdevbridge.c
+++ b/src/util/virnetdevbridge.c
@@ -713,7 +713,7 @@ int virNetDevBridgeGetSTPDelay(const char *brname,
                                int *delayms)
 {
     int ret = -1;
-    unsigned long val;
+    unsigned long val = 0;
 
     ret = virNetDevBridgeGet(brname, "forward_delay", &val);
     *delayms = JIFFIES_TO_MS(val);
-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage value.
Posted by Michal Privoznik 4 years, 11 months ago
On 4/30/19 2:29 AM, Julio Faracco wrote:
> This commit is similar with 692400f4. It fixes an uninitialized
> variable to avoid garbage value. This case, returns 0 jiffies if an
> error occurs with virNetDevBridgeGet.
> 
> Signed-off-by: Julio Faracco <jcfaracco@gmail.com>
> ---
>   src/util/virnetdevbridge.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c
> index 0f301d9216..4f21a82fb7 100644
> --- a/src/util/virnetdevbridge.c
> +++ b/src/util/virnetdevbridge.c
> @@ -713,7 +713,7 @@ int virNetDevBridgeGetSTPDelay(const char *brname,
>                                  int *delayms)
>   {
>       int ret = -1;
> -    unsigned long val;
> +    unsigned long val = 0;
>   
>       ret = virNetDevBridgeGet(brname, "forward_delay", &val);
>       *delayms = JIFFIES_TO_MS(val);
> 


ACKed and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list