From nobody Sun Feb 8 03:33:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555521599; cv=none; d=zoho.com; s=zohoarc; b=RkbGUbTE2MHc9sH4GjmAtCN6f9CgI0A8nofnNjgzkDzUtEvIpr1B9Sd4+IuUNOSKh3FA+5wVeAFN/n2QEQl2ltO73CvzISDpTuyZlwiVh9HUdYOtgowdLnWeBnGtswgPJOaSCSgS0pAU/KQXfgRaEu75Vdq4sZzx30hva74fUQU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555521599; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=MN2B/tpp54JhPORbRpK9M9JVtqOynS4lDI2mCGWxZ5M=; b=M+o+3F6p/wSypdakDxteOZQNmqbW9HTfdzijBueDHhb7bNNSJJ1e7gbCiZ4ZJQjJ0wVMkM2tbQcMDRnhb4uLb3k9Nz0E6B/Ym47E2o2IRmyHJDFf4betxhk1A8MP1Tup4KOdybpuh5m8uNQzt4zJxP6QwyBDGrun1PyMNl8c8+4= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1555521599252837.4828003115423; Wed, 17 Apr 2019 10:19:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9CAD93B73D; Wed, 17 Apr 2019 17:19:57 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 770B95C22B; Wed, 17 Apr 2019 17:19:57 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3130D3FB14; Wed, 17 Apr 2019 17:19:57 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3HHJaj8030494 for ; Wed, 17 Apr 2019 13:19:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id 92C135D707; Wed, 17 Apr 2019 17:19:36 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-35.ams2.redhat.com [10.36.112.35]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B78E5D6A6; Wed, 17 Apr 2019 17:19:34 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Date: Wed, 17 Apr 2019 18:19:01 +0100 Message-Id: <20190417171929.9399-2-berrange@redhat.com> In-Reply-To: <20190417171929.9399-1-berrange@redhat.com> References: <20190417171929.9399-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: Laine Stump Subject: [libvirt] [PATCH v4 01/29] network: ensure floor sum is reset to zero when starting networks X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 17 Apr 2019 17:19:58 +0000 (UTC) In extreme cases libvirt can get mixed up about what VMs are running and attached to a network leading to the cached floor sum value being outdated. When this happens the only option is to destroy the network and then restart libvirtd. If we set floor sum back to zero when starting the network, we avoid the need for a libvirtd restart at least. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump --- src/network/bridge_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 6e15e43ca6..3008846074 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2826,6 +2826,8 @@ networkStartNetwork(virNetworkDriverStatePtr driver, goto cleanup; } =20 + virNetworkObjSetFloorSum(obj, 0); + /* finally we can call the 'started' hook script if any */ if (networkRunHook(obj, NULL, NULL, VIR_HOOK_NETWORK_OP_STARTED, --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list