From nobody Thu Apr 25 23:19:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555079508; cv=none; d=zoho.com; s=zohoarc; b=nxmIa+TIJm657qjrToUJq05RMvXX+Bmj8+5zSwZjnlZDybXMzU7HoDenziVSRkh97V/g+yQWmubnlWkLrUHtHfLUoLF5KRm7Wn/ZjelattIuwY1KgSrpvlanaAWTk8jqQurifvKc0gVktpjs6CjajQ2cHzUhz9NUSE3gUcR3KGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555079508; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=3+1S2rP3jB2iOLXBhLabfU8hW3NXmvEYnmHWbuCZCBY=; b=hN8VXTQXHV5vE+yDlzkQ98mFhvDRRFnz9ycpTXpjfWXX1zS79fOL5GcX7kNHMDD7mKwcJYSgPrbo1LUnvgb7kOLGdysXlwNmGCUfJ3WnOg+Ywyx9rPcGJVI+FdYi6WBvOyYuOPBx4HxGhOirMDUN2LIrOG8syE2zaSrAOtgSrOo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1555079508991678.0068364961626; Fri, 12 Apr 2019 07:31:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 12320C08456A; Fri, 12 Apr 2019 14:31:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B458460C97; Fri, 12 Apr 2019 14:31:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F381C181AC44; Fri, 12 Apr 2019 14:31:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3CEVglX019811 for ; Fri, 12 Apr 2019 10:31:42 -0400 Received: by smtp.corp.redhat.com (Postfix) id 41E7C108BEEA; Fri, 12 Apr 2019 14:31:42 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC75C1001E82 for ; Fri, 12 Apr 2019 14:31:41 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 12 Apr 2019 16:31:35 +0200 Message-Id: <20190412143136.16975-2-abologna@redhat.com> In-Reply-To: <20190412143136.16975-1-abologna@redhat.com> References: <20190412143136.16975-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 1/2] guests: Install ncurses for libvirt X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 12 Apr 2019 14:31:47 +0000 (UTC) Content-Type: text/plain; charset="utf-8" As of libvirt commit c98de2173e95, we use pkg-config to obtain CFLAGS and LIBS for readline whenever possible. However, since the readline.pc file contains a Requires.private for a module that's shipped with ncurses (the actual module varies based on the platform) we will end up falling back to the old library detection if said library is not installed on the system. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/vars/mappings.yml | 8 ++++++++ guests/vars/projects/libvirt.yml | 1 + 2 files changed, 9 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 05d312d..464c403 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -603,6 +603,14 @@ mappings: nano: default: nano =20 + ncurses: + deb: libncurses-dev + pkg: ncurses + rpm: ncurses-devel + Debian9: libncurses5-dev + Ubuntu18: libncurses5-dev + cross-policy-deb: foreign + netcf: deb: libnetcf-dev rpm: netcf-devel diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvir= t.yml index f813f21..688dfa3 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -38,6 +38,7 @@ packages: - libxml2 - lvm2 - modprobe + - ncurses - netcf - numad - openwsman --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list From nobody Thu Apr 25 23:19:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555079535; cv=none; d=zoho.com; s=zohoarc; b=gryz5K9ymF8eMiK5wCuayLpFvYLczytiGK88yzh+1tN3ghIrSWzIzOjr05EZvJQD1lvSZ8kOgWaPJW7kAsw7p9CGXDqTJMIRORRBopzFI3mNfdVoVeO4Ghavmvw2yHHI5LlRbRTzQ2J5q59fdxCkqlk1oS5d0p+MdfVv+7+1ONY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555079535; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=qJ5oukriXUbEu87155a+W+3KBWRLr5fJ0XCynaN200U=; b=Z1blJOeQmuvaFkDTuH8HqbaX0dhu+z428MxF4v4q27fmle9q+kz168QCKxCsqKAgx1vrOOI6lg+ihCcmzeWa6b6K7TA5D1tdtZ1lHhwzBPE5jtT1lCxkTI+g2kd/yzFbTqmqXih3tNCmrIzekUK7VTCxIXXgDq9WFe3LSk51s4k= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1555079535509841.0564695573386; Fri, 12 Apr 2019 07:32:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1BF630AA3AD; Fri, 12 Apr 2019 14:32:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C2EBC5D6A9; Fri, 12 Apr 2019 14:32:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 726BB181AC46; Fri, 12 Apr 2019 14:32:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3CEVhSn019880 for ; Fri, 12 Apr 2019 10:31:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 12D201001E82; Fri, 12 Apr 2019 14:31:43 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8E2C1108BEEA for ; Fri, 12 Apr 2019 14:31:42 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Fri, 12 Apr 2019 16:31:36 +0200 Message-Id: <20190412143136.16975-3-abologna@redhat.com> In-Reply-To: <20190412143136.16975-1-abologna@redhat.com> References: <20190412143136.16975-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [jenkins-ci PATCH 2/2] guests: Remove readline symlink kludge X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 12 Apr 2019 14:32:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" It's no longer needed as of libvirt commit dfe06e6202e4. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- guests/playbooks/update/tasks/kludges.yml | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/u= pdate/tasks/kludges.yml index 708e7a4..3648514 100644 --- a/guests/playbooks/update/tasks/kludges.yml +++ b/guests/playbooks/update/tasks/kludges.yml @@ -1,18 +1,4 @@ --- -# libvirt can't detect these automatically at the moment, so a kludge -# is required. Can be dropped it as soon as libvirt has been fixed -- name: Create compatibility symlinks - file: - src: '/usr/local/{{ item }}' - dest: '/usr/{{ item }}' - state: link - force: yes - with_items: - - include/readline - - lib/libreadline.so - when: - - os_name =3D=3D 'FreeBSD' - # FreeBSD compiles bash without defining SSH_SOURCE_BASHRC, which means # it won't try to detect when it's spawned by ssh and source ~/.bashrc # when that's the case. Our workaround is setting $BASH_ENV globally --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list