From nobody Fri Apr 26 19:53:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555005298; cv=none; d=zoho.com; s=zohoarc; b=EkMDBaFgohEkPQ44I8B0NScJ8Gq3mU7PIbLioYnaQQ3KLYlFNrrvuZrFt3PiQEYIL+IMVLze7GbZ1n/4iKmzf6KFC8vfUilVNrfP2IkZy2OV5Pf+HKe/NEZLkDQmlES1DxIV6MzQGdvMLpbPNhUYcQkuISKqkO13KrgJepxzPZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555005298; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=taIDRQeEajKIE3t4Y1kd695VY5HGKYRZJoXxxsse9WM=; b=ChFWaSeASXffYFeeyaMUBtNmozkzaV1Uf2vyiccYHPFx2b+rfqlYiUIpBEm3LcQhPTMbizLEKq8Eq9GCeCTVd7ThHS4h6I+K5QKGsE1YDzzvW1ueNEH8K8osWqgZRYOmRxap0wgLDYgo/kDvaATvG/RvN5jsjIti8Bn4ikMd160= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1555005298014368.75944446927735; Thu, 11 Apr 2019 10:54:58 -0700 (PDT) Received: from localhost ([127.0.0.1]:52900 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEduV-0002TX-4b for importer@patchew.org; Thu, 11 Apr 2019 13:54:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hEdtg-00029f-BZ for qemu-devel@nongnu.org; Thu, 11 Apr 2019 13:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hEdtf-0007go-5P for qemu-devel@nongnu.org; Thu, 11 Apr 2019 13:54:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35584) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hEdte-0007fE-Sz for qemu-devel@nongnu.org; Thu, 11 Apr 2019 13:53:59 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DAB43168914 for ; Thu, 11 Apr 2019 17:53:57 +0000 (UTC) Received: from thuth.com (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id 23B81600CC; Thu, 11 Apr 2019 17:53:50 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org, "Michael S . Tsirkin" Date: Thu, 11 Apr 2019 19:53:45 +0200 Message-Id: <20190411175345.19414-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Thu, 11 Apr 2019 17:53:57 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH for-QEMU-4.1] Declare -realtime as deprecated X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libvir-list@redhat.com, Paolo Bonzini , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The old -realtime mlock=3Don|off parameter does exactly the same as the new -overcommit mem-lock=3Don|off parameter. Additionally, "-realtime" does not activate any additional "realtime" capabilities as the name might indicate. We should avoid to confuse the users this way, so let's deprecate the old -realtime option. Signed-off-by: Thomas Huth Reviewed-by: Eduardo Habkost --- Deprecation has already been suggested last year: https://patchwork.kernel.org/patch/10480963/#22026215 ... but apparently we forgot to really do it. qemu-deprecated.texi | 5 +++++ vl.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2219386769..2c45204f3f 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -72,6 +72,11 @@ backend settings instead of environment variables. To e= ase migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options. =20 +@subsection -realtime (since 4.1) + +The @code{-realtime mlock=3Don|off} argument has been replaced by the +@code{-overcommit mem-lock=3Don|off} argument. + @section QEMU Machine Protocol (QMP) commands =20 @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) diff --git a/vl.c b/vl.c index c696ad2a13..d6a2779b70 100644 --- a/vl.c +++ b/vl.c @@ -3912,6 +3912,8 @@ int main(int argc, char **argv, char **envp) } break; case QEMU_OPTION_realtime: + warn_report("'-realtime mlock=3D...' is deprecated, please= use " + "'-overcommit mem-lock=3D...' instead"); opts =3D qemu_opts_parse_noisily(qemu_find_opts("realtime"= ), optarg, false); if (!opts) { --=20 2.21.0