From nobody Sat May 11 02:37:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1555002230; cv=none; d=zoho.com; s=zohoarc; b=kqVM3ud5nOTRmoJFGdvgW7eUqMwx+5NZ2MwwIwiuUznavH1Z3mf2wmFe85JAatFzwUGHbMFTqacA42IHVQL/xaEr0n6WfAOUseqz+qZtWs9dpLP9spDaiIXG7faJFbR5JX8t4GqBbBDp1kVOexVh/B/YfZSzhUCX01PR/56EslY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1555002230; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=DPE+EJNKLhtpN5A1mXqLV31pwvXoFCtwodDWG60BhB0=; b=JB9x5DNqpTgAkBib9XRgyhSkJiOJgQsUQ1AupyA5eQJm2uLilC+GkLjyOVM0UJdTcl7WvB6qfPJCCMmfhVob7cMP4h4ePOEMKtFz5r4BK3yq0CRd16wDp88TfVaWGEHOG3GKR5FOjWiXoLAPxrlYZlqSz4XhezVZIn2DAzD+ECE= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=null header.from= header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1555002229990517.9446630373192; Thu, 11 Apr 2019 10:03:49 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D36838B108; Thu, 11 Apr 2019 17:03:39 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59CBD5D704; Thu, 11 Apr 2019 17:03:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8B62B181AC44; Thu, 11 Apr 2019 17:03:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x3BH3PgT001917 for ; Thu, 11 Apr 2019 13:03:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id EC81F19C65; Thu, 11 Apr 2019 17:03:25 +0000 (UTC) Received: from vhost2.laine.org (ovpn-117-161.phx2.redhat.com [10.3.117.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95DA819C58; Thu, 11 Apr 2019 17:03:23 +0000 (UTC) From: Laine Stump To: libvir-list@redhat.com Date: Thu, 11 Apr 2019 13:03:19 -0400 Message-Id: <20190411170319.18165-1-laine@laine.org> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: Eric Garver Subject: [libvirt] [PATCH] build: set --without-firewalld-zone in configure commandline for Fedora 30 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 11 Apr 2019 17:03:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The firewalld package in Fedora 30 didn't get support for rich rule priorities, which is required by the libvirt zonefile that's installed when the build is configured with --with-firewalld-zone, so we need to set --without-firewalld-zone for that version of Fedora. The needed feature is already upstream in firewalld, so it just needs another upstream release to be there. Let's be optimistic and assume that will happen prior to F31. Signed-off-by: Laine Stump Acked-by: Eric Garver Reviewed-by: Daniel P. Berrang=C3=A9 --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 8ea27c91a3..18f0a0e217 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -137,7 +137,7 @@ =20 %define with_firewalld 1 =20 -%if 0%{?fedora} >=3D 30 || 0%{?rhel} > 7 +%if 0%{?fedora} >=3D 31 || 0%{?rhel} > 7 %define with_firewalld_zone 0%{!?_without_firewalld_zone:1} %endif =20 --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list