From nobody Mon Feb 9 05:40:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1554820092; cv=none; d=zoho.com; s=zohoarc; b=QkSBe2v+t1qmlt7qgZOM4ikSFhrGXIqy06uQQHPU1jINBwpXwlzGrdPau17cuxeHboEoa1VEO13rVLWGeLwIvcDFF26weFX3NWWLztD4/QYviVY7Y+rPdDbZF9GhSrPVkTnhDEkfpkEgd4Ze35fK1Y7oH/mz5MWPjBdQuZHGTII= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1554820092; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=jG1Lgvi0fTcyiDVb3DSnAjaT/78jx61XSBuk9eA1BAQ=; b=NCXo/puxNwlpuhTicse2SHxU2tutSXNNZz12bgioN6UGQ1W45q4/xFnSNpQLf7if+KiwRKeS34tY6ymH5JXKkOK0/BliqfCQtH5CC6CwizubCiJNTy3GxWY5pSiEMoU5ZLqcCJpw8Lyz5UWzfHtmUJsm2cYLSJEL06gpepsmmgI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1554820092631851.0807065198998; Tue, 9 Apr 2019 07:28:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E4BF63078ADD; Tue, 9 Apr 2019 14:28:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B103217CE4; Tue, 9 Apr 2019 14:28:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 56062181B9ED; Tue, 9 Apr 2019 14:28:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x39ERwSv024265 for ; Tue, 9 Apr 2019 10:27:59 -0400 Received: by smtp.corp.redhat.com (Postfix) id EF4DF19731; Tue, 9 Apr 2019 14:27:58 +0000 (UTC) Received: from kinshicho.brq.redhat.com (unknown [10.43.2.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 75D7817B56 for ; Tue, 9 Apr 2019 14:27:58 +0000 (UTC) From: Andrea Bolognani To: libvir-list@redhat.com Date: Tue, 9 Apr 2019 16:27:48 +0200 Message-Id: <20190409142750.32034-6-abologna@redhat.com> In-Reply-To: <20190409142750.32034-1-abologna@redhat.com> References: <20190409142750.32034-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 5/7] m4: readline: Drop extra_LIBS machinery X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Tue, 09 Apr 2019 14:28:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" The first implementation of this logic was introduced with commit 2ec759fc58fe all the way back in 2007; looking at the build logs from our CI environment, however, it's apparent that none of the platforms we currently target are actually using it, so we can assume whatever issue it was working around has been fixed at some point in the last 12 years. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- m4/virt-readline.m4 | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/m4/virt-readline.m4 b/m4/virt-readline.m4 index 998b891d53..6f0090056a 100644 --- a/m4/virt-readline.m4 +++ b/m4/virt-readline.m4 @@ -22,20 +22,6 @@ AC_DEFUN([LIBVIRT_ARG_READLINE],[ ]) =20 AC_DEFUN([LIBVIRT_CHECK_READLINE],[ - extra_LIBS=3D - lv_saved_libs=3D$LIBS - if test "x$with_readline" !=3D xno; then - # Linking with -lreadline may require some termcap-related code, e.g., - # from one of the following libraries. Add it to LIBS before using - # canned library checks; then verify later if it was needed. - LIBS=3D - AC_SEARCH_LIBS([tgetent], [ncurses curses termcap termlib]) - case $LIBS in - no*) ;; # handle "no" and "none required" - *) extra_LIBS=3D$LIBS ;; # anything else is a -lLIBRARY - esac - LIBS=3D"$lv_saved_libs $extra_LIBS" - fi =20 # This function is present in all reasonable (5.0+) readline versions; # however, the macOS base system contains a library called libedit which @@ -59,14 +45,6 @@ AC_DEFUN([LIBVIRT_CHECK_READLINE],[ # The normal library check... LIBVIRT_CHECK_LIB([READLINE], [readline], [readline], [readline/readline= .h]) =20 - # Touch things up to avoid $extra_LIBS, if possible. Test a second - # function, to ensure we aren't being confused by caching. - LIBS=3D$lv_saved_libs - AC_CHECK_LIB([readline], [rl_initialize], - [], - [READLINE_LIBS=3D"$READLINE_LIBS $extra_LIBS"]) - LIBS=3D$lv_saved_libs - # We need this to avoid compilation issues with modern compilers. # See 9ea3424a178 for a more detailed explanation if test "$with_readline" =3D "yes" ; then --=20 2.20.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list